From: ezequiel.garcia@free-electrons.com (Ezequiel Garcia)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/4] Kirkwood: minor cleanups
Date: Mon, 30 Sep 2013 18:26:16 -0300 [thread overview]
Message-ID: <20130930212615.GA8823@localhost> (raw)
In-Reply-To: <20130930211650.GF6735@lunn.ch>
On Mon, Sep 30, 2013 at 11:16:50PM +0200, Andrew Lunn wrote:
> > The third and fourth patch are related: the latter strictly depends on
> > the former. The idea behind these two patches is basically to convert
> > the "keep the ethernet clocks enabled by calling clk_enable()" hack
> > into a simpler and cleaner usage of the CLK_IGNORE_UNUSED flags which
> > prevent these clocks from being ever gated.
>
> Hi Ezequiel
>
> This should work, but what would be nicer is to look and see if there
> is a node in DT for each device. If it does not have a node, don't set
> CLK_IGNORE_UNUSED, so that the clock does get turned off, and we save
> a bit of power. Quite a few of the kirkwood devices only have one
> ethernet.
>
Good idea. I'll take a look at it.
--
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
prev parent reply other threads:[~2013-09-30 21:26 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-30 21:03 [PATCH 0/4] Kirkwood: minor cleanups Ezequiel Garcia
2013-09-30 21:03 ` [PATCH 1/4] ARM: kirkwood: Remove unneeded MBus initialization Ezequiel Garcia
2013-10-08 16:19 ` Jason Cooper
2013-09-30 21:03 ` [PATCH 2/4] ARM: kirkwood: Remove unneeded PCIe clock adding Ezequiel Garcia
2013-10-01 16:01 ` Ezequiel Garcia
2013-10-01 17:45 ` Jason Gunthorpe
2013-10-01 19:20 ` Arnaud Ebalard
2013-10-08 16:22 ` Jason Cooper
2013-09-30 21:03 ` [PATCH 3/4] clk: kirkwood: Add CLK_IGNORE_UNUSED to ethernet ge0 and ge1 clocks Ezequiel Garcia
2013-09-30 21:31 ` Jason Gunthorpe
2013-09-30 21:34 ` Andrew Lunn
2013-09-30 21:44 ` Jason Gunthorpe
2013-10-01 14:35 ` Jason Cooper
2013-10-01 0:40 ` Jason Cooper
2013-10-01 13:42 ` Ezequiel Garcia
2013-10-01 13:49 ` Sebastian Hesselbarth
2013-10-01 14:22 ` Ezequiel Garcia
2013-10-01 14:43 ` Sebastian Hesselbarth
2013-10-01 16:45 ` Jason Gunthorpe
2013-10-01 16:49 ` Jason Cooper
2013-10-01 19:10 ` Sebastian Hesselbarth
2013-10-01 19:15 ` Sebastian Hesselbarth
2013-10-02 12:02 ` Jason Cooper
2013-10-02 12:05 ` Sebastian Hesselbarth
2013-10-01 13:58 ` Jason Cooper
2013-10-01 14:17 ` Ezequiel Garcia
2013-10-01 15:01 ` Jason Cooper
2013-10-01 15:09 ` Thomas Petazzoni
2013-10-01 15:15 ` Jason Cooper
2013-10-01 15:33 ` Thomas Petazzoni
2013-10-01 15:36 ` Jason Cooper
2013-10-01 15:42 ` Thomas Petazzoni
2013-10-01 15:53 ` Jason Cooper
2013-10-01 15:59 ` Sebastian Hesselbarth
2013-10-08 16:24 ` Jason Cooper
2013-09-30 21:03 ` [PATCH 4/4] ARM: kirkwood: Remove redundant ethernet clock enable Ezequiel Garcia
2013-09-30 21:16 ` [PATCH 0/4] Kirkwood: minor cleanups Andrew Lunn
2013-09-30 21:26 ` Ezequiel Garcia [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130930212615.GA8823@localhost \
--to=ezequiel.garcia@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).