public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: jason@lakedaemon.net (Jason Cooper)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: armada-370: fix tclk frequencies
Date: Wed, 2 Oct 2013 13:04:49 -0400	[thread overview]
Message-ID: <20131002170448.GO31178@titan.lakedaemon.net> (raw)
In-Reply-To: <20131002165754.GE1356@kw.sim.vm.gnt>

On Wed, Oct 02, 2013 at 06:57:54PM +0200, Simon Guinot wrote:
> On Wed, Oct 02, 2013 at 12:22:21PM -0400, Jason Cooper wrote:
> > Simon,
> > 
> > On Wed, Oct 02, 2013 at 05:56:58PM +0200, Simon Guinot wrote:
> > > Signed-off-by: Simon Guinot <simon.guinot@sequanux.org>
> > 
> > Could you elaborate on this?  What symptom did you notice?  How did this
> > fix it?  When was the regression introduced?
> 
> Hi Jason,
> 
> While benchmarking Linux 3.12-rc3 on an Armada-370-RD, I noticed bad
> networking performances... After some investigations, I found out that
> the coalescence configuration (derived from the tclk) was suspect.
> 
> While checking for the tclk value, I found this typo. There is not much
> to say about this patch except that the correct tclk frequencies for
> Armada-370 are 166 and 200MHz, not 16.6 and 20MHz.

Yes, I know it's simple, but it's a huge help to us when trying to
decide whether or not to flag it for stable.  fwiw, the regression was
introduced by:

  6b72333d clk: mvebu: add Armada 370 SoC-centric clock init

and this should be applied from v3.11 onwards.

thx,

Jason.

  reply	other threads:[~2013-10-02 17:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-02 15:56 [PATCH] clk: armada-370: fix tclk frequencies Simon Guinot
2013-10-02 16:22 ` Jason Cooper
2013-10-02 16:57   ` Simon Guinot
2013-10-02 17:04     ` Jason Cooper [this message]
2013-10-03  9:00       ` Simon Guinot
2013-10-03 12:17         ` Jason Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131002170448.GO31178@titan.lakedaemon.net \
    --to=jason@lakedaemon.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox