From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/2] ARM: include: asm: use 'int' instead of 'unsigned long' for 'oldval' in atomic_cmpxchg().
Date: Wed, 9 Oct 2013 11:48:59 +0100 [thread overview]
Message-ID: <20131009104858.GB6564@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <5253E583.5020805@asianux.com>
On Tue, Oct 08, 2013 at 11:59:15AM +0100, Chen Gang wrote:
> For atomic_cmpxchg(), the type of 'oldval' need be 'int' to match the
> type of "*ptr" (used by 'ldrex' instruction) and 'old' (used by 'teq'
> instruction).
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> ---
> arch/arm/include/asm/atomic.h | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/include/asm/atomic.h b/arch/arm/include/asm/atomic.h
> index a715ac0..9ee7e01 100644
> --- a/arch/arm/include/asm/atomic.h
> +++ b/arch/arm/include/asm/atomic.h
> @@ -114,7 +114,8 @@ static inline int atomic_sub_return(int i, atomic_t *v)
>
> static inline int atomic_cmpxchg(atomic_t *ptr, int old, int new)
> {
> - unsigned long oldval, res;
> + int oldval;
> + unsigned long res;
>
> smp_mb();
As discussed, this is completely cosmetic, but does at least keep the file
consistent.
Reviewed-by: Will Deacon <will.deacon@arm.com>
Will
next prev parent reply other threads:[~2013-10-09 10:48 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-21 11:06 [PATCH] ARM: include: asm: atomic.h: use type cast 's64' for the return value of atomic64_add_return() Chen Gang
2013-09-24 9:30 ` Will Deacon
2013-09-24 10:27 ` Russell King - ARM Linux
2013-09-24 10:37 ` Chen Gang
2013-09-24 10:30 ` Chen Gang
2013-09-25 2:25 ` [PATCH v2] ARM: include: asm: use 'long long' instead of 'u64' within atomic.h Chen Gang
2013-09-25 16:07 ` Will Deacon
2013-09-26 2:00 ` Chen Gang
2013-09-26 10:04 ` Will Deacon
2013-09-26 11:03 ` Chen Gang
2013-09-27 11:06 ` Will Deacon
2013-09-27 11:36 ` Chen Gang
2013-09-29 3:43 ` [PATCH 0/2] ARM: include: asm: change functions' and variables' types in atomic.h Chen Gang
2013-09-29 3:43 ` [PATCH 1/2] ARM: include: asm: use 'long long' instead of 'u64' within atomic.h Chen Gang
2013-09-29 3:52 ` [PATCH 2/2] ARM: include: asm: use 'int' instead of 'unsigned long' for normal register variables " Chen Gang
2013-09-30 16:11 ` Will Deacon
2013-10-01 2:05 ` Chen Gang
2013-10-01 9:01 ` Will Deacon
2013-10-01 12:03 ` Chen Gang
2013-10-02 10:41 ` Will Deacon
2013-10-02 15:19 ` Chen Gang
2013-10-03 10:05 ` Chen Gang
2013-10-03 16:32 ` Will Deacon
2013-10-04 9:51 ` Chen Gang
2013-10-04 15:37 ` Will Deacon
2013-10-04 15:42 ` Will Deacon
2013-10-04 23:55 ` Chen Gang
2013-10-05 0:11 ` Chen Gang
2013-10-08 4:10 ` Chen Gang
2013-10-08 10:34 ` Will Deacon
2013-10-08 10:56 ` [PATCH v2 0/2] ARM: include: asm: change functions' and variables' types in atomic.h Chen Gang
2013-10-08 10:57 ` [PATCH v2 1/2] ARM: include: asm: use 'long long' instead of 'u64' within atomic.h Chen Gang
2013-10-08 10:59 ` [PATCH v2 2/2] ARM: include: asm: use 'int' instead of 'unsigned long' for 'oldval' in atomic_cmpxchg() Chen Gang
2013-10-09 10:48 ` Will Deacon [this message]
2013-10-10 0:56 ` Chen Gang
2013-10-09 10:46 ` [PATCH v2 1/2] ARM: include: asm: use 'long long' instead of 'u64' within atomic.h Will Deacon
2013-10-08 11:00 ` [PATCH 2/2] ARM: include: asm: use 'int' instead of 'unsigned long' for normal register variables " Chen Gang
2013-10-08 10:33 ` Will Deacon
2013-10-08 11:29 ` Chen Gang
2013-10-08 17:49 ` Will Deacon
2013-10-09 0:18 ` Chen Gang
2013-10-09 1:22 ` Chen Gang
2013-09-30 16:07 ` [PATCH 1/2] ARM: include: asm: use 'long long' instead of 'u64' " Will Deacon
2013-10-01 2:09 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131009104858.GB6564@mudshark.cambridge.arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).