linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pinctrl: phandle entries will be applied sequentially
Date: Thu, 10 Oct 2013 11:08:40 +0100	[thread overview]
Message-ID: <20131010100840.GP25034@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20131010072624.GA29191@S2101-09.ap.freescale.net>

On Thu, Oct 10, 2013 at 03:26:26PM +0800, Shawn Guo wrote:
> However, my patch is talking about a different thing.  For example, we
> have a device whose pinctrl-0 consists of two phandle entries that point
> to pin configuration nodes foo and bar.
> 
> 	pinctrl-0 = <&foo &bar>;
> 
> 	foo {
> 		...
> 	};
> 
> 	bar {
> 		...
> 	};
> 
> My patch only wants to make it clear that the configuration specified by
> node foo will be applied to pin controller first, and the configuration
> defined in node bar will be applied after that.  When both nodes have
> configuration for a pin, these two configs for the same pin go to two
> different pinctrl_setting structures.  And these two pinctrl_settings
> can not be applied accumulatedly but only sequentially.  That's what my
> patch talks about.

I still say this is a potentially dangerous thing, and in my case of
overriding the DAT3 pull-sense, it will cause the pin to glitch if
nothing is connected to it.

So even if you do get this clarified, I am *not* happy to change my
patch.

  parent reply	other threads:[~2013-10-10 10:08 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-09  5:42 [PATCH] pinctrl: phandle entries will be applied sequentially Shawn Guo
2013-10-09 12:40 ` Linus Walleij
2013-10-09 12:44   ` Russell King - ARM Linux
2013-10-09 13:09     ` Linus Walleij
2013-10-09 13:45       ` Russell King - ARM Linux
2013-10-09 14:14         ` Linus Walleij
2013-10-10  8:08       ` Shawn Guo
2013-10-09 15:58     ` Stephen Warren
2013-10-10  7:26   ` Shawn Guo
2013-10-10  8:03     ` Linus Walleij
2013-10-10 10:12       ` Shawn Guo
2013-10-10 10:08     ` Russell King - ARM Linux [this message]
2013-10-10 10:22       ` Shawn Guo
2013-10-10 10:23         ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131010100840.GP25034@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).