linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: steve.capper@linaro.org (Steve Capper)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2] ARM: mm: make UACCESS_WITH_MEMCPY huge page aware
Date: Fri, 11 Oct 2013 11:11:32 +0100	[thread overview]
Message-ID: <20131011101132.GA32526@linaro.org> (raw)
In-Reply-To: <20131011095751.GU25034@n2100.arm.linux.org.uk>

On Fri, Oct 11, 2013 at 10:57:51AM +0100, Russell King - ARM Linux wrote:
> On Wed, Sep 25, 2013 at 01:31:29PM +0100, Steve Capper wrote:
> > The memory pinning code in uaccess_with_memcpy.c does not check
> > for HugeTLB or THP pmds, and will enter an infinite loop should
> > a __copy_to_user or __clear_user occur against a huge page.
> 
> This patch causes a build error with certain configuration options:
> 
> arch/arm/lib/uaccess_with_memcpy.c: In function 'pin_page_for_write':
> arch/arm/lib/uaccess_with_memcpy.c:57:2: error: implicit declaration of function 'pmd_thp_or_huge'
> arch/arm/lib/uaccess_with_memcpy.c:60:3: error: implicit declaration of function 'pmd_hugewillfault'
> 
> found via a randconfig build, configuration:
> 
> http://www.arm.linux.org.uk/developer/build/file.php?type=config&idx=6265
> 
> > ---
> >  arch/arm/include/asm/pgtable-3level.h |  3 +++
> >  arch/arm/lib/uaccess_with_memcpy.c    | 41 ++++++++++++++++++++++++++++++++---
> >  2 files changed, 41 insertions(+), 3 deletions(-)
> 
> As the macros are in pgtable-3level.h, this won't work with any configuration
> using the 2level header file.

Hi Russell,
Apologies, that was careless rebasing on my part.

Would you like a fix for this, or should I send a new patch?

Thanks,
-- 
Steve

  reply	other threads:[~2013-10-11 10:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-25 12:31 [PATCH V2] ARM: mm: make UACCESS_WITH_MEMCPY huge page aware Steve Capper
2013-10-11  9:57 ` Russell King - ARM Linux
2013-10-11 10:11   ` Steve Capper [this message]
2013-10-11 10:37     ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131011101132.GA32526@linaro.org \
    --to=steve.capper@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).