From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 05/12] usb: phy-mxs: Add implementation of nofity_suspend and notify_resume
Date: Mon, 14 Oct 2013 04:08:51 +0200 [thread overview]
Message-ID: <201310140408.51758.marex@denx.de> (raw)
In-Reply-To: <20131014013651.GD3879@shlinux1.ap.freescale.net>
Dear Peter Chen,
> On Sat, Oct 12, 2013 at 11:42:06AM +0200, Marek Vasut wrote:
> > Dear Peter Chen,
> >
> > > Add notify_suspend and notify_resume according to different SoCs.
> > >
> > > Signed-off-by: Peter Chen <peter.chen@freescale.com>
> > > ---
> > >
> > > drivers/usb/phy/phy-mxs-usb.c | 73
> > >
> > > +++++++++++++++++++++++++++++++++++++++++ 1 files changed, 73
> > > insertions(+), 0 deletions(-)
> > >
> > > diff --git a/drivers/usb/phy/phy-mxs-usb.c
> > > b/drivers/usb/phy/phy-mxs-usb.c index e0b0de0..8661dae 100644
> > > --- a/drivers/usb/phy/phy-mxs-usb.c
> > > +++ b/drivers/usb/phy/phy-mxs-usb.c
> > > @@ -197,6 +197,78 @@ static int mxs_phy_on_disconnect(struct usb_phy
> > > *phy,
> > >
> > > return 0;
> > >
> > > }
> > >
> > > +static int mxs_phy_on_suspend_workaround(struct usb_phy *phy,
> > > + enum usb_device_speed speed)
> > > +{
> > > + dev_dbg(phy->dev, "%s speed device has suspended\n",
> > > + (speed == USB_SPEED_HIGH) ? "high" : "non-high");
> >
> > HS : FS/LS you mean?
>
> Yes, it is what I mean.
> OK, I will change to HS and FS/LS.
>
> > > +/*
> > > + * For mxs PHY, there are two PHY issues related to suspend/resume.
> > > + * For mx23 and mx28, both of two issues are existed.
> > > + * For mx6q and mx6dl, only one issue is existed.
> > > + * For mx6 sololite, none issue is existed.
> > > + */
> > > +static void mxs_phy_workaround(struct mxs_phy *mxs_phy)
> > > +{
> > > + if (is_mx23_phy(mxs_phy)) {
> >
> > This is_mx23_phy() returns 1 for mx28 too? It's not too clear, not even
> > from the comment above, a short comment here would help for sure.
>
> mx23 and mx28 PHY are the same PHY, so the fixes are the same.
> Anything I need to add?
I believe it's OK. But identifying MX28 PHY via is_mx23_phy() might be a little
confusing. I'm just trying to keep this driver flushed out of my brain here and
do an unbiased review ;-)
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-10-14 2:08 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-12 9:09 [PATCH 00/12] Add power management support for MXS PHY Peter Chen
2013-10-12 9:09 ` [PATCH 01/12] usb: phy-mxs: Add auto clock and power setting Peter Chen
2013-10-12 9:09 ` [PATCH 02/12] usb: phy-mxs: Enable IC fixes for mx6 SoC serial Peter Chen
2013-10-12 9:38 ` Marek Vasut
2013-10-14 1:31 ` Peter Chen
2013-10-14 2:07 ` Marek Vasut
2013-10-14 1:58 ` Peter Chen
2013-10-14 9:09 ` Shawn Guo
2013-10-14 9:09 ` Peter Chen
2013-10-14 9:29 ` Shawn Guo
2013-10-14 9:16 ` Peter Chen
2013-10-12 9:09 ` [PATCH 03/12] usb: phy-mxs: Add anatop regmap Peter Chen
2013-10-12 9:09 ` [PATCH 04/12] usb: phy: add notify suspend and resume callback Peter Chen
2013-10-12 9:09 ` [PATCH 05/12] usb: phy-mxs: Add implementation of nofity_suspend and notify_resume Peter Chen
2013-10-12 9:42 ` Marek Vasut
2013-10-14 1:36 ` Peter Chen
2013-10-14 2:08 ` Marek Vasut [this message]
2013-10-12 9:09 ` [PATCH 06/12] usb: phy: Add set_wakeup API Peter Chen
2013-10-12 9:09 ` [PATCH 07/12] usb: phy-mxs: Add implementation of set_wakeup Peter Chen
2013-10-12 9:44 ` Marek Vasut
2013-10-14 1:41 ` Peter Chen
2013-10-12 9:09 ` [PATCH 08/12] usb: phy-mxs: Add system suspend/resume API Peter Chen
2013-10-12 9:09 ` [PATCH 09/12] usb: phy-mxs: update binding for adding anatop phandle Peter Chen
2013-10-14 9:22 ` Shawn Guo
2013-10-14 9:10 ` Peter Chen
2013-10-12 9:09 ` [PATCH 10/12] ARM: dts: imx6: add anatop phandle for usbphy Peter Chen
2013-10-12 9:09 ` [PATCH 11/12] usb: phy-mxs: update binding for adding disconnect line property Peter Chen
2013-10-12 9:47 ` Marek Vasut
2013-10-14 1:44 ` Peter Chen
2013-10-12 15:05 ` Thomas Petazzoni
2013-10-14 1:45 ` Peter Chen
2013-10-12 9:09 ` [PATCH 12/12] ARM: dts: imx6: Add disconnect_line_without_vbus property for usbphy Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201310140408.51758.marex@denx.de \
--to=marex@denx.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).