linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 0/7] Optimize jump label implementation on ARM64
Date: Mon, 14 Oct 2013 17:04:20 +0100	[thread overview]
Message-ID: <20131014160419.GS25034@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <525C1469.4000906@gmail.com>

On Mon, Oct 14, 2013 at 11:57:29PM +0800, Jiang Liu wrote:
> On 10/14/2013 11:40 PM, Russell King - ARM Linux wrote:
> > On Sun, Oct 13, 2013 at 10:50:20PM +0800, Jiang Liu wrote:
> >> To enable this feature, your toolchain must support "asm goto" extension
> >> and "%c" constraint extesion. Current GCC for AARCH64 doesn't support
> >> "%c", so you need a GCC patch similiar to this:
> > 
> > Oh god, not that again.  I've no idea why ARM stuff has such a problem with
> > supporting this very useful "%c" GCC constraint.  Aarch32 didn't for ages
> > consequently we now have horrid hacks around it in the kernel source
> > because our compilers suck.  Seems Aarch64 is doomed to repeat the same
> > stupid mistakes. :(
> > 
> We need to do the same trick for ARM64 too:)

Just been locating it - it's part of the gcc internals documentation:

|  In the simplest case, a `%' followed by a digit N says to output
| operand N at that point in the string.
| 
|  `%' followed by a letter and a digit says to output an operand in an
| alternate fashion.  Four letters have standard, built-in meanings
| described below.  The machine description macro `PRINT_OPERAND' can
| define additional letters with nonstandard meanings.
| 
|  `%cDIGIT' can be used to substitute an operand that is a constant
| value without the syntax that normally indicates an immediate operand.
| ...
|  `%lDIGIT' is used to substitute a `label_ref' into a jump instruction.

%lDIGIT is used (but not commented upon) in the gcc extended asm
documentation where it talks about asm gotos, so there's probably a doc
bug here too about whether these options should be described in the
main doc as well.

Nevertheness, this section is documenting the _internals_ of gcc, and
it seems perverse for a gcc backend to ignore something that is
documented as being a standard part of gcc.

  reply	other threads:[~2013-10-14 16:04 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-13 14:50 [PATCH v2 0/7] Optimize jump label implementation on ARM64 Jiang Liu
2013-10-13 14:50 ` [PATCH v2 1/7] arm64: introduce basic aarch64 instruction decoding helpers Jiang Liu
2013-10-13 14:50 ` [PATCH v2 2/7] arm64: introduce interfaces to hotpatch kernel and module code Jiang Liu
2013-10-13 14:50 ` [PATCH v2 3/7] arm64: move encode_insn_immediate() from module.c to insn.c Jiang Liu
2013-10-13 14:50 ` [PATCH v2 4/7] arm64: introduce aarch64_insn_gen_{nop|branch_imm}() helper functions Jiang Liu
2013-10-14 14:24   ` [PATCH] " Jiang Liu
2013-10-13 14:50 ` [PATCH v2 5/7] arm64, jump label: detect %c support for ARM64 Jiang Liu
2013-10-13 14:50 ` [PATCH v2 6/7] arm64, jump label: optimize jump label implementation Jiang Liu
2013-10-13 14:50 ` [PATCH v2 7/7] jump_label: use defined macros instead of hard-coding for better readability Jiang Liu
2013-10-14 15:19 ` [PATCH v2 0/7] Optimize jump label implementation on ARM64 Will Deacon
2013-10-14 15:24   ` Jiang Liu
2013-10-14 15:40 ` Russell King - ARM Linux
2013-10-14 15:57   ` Jiang Liu
2013-10-14 16:04     ` Russell King - ARM Linux [this message]
2013-10-14 16:41       ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131014160419.GS25034@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).