public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: jason@lakedaemon.net (Jason Cooper)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: mvebu: dts: remove unneeded linux,default-state from led nodes
Date: Mon, 14 Oct 2013 14:36:33 -0400	[thread overview]
Message-ID: <20131014183633.GK5402@titan.lakedaemon.net> (raw)
In-Reply-To: <20131014182821.GD25095@lunn.ch>

On Mon, Oct 14, 2013 at 08:28:21PM +0200, Andrew Lunn wrote:
> On Mon, Oct 14, 2013 at 06:07:27PM +0000, Jason Cooper wrote:
> > Generally, power LEDs should indicate when power is applied, and go out
> > once power is removed.  _Not_ annoy the developer with migraine-inducing
> > blinking reminicent of some badly animated television series designed to
> > sell sugar to children.
> > 
> > On a more serious note, most of these OS-specific properties aren't
> > necessary and should be removed.  I left two that are legitimately tying
> > disk LEDs to disk activity.  Other than that, we keep the state the
> > bootloader left them in until userspace changes the state via sysfs.
> 
> Hi Jason
> 
> Do you know what happens with "keep" and the bootloader setting the
> LED to hardware blink? I'm just wondering if some of these default-on,
> are actually disabling hardware blinking and making it constant on?

hmmm, good question.  I'll let this patch sit for some time since it is
trivial and doesn't conflict with anything in mvebu/dt.  We'll see if
anyone says anything.

Regardless of the outcome, 'default-state = "on";' can be used instead
for that scenario.

thx,

Jason.

  reply	other threads:[~2013-10-14 18:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-14 18:07 [PATCH] ARM: mvebu: dts: remove unneeded linux, default-state from led nodes Jason Cooper
2013-10-14 18:28 ` [PATCH] ARM: mvebu: dts: remove unneeded linux,default-state " Andrew Lunn
2013-10-14 18:36   ` Jason Cooper [this message]
2013-10-28 15:17     ` Simon Baatz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131014183633.GK5402@titan.lakedaemon.net \
    --to=jason@lakedaemon.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox