linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: thierry.reding@gmail.com (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: mach-imx: clk-imx51-imx53: Remove return value from mx53_clocks_init()
Date: Tue, 15 Oct 2013 13:24:58 +0200	[thread overview]
Message-ID: <20131015112457.GO7856@ulmo.nvidia.com> (raw)
In-Reply-To: <1381337700-22465-1-git-send-email-festevam@gmail.com>

On Wed, Oct 09, 2013 at 01:55:00PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Commit 915cc59130b (Merge remote-tracking branch 'imx-mxs/for-next') tried to
> fix a conflict, but missed to remove the return value from mx53_clocks_init(),
> which causes the following build warning:
> 
> arch/arm/mach-imx/clk-imx51-imx53.c:579:2: warning: 'return' with a value, in function returning void [enabled by default]
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> Changes since v1:
> - Explain that the warning came from conflict resolution instead.
> 
>  arch/arm/mach-imx/clk-imx51-imx53.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/arm/mach-imx/clk-imx51-imx53.c b/arch/arm/mach-imx/clk-imx51-imx53.c
> index fa4de9a..ce37af2 100644
> --- a/arch/arm/mach-imx/clk-imx51-imx53.c
> +++ b/arch/arm/mach-imx/clk-imx51-imx53.c
> @@ -575,7 +575,5 @@ static void __init mx53_clocks_init(struct device_node *np)
>  	WARN_ON(!base);
>  	irq = irq_of_parse_and_map(np, 0);
>  	mxc_timer_init(base, irq);
> -
> -	return 0;
>  }
>  CLK_OF_DECLARE(imx53_ccm, "fsl,imx53-ccm", mx53_clocks_init);

Thanks, I've fixed that up in yesterday's linux-next merge conflict
resolution.

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131015/b06a3307/attachment.sig>

      reply	other threads:[~2013-10-15 11:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-09 16:55 [PATCH v2] ARM: mach-imx: clk-imx51-imx53: Remove return value from mx53_clocks_init() Fabio Estevam
2013-10-15 11:24 ` Thierry Reding [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131015112457.GO7856@ulmo.nvidia.com \
    --to=thierry.reding@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).