From: pdeschrijver@nvidia.com (Peter De Schrijver)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 03/15] clk: tegra: common periph_clk_enb_refcnt and clks
Date: Fri, 18 Oct 2013 15:18:29 +0300 [thread overview]
Message-ID: <20131018121829.GA25591@tbergstrom-lnx.Nvidia.com> (raw)
In-Reply-To: <CAL1qeaFrm50m0a3csY=04MNQENM_DY5fgBrq5bdsm8dHnLj1gA@mail.gmail.com>
On Fri, Oct 18, 2013 at 12:26:20AM +0200, Andrew Bresticker wrote:
> Hi Peter,
>
> > static void __init tegra30_clock_init(struct device_node *np)
> > {
> > struct device_node *node;
> > - int i;
> >
> > clk_base = of_iomap(np, 0);
> > if (!clk_base) {
> > @@ -1916,8 +1910,11 @@ static void __init tegra30_clock_init(struct device_node *np)
> > BUG();
> > }
> >
> > - if (tegra_clk_set_periph_banks(5) < 0)
> > + clks = tegra_clk_init(clk_max, 5);
> > + if (!clks) {
> > + WARN_ON(1);
>
> Really minor nit: it seems strange that we WARN here for t30, but not
> for t114 or t20.
There used to be a warning for all 3, but I removed it and apparently forgot
t30.
Cheers,
Peter.
next prev parent reply other threads:[~2013-10-18 12:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1382013526-12800-1-git-send-email-pdeschrijver@nvidia.com>
2013-10-17 12:38 ` [PATCH v4 03/15] clk: tegra: common periph_clk_enb_refcnt and clks Peter De Schrijver
2013-10-17 22:26 ` Andrew Bresticker
2013-10-18 12:18 ` Peter De Schrijver [this message]
2013-10-17 12:38 ` [PATCH v4 04/15] clk: tegra: Add TEGRA_PERIPH_NO_DIV flag Peter De Schrijver
2013-10-17 12:38 ` [PATCH v4 05/15] clk: tegra: move some PLLC and PLLXC init to clk-pll.c Peter De Schrijver
2013-10-17 22:33 ` Andrew Bresticker
2013-10-17 12:38 ` [PATCH v4 06/15] clk: tegra: move fields to tegra_clk_pll_params Peter De Schrijver
2013-10-17 22:59 ` Andrew Bresticker
2013-10-18 12:27 ` Peter De Schrijver
2013-10-17 12:38 ` [PATCH v4 07/15] clk: tegra: add header for common tegra clock IDs Peter De Schrijver
2013-10-17 12:38 ` [PATCH v4 08/15] clk: tegra: add common infra for DT clocks Peter De Schrijver
2013-10-17 12:38 ` [PATCH v4 09/15] clk: tegra: add clkdev registration infra Peter De Schrijver
2013-10-17 12:38 ` [PATCH v4 10/15] clk: tegra: move audio clk to common file Peter De Schrijver
2013-10-17 23:44 ` Andrew Bresticker
2013-10-17 12:38 ` [PATCH v4 11/15] clk: tegra: move periph clocks " Peter De Schrijver
2013-10-17 12:38 ` [PATCH v4 12/15] clk: tegra: move PMC, fixed clocks to common files Peter De Schrijver
2013-10-17 12:38 ` [PATCH v4 13/15] clk: tegra: introduce common gen4 super clock Peter De Schrijver
2013-10-17 12:38 ` [PATCH v4 14/15] clk: tegra: move tegra30 to common infra Peter De Schrijver
2013-10-17 12:38 ` [PATCH v4 15/15] clk: tegra: move tegra20 " Peter De Schrijver
[not found] ` <1382013526-12800-3-git-send-email-pdeschrijver@nvidia.com>
2013-10-17 22:15 ` [PATCH v4 02/15] clk: tegra: simplify periph clock data Andrew Bresticker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131018121829.GA25591@tbergstrom-lnx.Nvidia.com \
--to=pdeschrijver@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).