From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] imx6q: fix emergency restart
Date: Mon, 21 Oct 2013 00:22:17 +0100 [thread overview]
Message-ID: <20131020232217.GS25034@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1380832337-4637-1-git-send-email-nathan_lynch@mentor.com>
On Thu, Oct 03, 2013 at 03:32:17PM -0500, Nathan Lynch wrote:
> @@ -192,8 +188,15 @@ static void __init imx6q_1588_init(void)
>
> static void __init imx6q_init_machine(void)
> {
> + struct device_node *np;
> +
> imx6q_enet_phy_init();
>
> + np = of_find_compatible_node(NULL, NULL, "fsl,imx6q-wdt");
> + if (np)
> + wdog_base = of_iomap(np, 0);
> + pr_info("%s: wdog_base = %p\n", __func__, wdog_base);
I don't know whether this has been applied yet, but please don't add
to the kernel messages unnecessarily; there's already enough of them
and unless it provides something which is useful, it doesn't deserve
to be at "info" level. If you want it to report it for debugging,
then please use the debugging level.
Specifically for imx6q, I'm finding the boot is noisy enough that it
takes some time to find the bits you want to find amongst the 240-odd
lines it spits out.
Also, I don't see it in arm-soc yet - is there a reason this isn't
queued as a fix? Without it, using sysrq to force a reboot is rather
counter-productive.
Thanks.
next prev parent reply other threads:[~2013-10-20 23:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-03 20:32 [PATCH] imx6q: fix emergency restart Nathan Lynch
2013-10-03 20:52 ` Nathan Lynch
2013-10-04 1:26 ` Fabio Estevam
2013-10-06 9:09 ` Shawn Guo
2013-10-20 23:22 ` Russell King - ARM Linux [this message]
2013-10-21 0:35 ` Shawn Guo
2013-10-21 14:49 ` Nathan Lynch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131020232217.GS25034@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).