From: peter.chen@freescale.com (Peter Chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [Patch v2 10/14] usb: doc: phy-mxs: update binding for adding disconnect line property
Date: Wed, 23 Oct 2013 15:08:25 +0800 [thread overview]
Message-ID: <20131023070824.GH8534@shlinux1.ap.freescale.net> (raw)
In-Reply-To: <20131023063154.GG2839@S2101-09.ap.freescale.net>
On Wed, Oct 23, 2013 at 02:31:56PM +0800, Shawn Guo wrote:
> On Tue, Oct 22, 2013 at 01:58:44PM +0800, Peter Chen wrote:
> > This property is used to disconnect line between USB PHY and
> > USB controller.
> >
> > Signed-off-by: Peter Chen <peter.chen@freescale.com>
> > ---
> > Documentation/devicetree/bindings/usb/mxs-phy.txt | 4 ++++
> > 1 files changed, 4 insertions(+), 0 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/mxs-phy.txt b/Documentation/devicetree/bindings/usb/mxs-phy.txt
> > index 5837963..356c9b6 100644
> > --- a/Documentation/devicetree/bindings/usb/mxs-phy.txt
> > +++ b/Documentation/devicetree/bindings/usb/mxs-phy.txt
> > @@ -9,6 +9,9 @@ mxs PHY verions.
> > - reg: Should contain registers location and length
> > - interrupts: Should contain phy interrupt
> > - fsl,anatop: phandle for anatop register, it is only for mx6 SoC serial
> > +- disconnect-line-without-vbus: needs to disconnect
> > +connection between USB PHY and controller, it can avoid
> > +unexpected wakeup interrupt when the PHY is out of power
>
> If it's a mxs-phy specific property, we may need to have vendor prefix
> 'fsl,' for it.
>
> I see you set the property in imx6qdl.dtsi. Is it true that we should
> always set it for imx6q/dl? If yes, why cannot we have the driver to
> force it for imx6q type of phy. If no, where do we need to set it and
> where not?
>
One more thing: it is a SoC feature, so I can delete it from DT, and
using compatible string (or of_device_id.data) to judge if it is needed
at driver, do you think so?
--
Best Regards,
Peter Chen
next prev parent reply other threads:[~2013-10-23 7:08 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-22 5:58 [Patch v2 00/14] Add power management support for MXS PHY Peter Chen
2013-10-22 5:58 ` [Patch v2 01/14] usb: doc: phy-mxs: Add more compatible strings Peter Chen
2013-10-23 2:58 ` Shawn Guo
2013-10-23 5:56 ` Shawn Guo
2013-10-23 6:17 ` Peter Chen
2013-10-22 5:58 ` [Patch v2 02/14] usb: phy-mxs: Add platform judgement code Peter Chen
2013-10-23 6:13 ` Shawn Guo
2013-10-23 6:46 ` Peter Chen
2013-10-23 9:04 ` Shawn Guo
2013-10-23 8:55 ` Peter Chen
2013-10-22 5:58 ` [Patch v2 03/14] usb: phy-mxs: Add auto clock and power setting Peter Chen
2013-10-22 5:58 ` [Patch v2 04/14] usb: doc: phy-mxs: update binding for adding anatop phandle Peter Chen
2013-10-22 5:58 ` [Patch v2 05/14] ARM: dts: imx6: add anatop phandle for usbphy Peter Chen
2013-10-22 5:58 ` [Patch v2 06/14] usb: phy-mxs: Add anatop regmap Peter Chen
2013-10-22 5:58 ` [Patch v2 07/14] usb: phy: add notify suspend and resume callback Peter Chen
2013-10-22 5:58 ` [Patch v2 08/14] usb: phy-mxs: Add implementation of nofity_suspend and notify_resume Peter Chen
2013-10-22 5:58 ` [Patch v2 09/14] usb: phy-mxs: Enable IC fixes for mx6 SoC serial Peter Chen
2013-10-22 5:58 ` [Patch v2 10/14] usb: doc: phy-mxs: update binding for adding disconnect line property Peter Chen
2013-10-23 6:31 ` Shawn Guo
2013-10-23 6:49 ` Peter Chen
2013-10-23 7:08 ` Peter Chen [this message]
2013-10-23 8:44 ` Shawn Guo
2013-10-22 5:58 ` [Patch v2 11/14] ARM: dts: imx6: Add disconnect-line-without-vbus property for usbphy Peter Chen
2013-10-22 5:58 ` [Patch v2 12/14] usb: phy: Add set_wakeup API Peter Chen
2013-10-22 5:58 ` [Patch v2 13/14] usb: phy-mxs: Add implementation of set_wakeup Peter Chen
2013-10-23 6:35 ` Shawn Guo
2013-10-23 6:54 ` Peter Chen
2013-10-22 5:58 ` [Patch v2 14/14] usb: phy-mxs: Add system suspend/resume API Peter Chen
2013-10-22 9:29 ` [Patch v2 00/14] Add power management support for MXS PHY Peter Chen
2013-10-28 8:20 ` Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131023070824.GH8534@shlinux1.ap.freescale.net \
--to=peter.chen@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).