From mboxrd@z Thu Jan  1 00:00:00 1970
From: steve.capper@linaro.org (Steve Capper)
Date: Thu, 24 Oct 2013 13:55:31 +0100
Subject: ARM: add support to dump the kernel page tables
In-Reply-To: <20131024122306.GK16735@n2100.arm.linux.org.uk>
References: <20131024071600.GC16735@n2100.arm.linux.org.uk>
 <20131024105143.GA24288@linaro.org>
 <20131024122306.GK16735@n2100.arm.linux.org.uk>
Message-ID: <20131024125530.GA27357@linaro.org>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On Thu, Oct 24, 2013 at 01:23:06PM +0100, Russell King - ARM Linux wrote:
> On Thu, Oct 24, 2013 at 11:51:44AM +0100, Steve Capper wrote:
> > Hi Russell,
> > I've given this a quick go on an Arndale with LPAE, and have a few
> > suggestions below.
> 
> Thanks.
> 
> > > diff --git a/arch/arm/include/asm/pgtable-3level.h b/arch/arm/include/asm/pgtable-3level.h
> > > index 5689c18..d7682cd 100644
> > > --- a/arch/arm/include/asm/pgtable-3level.h
> > > +++ b/arch/arm/include/asm/pgtable-3level.h
> > > @@ -140,6 +140,7 @@
> > >  						 PMD_TYPE_TABLE)
> > >  #define pmd_sect(pmd)		((pmd_val(pmd) & PMD_TYPE_MASK) == \
> > >  						 PMD_TYPE_SECT)
> > > +#define pmd_large(pmd)		pmd_sect(pmd)
> > 
> > Could we please instead do something like:
> > #define pmd_large(pmd)         (pmd_val(pmd) && !(pmd_val(pmd) & PMD_TABLE_BIT))
> > 
> > This matches the logic used in the huge pages patches (it picks up the
> > PROT_NONE case) that would be missed above.
> 
> Is this used in the generic parts of the kernel?  Can you please point
> out where?
> 

Apologies I was a little vague. I don't think there are any PROT_NONE
protected kernel huge pages, I am worried that pmd_huge may be used by
other code (and then run into problems with PROT_NONE).

Cheers,
-- 
Steve