From mboxrd@z Thu Jan 1 00:00:00 1970 From: u.kleine-koenig@pengutronix.de (Uwe =?iso-8859-1?Q?Kleine-K=F6nig?=) Date: Thu, 24 Oct 2013 21:15:57 +0200 Subject: [PATCH 4/8] input: Remove OOM message after input_allocate_device In-Reply-To: <1382640528.22433.75.camel@joe-AO722> References: <20131024182611.GA3512@pengutronix.de> <1382640218.22433.71.camel@joe-AO722> <20131024184612.GC3512@pengutronix.de> <1382640528.22433.75.camel@joe-AO722> Message-ID: <20131024191557.GD3512@pengutronix.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Oct 24, 2013 at 11:48:48AM -0700, Joe Perches wrote: > On Thu, 2013-10-24 at 20:46 +0200, Uwe Kleine-K?nig wrote: > > On Thu, Oct 24, 2013 at 11:43:38AM -0700, Joe Perches wrote: > [] > > > Any k.alloc without __GFP_NOWARN does a generic OOM message > > > and a dump_stack() so there could already be 2 messages anyway. > > Then mention that in the commit log if you still want this patch?! > > How do you think this commit message should be changed: > > Emitting an OOM message isn't necessary after input_allocate_device > as there's a generic OOM and a dump_stack already done. after input_allocate_device and/or k.alloc ... Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |