From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mmc: sdhci-sirf: enable dmabounce since SiRFprimaII MMC DMA only access up to 256MB
Date: Sun, 27 Oct 2013 22:12:35 +0000 [thread overview]
Message-ID: <20131027221235.GF16735@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1382909030-7499-1-git-send-email-Baohua.Song@csr.com>
On Mon, Oct 28, 2013 at 05:23:50AM +0800, Barry Song wrote:
> @@ -92,6 +103,13 @@ static int sdhci_sirf_probe(struct platform_device *pdev)
> }
> }
>
> + if (of_machine_is_compatible("sirf,prima2")) {
> + if (pdev->dev.dma_mask)
> + *(pdev->dev.dma_mask) = SZ_256M - 1;
> + pdev->dev.coherent_dma_mask = SZ_256M - 1;
NAK. Please do not directly write to the DMA mask; this is not how DMA
masks should be setup. Please read up on the DMA API and specifically
in this case the dma_set_mask() / dma_set_coherent_mask() functions.
Also note that after the next merge window, those two calls should be
collapsed to dma_set_mask_and_coherent().
Thanks.
prev parent reply other threads:[~2013-10-27 22:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-27 21:23 [PATCH] mmc: sdhci-sirf: enable dmabounce since SiRFprimaII MMC DMA only access up to 256MB Barry Song
2013-10-27 22:12 ` Russell King - ARM Linux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131027221235.GF16735@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).