linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] pinctrl: imx: fix using pin->input_val wrongly
Date: Mon, 28 Oct 2013 08:54:01 +0100	[thread overview]
Message-ID: <20131028075401.GH30088@pengutronix.de> (raw)
In-Reply-To: <1382940076-11898-1-git-send-email-peter.chen@freescale.com>

On Mon, Oct 28, 2013 at 02:01:16PM +0800, Peter Chen wrote:
> The commit: "pinctrl: imx: Use struct type for pins" relaced
> pin->input_reg by pin->input_val wrongly, fix it at this commit.
> 
> Signed-off-by: Peter Chen <peter.chen@freescale.com>

Oops.

Acked-by: Sascha Hauer <s.hauer@pengutronix.de>

> ---
>  drivers/pinctrl/pinctrl-imx.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-imx.c b/drivers/pinctrl/pinctrl-imx.c
> index d78dd81..4779b8e 100644
> --- a/drivers/pinctrl/pinctrl-imx.c
> +++ b/drivers/pinctrl/pinctrl-imx.c
> @@ -245,11 +245,11 @@ static int imx_pmx_enable(struct pinctrl_dev *pctldev, unsigned selector,
>  			 * The input_reg[i] here is actually some IOMUXC general
>  			 * purpose register, not regular select input register.
>  			 */
> -			val = readl(ipctl->base + pin->input_val);
> +			val = readl(ipctl->base + pin->input_reg);
>  			val &= ~mask;
>  			val |= select << shift;
> -			writel(val, ipctl->base + pin->input_val);
> -		} else if (pin->input_val) {
> +			writel(val, ipctl->base + pin->input_reg);
> +		} else if (pin->input_reg) {
>  			/*
>  			 * Regular select input register can never be at offset
>  			 * 0, and we only print register value for regular case.
> -- 
> 1.7.1
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  reply	other threads:[~2013-10-28  7:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-28  6:01 [PATCH 1/1] pinctrl: imx: fix using pin->input_val wrongly Peter Chen
2013-10-28  7:54 ` Sascha Hauer [this message]
2013-11-04 12:05 ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131028075401.GH30088@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).