From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 3/5] usb: chipidea: imx: set CI_HDRC_IMX28_WRITE_FIX for imx28
Date: Mon, 28 Oct 2013 08:52:43 +0100 [thread overview]
Message-ID: <201310280852.43881.marex@denx.de> (raw)
In-Reply-To: <20131028020311.GB2839@S2101-09.ap.freescale.net>
Hi Shawn,
> On Sun, Oct 27, 2013 at 05:25:36PM +0100, Marek Vasut wrote:
> > > +static const struct of_device_id ci_hdrc_imx_dt_ids[] = {
> > > + { .compatible = "fsl,imx28-usb", .data = &imx28_usb_data},
> > > + { .compatible = "fsl,imx27-usb", .data = &imx27_usb_data},
> >
> > Just a nit-pick, but the order here is wrong ;-)
>
> Oh, no. Before of_match_device() gets improved to find the best match,
> we have to sort the table from the most specific entry to the most
> generic one.
Oh, thanks for explaining!
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-10-28 7:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-25 6:02 [PATCH v3 1/5] usb: ehci: add freescale imx28 special write register method Peter Chen
2013-10-25 6:02 ` [PATCH v3 2/5] usb: chipidea: " Peter Chen
2013-10-28 10:36 ` Hector Palacios
2013-10-28 10:47 ` Marek Vasut
2013-10-29 23:54 ` gregkh at linuxfoundation.org
2013-10-30 0:53 ` Peter Chen
2013-10-30 3:09 ` gregkh at linuxfoundation.org
2013-10-25 6:02 ` [PATCH v3 3/5] usb: chipidea: imx: set CI_HDRC_IMX28_WRITE_FIX for imx28 Peter Chen
2013-10-27 16:25 ` Marek Vasut
2013-10-28 2:03 ` Shawn Guo
2013-10-28 7:52 ` Marek Vasut [this message]
2013-10-25 6:02 ` [PATCH v3 4/5] usb: doc: chipidea: imx: add compatiable string for imx28 SoC Peter Chen
2013-10-27 16:26 ` Marek Vasut
2013-10-28 2:00 ` Peter Chen
2013-10-25 6:02 ` [PATCH v3 5/5] ARM: dts: imx28: changing usb compatible string as only "fsl, imx28-usb" Peter Chen
2013-10-25 8:23 ` [PATCH v3 5/5] ARM: dts: imx28: changing usb compatible string as only "fsl,imx28-usb" Shawn Guo
2013-10-25 8:14 ` Peter Chen
2013-10-25 8:46 ` Shawn Guo
2013-10-28 1:59 ` Peter Chen
2013-10-28 2:50 ` Shawn Guo
2013-10-28 8:24 ` [PATCH v3 1/5] usb: ehci: add freescale imx28 special write register method Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201310280852.43881.marex@denx.de \
--to=marex@denx.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).