From: sre@debian.org (Sebastian Reichel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 1/3] Input: twl4030-keypad - add device tree support
Date: Tue, 29 Oct 2013 02:06:08 +0100 [thread overview]
Message-ID: <20131029010608.GA5353@earth.universe> (raw)
In-Reply-To: <5137C017-2515-427C-865F-B938CC24B210@codeaurora.org>
On Mon, Oct 28, 2013 at 01:42:47AM -0500, Kumar Gala wrote:
> > +This binding is based on the matrix-keymap binding with the following
> > +changes:
>
> Maybe be a bit more specific and say 'based on the input/matrix-keymap.txt binding'..
OK.
> > + * keypad,num-rows and keypad,num-columns are required.
>
> Is linux,keymap required from matrix-keymap.txt?
Yes, matrix-keymap.txt contains descriptions for the following:
required:
- linux,keymap
optional:
- keypad,num-rows
- keypad,num-columns
> > +Optional Properties specific to linux:
> > +- linux,keypad-no-autorepeat: do no enable autorepeat feature.
>
> Does it make sense to update the matrix-keymap.txt binding to add
> 'linux,keypad-no-autorepeat' there?
At least according to devicetree documentation there are
keymap-matrix.txt based drivers, which do not support
"linux,keypad-no-autorepeat".
-- Sebastian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131029/c6090ce8/attachment-0001.sig>
next prev parent reply other threads:[~2013-10-29 1:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-22 12:47 [PATCHv2 0/3] Add Nokia N900 DT support Sebastian Reichel
2013-10-22 12:47 ` [PATCHv2 1/3] Input: twl4030-keypad - add device tree support Sebastian Reichel
2013-10-27 11:17 ` Pavel Machek
2013-10-27 11:40 ` Sebastian Reichel
2013-10-27 11:47 ` Pavel Machek
2013-10-27 12:23 ` Tony Lindgren
2013-10-27 16:31 ` Sebastian Reichel
2013-10-30 13:53 ` Grant Likely
2013-10-30 13:59 ` Pavel Machek
2013-10-28 6:42 ` Kumar Gala
2013-10-29 1:06 ` Sebastian Reichel [this message]
2013-10-29 8:33 ` Kumar Gala
2013-10-29 10:25 ` Sebastian Reichel
2013-10-22 12:47 ` [PATCHv2 2/3] DTS: ARM: TWL4030: Add keypad node Sebastian Reichel
2013-10-22 12:47 ` [PATCHv2 3/3] ARM: dts: N900: TWL4030 Keypad Matrix definition Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131029010608.GA5353@earth.universe \
--to=sre@debian.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).