[PATCH 0/2] Add support for OpenBlocks A7

[PATCH 0/2] Add support for OpenBlocks A7

[Thomas Petazzoni]

Dear Marvell EBU maintainers,

The small set of patches that follow add the support for the new
OpenBlocks A7 platform designed and sold by Plathome.

Best regards,

Thomas

Thomas Petazzoni (2):
  ARM: kirkwood: add support for OpenBlocks A7 platform
  ARM: kirkwood: enable HIGHMEM in defconfig

 arch/arm/boot/dts/Makefile                   |   3 +-
 arch/arm/boot/dts/kirkwood-openblocks_a7.dts | 223 +++++++++++++++++++++++++++
 arch/arm/configs/kirkwood_defconfig          |   1 +
 3 files changed, 226 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/boot/dts/kirkwood-openblocks_a7.dts

-- 
1.8.1.2

[PATCH 1/2] ARM: kirkwood: add support for OpenBlocks A7 platform

[Thomas Petazzoni]

The OpenBlocks A7 board is designed and sold by PlatHome, and based on
a Kirkwood 6283 Marvell SoC. It is quite similar to the OpenBlocks A6
already supported in the kernel, with the following main differences:

 - The A6 uses a RTC on I2C, while the A7 uses the internal SoC RTC.

 - The A6 has one Ethernet port, while the A7 has two Ethernet ports

 - The A6 has only one USB port, while the A7 integrates a USB hub,
   which provides two front-side USB port, and an internal USB port as
   well.

 - The A6 has 512 MB of RAM, while the A7 has 1 GB of RAM.

 - Slightly different GPIOs for some functions.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 arch/arm/boot/dts/Makefile                   |   3 +-
 arch/arm/boot/dts/kirkwood-openblocks_a7.dts | 223 +++++++++++++++++++++++++++
 2 files changed, 225 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/boot/dts/kirkwood-openblocks_a7.dts

diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 802720e..64783bb 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -101,7 +101,8 @@ dtb-$(CONFIG_ARCH_KIRKWOOD) += kirkwood-cloudbox.dtb \
 	kirkwood-topkick.dtb \
 	kirkwood-ts219-6281.dtb \
 	kirkwood-ts219-6282.dtb \
-	kirkwood-openblocks_a6.dtb
+	kirkwood-openblocks_a6.dtb \
+	kirkwood-openblocks_a7.dtb
 dtb-$(CONFIG_ARCH_MARCO) += marco-evb.dtb
 dtb-$(CONFIG_ARCH_MSM) += msm8660-surf.dtb \
 	msm8960-cdp.dtb
diff --git a/arch/arm/boot/dts/kirkwood-openblocks_a7.dts b/arch/arm/boot/dts/kirkwood-openblocks_a7.dts
new file mode 100644
index 0000000..1864972
--- /dev/null
+++ b/arch/arm/boot/dts/kirkwood-openblocks_a7.dts
@@ -0,0 +1,223 @@
+/*
+ * Device Tree file for OpenBlocks A7 board
+ *
+ * Copyright (C) 2013 Free Electrons
+ *
+ * Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
+ *
+ * This file is licensed under the terms of the GNU General Public
+ * License version 2.  This program is licensed "as is" without any
+ * warranty of any kind, whether express or implied.
+ */
+
+/dts-v1/;
+
+#include "kirkwood.dtsi"
+#include "kirkwood-6282.dtsi"
+
+/ {
+	model = "Plat'Home OpenBlocksA7";
+	compatible = "plathome,openblocks-a7", "marvell,kirkwood-88f6283", "marvell,kirkwood";
+
+	memory {
+		device_type = "memory";
+		reg = <0x00000000 0x40000000>; /* 1 GB */
+	};
+
+	chosen {
+		bootargs = "console=ttyS0,115200n8 earlyprintk";
+	};
+
+	ocp at f1000000 {
+		serial at 12000 {
+			status = "ok";
+			pinctrl-0 = <&pmx_uart0>;
+			pinctrl-names = "default";
+		};
+
+		serial at 12100 {
+			status = "ok";
+			pinctrl-0 = <&pmx_uart1>;
+			pinctrl-names = "default";
+		};
+
+		nand at 3000000 {
+			chip-delay = <25>;
+			status = "okay";
+			pinctrl-0 = <&pmx_nand>;
+			pinctrl-names = "default";
+
+			partition at 0 {
+				label = "uboot";
+				reg = <0x0 0x1c0000>;
+			};
+
+			partition at 90000 {
+				label = "env";
+				reg = <0x1c0000 0x2c0000>;
+			};
+
+			partition at d4000 {
+				label = "test";
+				reg = <0x480000 0x160000>;
+			};
+
+			partition at f4000 {
+				label = "conf";
+				reg = <0x5e0000 0x540000>;
+			};
+
+			partition at 4f4000 {
+				label = "linux";
+				reg = <0xb20000 0x3d40000>;
+			};
+
+			partition at 2214000 {
+				label = "user";
+				reg = <0x4860000 0xb7a0000>;
+			};
+		};
+
+		sata at 80000 {
+			nr-ports = <1>;
+			status = "okay";
+		};
+
+		i2c at 11100 {
+			status = "okay";
+			pinctrl-0 = <&pmx_twsi1>;
+			pinctrl-names = "default";
+
+			s24c02: s24c02 at 50 {
+				compatible = "24c02";
+				reg = <0x50>;
+			};
+		};
+
+		pinctrl: pinctrl at 10000 {
+			pinctrl-0 = <&pmx_dip_switches &pmx_gpio_header>;
+			pinctrl-names = "default";
+
+			pmx_uart0: pmx-uart0 {
+				marvell,pins = "mpp10", "mpp11", "mpp15",
+					"mpp16";
+				marvell,function = "uart0";
+			};
+
+			pmx_uart1: pmx-uart1 {
+				marvell,pins = "mpp13", "mpp14", "mpp8",
+					"mpp9";
+				marvell,function = "uart1";
+			};
+
+			pmx_sysrst: pmx-sysrst {
+				marvell,pins = "mpp6";
+				marvell,function = "sysrst";
+			};
+
+			pmx_dip_switches: pmx-dip-switches {
+				marvell,pins = "mpp44", "mpp45", "mpp46", "mpp47";
+				marvell,function = "gpio";
+			};
+
+			/*
+			 * Accessible on connector J202. The MPP
+			 * listed below are pin 1-7, pin 8 is unused,
+			 * pin 9 is external reset input and pin 10 is
+			 * ground.
+			 */
+			pmx_gpio_header: pmx-gpio-header {
+				marvell,pins = "mpp17", "mpp7", "mpp29", "mpp28",
+					       "mpp35", "mpp34", "mpp40";
+				marvell,function = "gpio";
+			};
+
+			pmx_gpio_init: pmx-init {
+				marvell,pins = "mpp38";
+				marvell,function = "gpio";
+			};
+
+			pmx_usb_oc: pmx-usb-oc {
+				marvell,pins = "mpp39";
+				marvell,function = "gpio";
+			};
+
+			pmx_leds: pmx-leds {
+				marvell,pins = "mpp41", "mpp42", "mpp43";
+				marvell,function = "gpio";
+			};
+
+			pmx_ge1: pmx-ge1 {
+				marvell,pins = "mpp20", "mpp21", "mpp22", "mpp23",
+					       "mpp24", "mpp25", "mpp26", "mpp27",
+					       "mpp30", "mpp31", "mpp32", "mpp33";
+				marvell,function = "ge1";
+			};
+		};
+	};
+
+	gpio-leds {
+		compatible = "gpio-leds";
+		pinctrl-0 = <&pmx_leds>;
+		pinctrl-names = "default";
+
+		led-red {
+			label = "obsa7:red:stat";
+			gpios = <&gpio1 9 1>;
+		};
+
+		led-green {
+			label = "obsa7:green:stat";
+			gpios = <&gpio1 10 1>;
+		};
+
+		led-yellow {
+			label = "obsa7:yellow:stat";
+			gpios = <&gpio1 11 1>;
+		};
+        };
+
+	gpio_keys {
+		compatible = "gpio-keys";
+		pinctrl-0 = <&pmx_gpio_init>;
+		pinctrl-names = "default";
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		button at 1 {
+			label = "Init Button";
+			linux,code = <116>;
+			gpios = <&gpio1 6 0>;
+		};
+	};
+};
+
+&mdio {
+	status = "okay";
+
+	ethphy0: ethernet-phy at 0 {
+		device_type = "ethernet-phy";
+		reg = <0>;
+	};
+
+	ethphy1: ethernet-phy at 1 {
+		device_type = "ethernet-phy";
+		reg = <1>;
+	};
+};
+
+&eth0 {
+	status = "okay";
+	ethernet0-port at 0 {
+		phy-handle = <&ethphy0>;
+	};
+};
+
+&eth1 {
+	status = "okay";
+	pinctrl-0 = <&pmx_ge1>;
+	pinctrl-names = "default";
+	ethernet1-port at 0 {
+		phy-handle = <&ethphy1>;
+	};
+};
-- 
1.8.1.2

[PATCH 1/2] ARM: kirkwood: add support for OpenBlocks A7 platform

[Andrew Lunn]

On Wed, Oct 30, 2013 at 05:55:09PM +0100, Thomas Petazzoni wrote:
> The OpenBlocks A7 board is designed and sold by PlatHome, and based on
> a Kirkwood 6283 Marvell SoC. It is quite similar to the OpenBlocks A6
> already supported in the kernel, with the following main differences:
> 
>  - The A6 uses a RTC on I2C, while the A7 uses the internal SoC RTC.
> 
>  - The A6 has one Ethernet port, while the A7 has two Ethernet ports
> 
>  - The A6 has only one USB port, while the A7 integrates a USB hub,
>    which provides two front-side USB port, and an internal USB port as
>    well.
> 
>  - The A6 has 512 MB of RAM, while the A7 has 1 GB of RAM.
> 
>  - Slightly different GPIOs for some functions.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
>  arch/arm/boot/dts/Makefile                   |   3 +-
>  arch/arm/boot/dts/kirkwood-openblocks_a7.dts | 223 +++++++++++++++++++++++++++
>  2 files changed, 225 insertions(+), 1 deletion(-)
>  create mode 100644 arch/arm/boot/dts/kirkwood-openblocks_a7.dts
> 
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 802720e..64783bb 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -101,7 +101,8 @@ dtb-$(CONFIG_ARCH_KIRKWOOD) += kirkwood-cloudbox.dtb \
>  	kirkwood-topkick.dtb \
>  	kirkwood-ts219-6281.dtb \
>  	kirkwood-ts219-6282.dtb \
> -	kirkwood-openblocks_a6.dtb
> +	kirkwood-openblocks_a6.dtb \
> +	kirkwood-openblocks_a7.dtb

Hi Thomas

Could you fix the ordering here? It is wrong to start with that the a6
is at the end. Could you move it, and add your new one, after nsa31a.

Apart from that, it looks good.

Thanks
	Andrew


>  dtb-$(CONFIG_ARCH_MARCO) += marco-evb.dtb
>  dtb-$(CONFIG_ARCH_MSM) += msm8660-surf.dtb \
>  	msm8960-cdp.dtb
> diff --git a/arch/arm/boot/dts/kirkwood-openblocks_a7.dts b/arch/arm/boot/dts/kirkwood-openblocks_a7.dts
> new file mode 100644
> index 0000000..1864972
> --- /dev/null
> +++ b/arch/arm/boot/dts/kirkwood-openblocks_a7.dts
> @@ -0,0 +1,223 @@
> +/*
> + * Device Tree file for OpenBlocks A7 board
> + *
> + * Copyright (C) 2013 Free Electrons
> + *
> + * Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> + *
> + * This file is licensed under the terms of the GNU General Public
> + * License version 2.  This program is licensed "as is" without any
> + * warranty of any kind, whether express or implied.
> + */
> +
> +/dts-v1/;
> +
> +#include "kirkwood.dtsi"
> +#include "kirkwood-6282.dtsi"
> +
> +/ {
> +	model = "Plat'Home OpenBlocksA7";
> +	compatible = "plathome,openblocks-a7", "marvell,kirkwood-88f6283", "marvell,kirkwood";
> +
> +	memory {
> +		device_type = "memory";
> +		reg = <0x00000000 0x40000000>; /* 1 GB */
> +	};
> +
> +	chosen {
> +		bootargs = "console=ttyS0,115200n8 earlyprintk";
> +	};
> +
> +	ocp at f1000000 {
> +		serial at 12000 {
> +			status = "ok";
> +			pinctrl-0 = <&pmx_uart0>;
> +			pinctrl-names = "default";
> +		};
> +
> +		serial at 12100 {
> +			status = "ok";
> +			pinctrl-0 = <&pmx_uart1>;
> +			pinctrl-names = "default";
> +		};
> +
> +		nand at 3000000 {
> +			chip-delay = <25>;
> +			status = "okay";
> +			pinctrl-0 = <&pmx_nand>;
> +			pinctrl-names = "default";
> +
> +			partition at 0 {
> +				label = "uboot";
> +				reg = <0x0 0x1c0000>;
> +			};
> +
> +			partition at 90000 {
> +				label = "env";
> +				reg = <0x1c0000 0x2c0000>;
> +			};
> +
> +			partition at d4000 {
> +				label = "test";
> +				reg = <0x480000 0x160000>;
> +			};
> +
> +			partition at f4000 {
> +				label = "conf";
> +				reg = <0x5e0000 0x540000>;
> +			};
> +
> +			partition at 4f4000 {
> +				label = "linux";
> +				reg = <0xb20000 0x3d40000>;
> +			};
> +
> +			partition at 2214000 {
> +				label = "user";
> +				reg = <0x4860000 0xb7a0000>;
> +			};
> +		};
> +
> +		sata at 80000 {
> +			nr-ports = <1>;
> +			status = "okay";
> +		};
> +
> +		i2c at 11100 {
> +			status = "okay";
> +			pinctrl-0 = <&pmx_twsi1>;
> +			pinctrl-names = "default";
> +
> +			s24c02: s24c02 at 50 {
> +				compatible = "24c02";
> +				reg = <0x50>;
> +			};
> +		};
> +
> +		pinctrl: pinctrl at 10000 {
> +			pinctrl-0 = <&pmx_dip_switches &pmx_gpio_header>;
> +			pinctrl-names = "default";
> +
> +			pmx_uart0: pmx-uart0 {
> +				marvell,pins = "mpp10", "mpp11", "mpp15",
> +					"mpp16";
> +				marvell,function = "uart0";
> +			};
> +
> +			pmx_uart1: pmx-uart1 {
> +				marvell,pins = "mpp13", "mpp14", "mpp8",
> +					"mpp9";
> +				marvell,function = "uart1";
> +			};
> +
> +			pmx_sysrst: pmx-sysrst {
> +				marvell,pins = "mpp6";
> +				marvell,function = "sysrst";
> +			};
> +
> +			pmx_dip_switches: pmx-dip-switches {
> +				marvell,pins = "mpp44", "mpp45", "mpp46", "mpp47";
> +				marvell,function = "gpio";
> +			};
> +
> +			/*
> +			 * Accessible on connector J202. The MPP
> +			 * listed below are pin 1-7, pin 8 is unused,
> +			 * pin 9 is external reset input and pin 10 is
> +			 * ground.
> +			 */
> +			pmx_gpio_header: pmx-gpio-header {
> +				marvell,pins = "mpp17", "mpp7", "mpp29", "mpp28",
> +					       "mpp35", "mpp34", "mpp40";
> +				marvell,function = "gpio";
> +			};
> +
> +			pmx_gpio_init: pmx-init {
> +				marvell,pins = "mpp38";
> +				marvell,function = "gpio";
> +			};
> +
> +			pmx_usb_oc: pmx-usb-oc {
> +				marvell,pins = "mpp39";
> +				marvell,function = "gpio";
> +			};
> +
> +			pmx_leds: pmx-leds {
> +				marvell,pins = "mpp41", "mpp42", "mpp43";
> +				marvell,function = "gpio";
> +			};
> +
> +			pmx_ge1: pmx-ge1 {
> +				marvell,pins = "mpp20", "mpp21", "mpp22", "mpp23",
> +					       "mpp24", "mpp25", "mpp26", "mpp27",
> +					       "mpp30", "mpp31", "mpp32", "mpp33";
> +				marvell,function = "ge1";
> +			};
> +		};
> +	};
> +
> +	gpio-leds {
> +		compatible = "gpio-leds";
> +		pinctrl-0 = <&pmx_leds>;
> +		pinctrl-names = "default";
> +
> +		led-red {
> +			label = "obsa7:red:stat";
> +			gpios = <&gpio1 9 1>;
> +		};
> +
> +		led-green {
> +			label = "obsa7:green:stat";
> +			gpios = <&gpio1 10 1>;
> +		};
> +
> +		led-yellow {
> +			label = "obsa7:yellow:stat";
> +			gpios = <&gpio1 11 1>;
> +		};
> +        };
> +
> +	gpio_keys {
> +		compatible = "gpio-keys";
> +		pinctrl-0 = <&pmx_gpio_init>;
> +		pinctrl-names = "default";
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		button at 1 {
> +			label = "Init Button";
> +			linux,code = <116>;
> +			gpios = <&gpio1 6 0>;
> +		};
> +	};
> +};
> +
> +&mdio {
> +	status = "okay";
> +
> +	ethphy0: ethernet-phy at 0 {
> +		device_type = "ethernet-phy";
> +		reg = <0>;
> +	};
> +
> +	ethphy1: ethernet-phy at 1 {
> +		device_type = "ethernet-phy";
> +		reg = <1>;
> +	};
> +};
> +
> +&eth0 {
> +	status = "okay";
> +	ethernet0-port at 0 {
> +		phy-handle = <&ethphy0>;
> +	};
> +};
> +
> +&eth1 {
> +	status = "okay";
> +	pinctrl-0 = <&pmx_ge1>;
> +	pinctrl-names = "default";
> +	ethernet1-port at 0 {
> +		phy-handle = <&ethphy1>;
> +	};
> +};
> -- 
> 1.8.1.2
> 

[PATCH 1/2] ARM: kirkwood: add support for OpenBlocks A7 platform

[Gregory CLEMENT]

On 30/10/2013 17:55, Thomas Petazzoni wrote:
> The OpenBlocks A7 board is designed and sold by PlatHome, and based on
> a Kirkwood 6283 Marvell SoC. It is quite similar to the OpenBlocks A6
> already supported in the kernel, with the following main differences:
> 
>  - The A6 uses a RTC on I2C, while the A7 uses the internal SoC RTC.
> 
>  - The A6 has one Ethernet port, while the A7 has two Ethernet ports
> 
>  - The A6 has only one USB port, while the A7 integrates a USB hub,
>    which provides two front-side USB port, and an internal USB port as
>    well.
> 
>  - The A6 has 512 MB of RAM, while the A7 has 1 GB of RAM.
> 
>  - Slightly different GPIOs for some functions.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>

> ---
>  arch/arm/boot/dts/Makefile                   |   3 +-
>  arch/arm/boot/dts/kirkwood-openblocks_a7.dts | 223 +++++++++++++++++++++++++++
>  2 files changed, 225 insertions(+), 1 deletion(-)
>  create mode 100644 arch/arm/boot/dts/kirkwood-openblocks_a7.dts
> 
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 802720e..64783bb 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -101,7 +101,8 @@ dtb-$(CONFIG_ARCH_KIRKWOOD) += kirkwood-cloudbox.dtb \
>  	kirkwood-topkick.dtb \
>  	kirkwood-ts219-6281.dtb \
>  	kirkwood-ts219-6282.dtb \
> -	kirkwood-openblocks_a6.dtb
> +	kirkwood-openblocks_a6.dtb \
> +	kirkwood-openblocks_a7.dtb
>  dtb-$(CONFIG_ARCH_MARCO) += marco-evb.dtb
>  dtb-$(CONFIG_ARCH_MSM) += msm8660-surf.dtb \
>  	msm8960-cdp.dtb
> diff --git a/arch/arm/boot/dts/kirkwood-openblocks_a7.dts b/arch/arm/boot/dts/kirkwood-openblocks_a7.dts
> new file mode 100644
> index 0000000..1864972
> --- /dev/null
> +++ b/arch/arm/boot/dts/kirkwood-openblocks_a7.dts
> @@ -0,0 +1,223 @@
> +/*
> + * Device Tree file for OpenBlocks A7 board
> + *
> + * Copyright (C) 2013 Free Electrons
> + *
> + * Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> + *
> + * This file is licensed under the terms of the GNU General Public
> + * License version 2.  This program is licensed "as is" without any
> + * warranty of any kind, whether express or implied.
> + */
> +
> +/dts-v1/;
> +
> +#include "kirkwood.dtsi"
> +#include "kirkwood-6282.dtsi"
> +
> +/ {
> +	model = "Plat'Home OpenBlocksA7";
> +	compatible = "plathome,openblocks-a7", "marvell,kirkwood-88f6283", "marvell,kirkwood";
> +
> +	memory {
> +		device_type = "memory";
> +		reg = <0x00000000 0x40000000>; /* 1 GB */
> +	};
> +
> +	chosen {
> +		bootargs = "console=ttyS0,115200n8 earlyprintk";
> +	};
> +
> +	ocp at f1000000 {
> +		serial at 12000 {
> +			status = "ok";
> +			pinctrl-0 = <&pmx_uart0>;
> +			pinctrl-names = "default";
> +		};
> +
> +		serial at 12100 {
> +			status = "ok";
> +			pinctrl-0 = <&pmx_uart1>;
> +			pinctrl-names = "default";
> +		};
> +
> +		nand at 3000000 {
> +			chip-delay = <25>;
> +			status = "okay";
> +			pinctrl-0 = <&pmx_nand>;
> +			pinctrl-names = "default";
> +
> +			partition at 0 {
> +				label = "uboot";
> +				reg = <0x0 0x1c0000>;
> +			};
> +
> +			partition at 90000 {
> +				label = "env";
> +				reg = <0x1c0000 0x2c0000>;
> +			};
> +
> +			partition at d4000 {
> +				label = "test";
> +				reg = <0x480000 0x160000>;
> +			};
> +
> +			partition at f4000 {
> +				label = "conf";
> +				reg = <0x5e0000 0x540000>;
> +			};
> +
> +			partition at 4f4000 {
> +				label = "linux";
> +				reg = <0xb20000 0x3d40000>;
> +			};
> +
> +			partition at 2214000 {
> +				label = "user";
> +				reg = <0x4860000 0xb7a0000>;
> +			};
> +		};
> +
> +		sata at 80000 {
> +			nr-ports = <1>;
> +			status = "okay";
> +		};
> +
> +		i2c at 11100 {
> +			status = "okay";
> +			pinctrl-0 = <&pmx_twsi1>;
> +			pinctrl-names = "default";
> +
> +			s24c02: s24c02 at 50 {
> +				compatible = "24c02";
> +				reg = <0x50>;
> +			};
> +		};
> +
> +		pinctrl: pinctrl at 10000 {
> +			pinctrl-0 = <&pmx_dip_switches &pmx_gpio_header>;
> +			pinctrl-names = "default";
> +
> +			pmx_uart0: pmx-uart0 {
> +				marvell,pins = "mpp10", "mpp11", "mpp15",
> +					"mpp16";
> +				marvell,function = "uart0";
> +			};
> +
> +			pmx_uart1: pmx-uart1 {
> +				marvell,pins = "mpp13", "mpp14", "mpp8",
> +					"mpp9";
> +				marvell,function = "uart1";
> +			};
> +
> +			pmx_sysrst: pmx-sysrst {
> +				marvell,pins = "mpp6";
> +				marvell,function = "sysrst";
> +			};
> +
> +			pmx_dip_switches: pmx-dip-switches {
> +				marvell,pins = "mpp44", "mpp45", "mpp46", "mpp47";
> +				marvell,function = "gpio";
> +			};
> +
> +			/*
> +			 * Accessible on connector J202. The MPP
> +			 * listed below are pin 1-7, pin 8 is unused,
> +			 * pin 9 is external reset input and pin 10 is
> +			 * ground.
> +			 */
> +			pmx_gpio_header: pmx-gpio-header {
> +				marvell,pins = "mpp17", "mpp7", "mpp29", "mpp28",
> +					       "mpp35", "mpp34", "mpp40";
> +				marvell,function = "gpio";
> +			};
> +
> +			pmx_gpio_init: pmx-init {
> +				marvell,pins = "mpp38";
> +				marvell,function = "gpio";
> +			};
> +
> +			pmx_usb_oc: pmx-usb-oc {
> +				marvell,pins = "mpp39";
> +				marvell,function = "gpio";
> +			};
> +
> +			pmx_leds: pmx-leds {
> +				marvell,pins = "mpp41", "mpp42", "mpp43";
> +				marvell,function = "gpio";
> +			};
> +
> +			pmx_ge1: pmx-ge1 {
> +				marvell,pins = "mpp20", "mpp21", "mpp22", "mpp23",
> +					       "mpp24", "mpp25", "mpp26", "mpp27",
> +					       "mpp30", "mpp31", "mpp32", "mpp33";
> +				marvell,function = "ge1";
> +			};
> +		};
> +	};
> +
> +	gpio-leds {
> +		compatible = "gpio-leds";
> +		pinctrl-0 = <&pmx_leds>;
> +		pinctrl-names = "default";
> +
> +		led-red {
> +			label = "obsa7:red:stat";
> +			gpios = <&gpio1 9 1>;
> +		};
> +
> +		led-green {
> +			label = "obsa7:green:stat";
> +			gpios = <&gpio1 10 1>;
> +		};
> +
> +		led-yellow {
> +			label = "obsa7:yellow:stat";
> +			gpios = <&gpio1 11 1>;
> +		};
> +        };
> +
> +	gpio_keys {
> +		compatible = "gpio-keys";
> +		pinctrl-0 = <&pmx_gpio_init>;
> +		pinctrl-names = "default";
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		button at 1 {
> +			label = "Init Button";
> +			linux,code = <116>;
> +			gpios = <&gpio1 6 0>;
> +		};
> +	};
> +};
> +
> +&mdio {
> +	status = "okay";
> +
> +	ethphy0: ethernet-phy at 0 {
> +		device_type = "ethernet-phy";
> +		reg = <0>;
> +	};
> +
> +	ethphy1: ethernet-phy at 1 {
> +		device_type = "ethernet-phy";
> +		reg = <1>;
> +	};
> +};
> +
> +&eth0 {
> +	status = "okay";
> +	ethernet0-port at 0 {
> +		phy-handle = <&ethphy0>;
> +	};
> +};
> +
> +&eth1 {
> +	status = "okay";
> +	pinctrl-0 = <&pmx_ge1>;
> +	pinctrl-names = "default";
> +	ethernet1-port at 0 {
> +		phy-handle = <&ethphy1>;
> +	};
> +};
> 


-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

acked

[Jason Cooper]

Gregory,

I like the idea, and if you perhaps do '[PATCH X/Y] Acked' it should
make it through the filters.  (they currently whitelist 'GIT PULL' and
'PATCH' subjects).

Sure would make things easier when going through the threads...

thx,

Jason.

On Wed, Oct 30, 2013 at 06:00:00PM +0100, Gregory CLEMENT wrote:
> On 30/10/2013 17:55, Thomas Petazzoni wrote:
> > The OpenBlocks A7 board is designed and sold by PlatHome, and based on
> > a Kirkwood 6283 Marvell SoC. It is quite similar to the OpenBlocks A6
> > already supported in the kernel, with the following main differences:
> > 
> >  - The A6 uses a RTC on I2C, while the A7 uses the internal SoC RTC.
> > 
> >  - The A6 has one Ethernet port, while the A7 has two Ethernet ports
> > 
> >  - The A6 has only one USB port, while the A7 integrates a USB hub,
> >    which provides two front-side USB port, and an internal USB port as
> >    well.
> > 
> >  - The A6 has 512 MB of RAM, while the A7 has 1 GB of RAM.
> > 
> >  - Slightly different GPIOs for some functions.
> > 
> > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> 
> 
> Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
> 
> 
> > ---
> >  arch/arm/boot/dts/Makefile                   |   3 +-
> >  arch/arm/boot/dts/kirkwood-openblocks_a7.dts | 223 +++++++++++++++++++++++++++
> >  2 files changed, 225 insertions(+), 1 deletion(-)
> >  create mode 100644 arch/arm/boot/dts/kirkwood-openblocks_a7.dts
> > 
> > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> > index 802720e..64783bb 100644
> > --- a/arch/arm/boot/dts/Makefile
> > +++ b/arch/arm/boot/dts/Makefile
> > @@ -101,7 +101,8 @@ dtb-$(CONFIG_ARCH_KIRKWOOD) += kirkwood-cloudbox.dtb \
> >  	kirkwood-topkick.dtb \
> >  	kirkwood-ts219-6281.dtb \
> >  	kirkwood-ts219-6282.dtb \
> > -	kirkwood-openblocks_a6.dtb
> > +	kirkwood-openblocks_a6.dtb \
> > +	kirkwood-openblocks_a7.dtb
> >  dtb-$(CONFIG_ARCH_MARCO) += marco-evb.dtb
> >  dtb-$(CONFIG_ARCH_MSM) += msm8660-surf.dtb \
> >  	msm8960-cdp.dtb
> > diff --git a/arch/arm/boot/dts/kirkwood-openblocks_a7.dts b/arch/arm/boot/dts/kirkwood-openblocks_a7.dts
> > new file mode 100644
> > index 0000000..1864972
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/kirkwood-openblocks_a7.dts
> > @@ -0,0 +1,223 @@
> > +/*
> > + * Device Tree file for OpenBlocks A7 board
> > + *
> > + * Copyright (C) 2013 Free Electrons
> > + *
> > + * Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> > + *
> > + * This file is licensed under the terms of the GNU General Public
> > + * License version 2.  This program is licensed "as is" without any
> > + * warranty of any kind, whether express or implied.
> > + */
> > +
> > +/dts-v1/;
> > +
> > +#include "kirkwood.dtsi"
> > +#include "kirkwood-6282.dtsi"
> > +
> > +/ {
> > +	model = "Plat'Home OpenBlocksA7";
> > +	compatible = "plathome,openblocks-a7", "marvell,kirkwood-88f6283", "marvell,kirkwood";
> > +
> > +	memory {
> > +		device_type = "memory";
> > +		reg = <0x00000000 0x40000000>; /* 1 GB */
> > +	};
> > +
> > +	chosen {
> > +		bootargs = "console=ttyS0,115200n8 earlyprintk";
> > +	};
> > +
> > +	ocp at f1000000 {
> > +		serial at 12000 {
> > +			status = "ok";
> > +			pinctrl-0 = <&pmx_uart0>;
> > +			pinctrl-names = "default";
> > +		};
> > +
> > +		serial at 12100 {
> > +			status = "ok";
> > +			pinctrl-0 = <&pmx_uart1>;
> > +			pinctrl-names = "default";
> > +		};
> > +
> > +		nand at 3000000 {
> > +			chip-delay = <25>;
> > +			status = "okay";
> > +			pinctrl-0 = <&pmx_nand>;
> > +			pinctrl-names = "default";
> > +
> > +			partition at 0 {
> > +				label = "uboot";
> > +				reg = <0x0 0x1c0000>;
> > +			};
> > +
> > +			partition at 90000 {
> > +				label = "env";
> > +				reg = <0x1c0000 0x2c0000>;
> > +			};
> > +
> > +			partition at d4000 {
> > +				label = "test";
> > +				reg = <0x480000 0x160000>;
> > +			};
> > +
> > +			partition at f4000 {
> > +				label = "conf";
> > +				reg = <0x5e0000 0x540000>;
> > +			};
> > +
> > +			partition at 4f4000 {
> > +				label = "linux";
> > +				reg = <0xb20000 0x3d40000>;
> > +			};
> > +
> > +			partition at 2214000 {
> > +				label = "user";
> > +				reg = <0x4860000 0xb7a0000>;
> > +			};
> > +		};
> > +
> > +		sata at 80000 {
> > +			nr-ports = <1>;
> > +			status = "okay";
> > +		};
> > +
> > +		i2c at 11100 {
> > +			status = "okay";
> > +			pinctrl-0 = <&pmx_twsi1>;
> > +			pinctrl-names = "default";
> > +
> > +			s24c02: s24c02 at 50 {
> > +				compatible = "24c02";
> > +				reg = <0x50>;
> > +			};
> > +		};
> > +
> > +		pinctrl: pinctrl at 10000 {
> > +			pinctrl-0 = <&pmx_dip_switches &pmx_gpio_header>;
> > +			pinctrl-names = "default";
> > +
> > +			pmx_uart0: pmx-uart0 {
> > +				marvell,pins = "mpp10", "mpp11", "mpp15",
> > +					"mpp16";
> > +				marvell,function = "uart0";
> > +			};
> > +
> > +			pmx_uart1: pmx-uart1 {
> > +				marvell,pins = "mpp13", "mpp14", "mpp8",
> > +					"mpp9";
> > +				marvell,function = "uart1";
> > +			};
> > +
> > +			pmx_sysrst: pmx-sysrst {
> > +				marvell,pins = "mpp6";
> > +				marvell,function = "sysrst";
> > +			};
> > +
> > +			pmx_dip_switches: pmx-dip-switches {
> > +				marvell,pins = "mpp44", "mpp45", "mpp46", "mpp47";
> > +				marvell,function = "gpio";
> > +			};
> > +
> > +			/*
> > +			 * Accessible on connector J202. The MPP
> > +			 * listed below are pin 1-7, pin 8 is unused,
> > +			 * pin 9 is external reset input and pin 10 is
> > +			 * ground.
> > +			 */
> > +			pmx_gpio_header: pmx-gpio-header {
> > +				marvell,pins = "mpp17", "mpp7", "mpp29", "mpp28",
> > +					       "mpp35", "mpp34", "mpp40";
> > +				marvell,function = "gpio";
> > +			};
> > +
> > +			pmx_gpio_init: pmx-init {
> > +				marvell,pins = "mpp38";
> > +				marvell,function = "gpio";
> > +			};
> > +
> > +			pmx_usb_oc: pmx-usb-oc {
> > +				marvell,pins = "mpp39";
> > +				marvell,function = "gpio";
> > +			};
> > +
> > +			pmx_leds: pmx-leds {
> > +				marvell,pins = "mpp41", "mpp42", "mpp43";
> > +				marvell,function = "gpio";
> > +			};
> > +
> > +			pmx_ge1: pmx-ge1 {
> > +				marvell,pins = "mpp20", "mpp21", "mpp22", "mpp23",
> > +					       "mpp24", "mpp25", "mpp26", "mpp27",
> > +					       "mpp30", "mpp31", "mpp32", "mpp33";
> > +				marvell,function = "ge1";
> > +			};
> > +		};
> > +	};
> > +
> > +	gpio-leds {
> > +		compatible = "gpio-leds";
> > +		pinctrl-0 = <&pmx_leds>;
> > +		pinctrl-names = "default";
> > +
> > +		led-red {
> > +			label = "obsa7:red:stat";
> > +			gpios = <&gpio1 9 1>;
> > +		};
> > +
> > +		led-green {
> > +			label = "obsa7:green:stat";
> > +			gpios = <&gpio1 10 1>;
> > +		};
> > +
> > +		led-yellow {
> > +			label = "obsa7:yellow:stat";
> > +			gpios = <&gpio1 11 1>;
> > +		};
> > +        };
> > +
> > +	gpio_keys {
> > +		compatible = "gpio-keys";
> > +		pinctrl-0 = <&pmx_gpio_init>;
> > +		pinctrl-names = "default";
> > +		#address-cells = <1>;
> > +		#size-cells = <0>;
> > +
> > +		button at 1 {
> > +			label = "Init Button";
> > +			linux,code = <116>;
> > +			gpios = <&gpio1 6 0>;
> > +		};
> > +	};
> > +};
> > +
> > +&mdio {
> > +	status = "okay";
> > +
> > +	ethphy0: ethernet-phy at 0 {
> > +		device_type = "ethernet-phy";
> > +		reg = <0>;
> > +	};
> > +
> > +	ethphy1: ethernet-phy at 1 {
> > +		device_type = "ethernet-phy";
> > +		reg = <1>;
> > +	};
> > +};
> > +
> > +&eth0 {
> > +	status = "okay";
> > +	ethernet0-port at 0 {
> > +		phy-handle = <&ethphy0>;
> > +	};
> > +};
> > +
> > +&eth1 {
> > +	status = "okay";
> > +	pinctrl-0 = <&pmx_ge1>;
> > +	pinctrl-names = "default";
> > +	ethernet1-port at 0 {
> > +		phy-handle = <&ethphy1>;
> > +	};
> > +};
> > 
> 
> 
> -- 
> Gregory Clement, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com

acked

[Russell King - ARM Linux]

On Wed, Oct 30, 2013 at 01:15:44PM -0400, Jason Cooper wrote:
> Gregory,
> 
> I like the idea, and if you perhaps do '[PATCH X/Y] Acked' it should
> make it through the filters.  (they currently whitelist 'GIT PULL' and
> 'PATCH' subjects).
> 
> Sure would make things easier when going through the threads...

NAK. :)

The reason being that some mailing list archivers will break threads
with a subject line change, which will detach the "acked" from the
original messages.

If a patch made it though with "[PATCH" in the subject line, then a
reply (though *correctly* trimmed down as per Internet Etiquette
which is something people - including yourself as evidenced by the
message to which I'm replying - regularly don't do) will get through
without any issues.

acked

[Jason Cooper]

On Wed, Oct 30, 2013 at 05:20:07PM +0000, Russell King - ARM Linux wrote:
> On Wed, Oct 30, 2013 at 01:15:44PM -0400, Jason Cooper wrote:
> > Gregory,
> > 
> > I like the idea, and if you perhaps do '[PATCH X/Y] Acked' it should
> > make it through the filters.  (they currently whitelist 'GIT PULL' and
> > 'PATCH' subjects).
> > 
> > Sure would make things easier when going through the threads...
> 
> NAK. :)
> 
> The reason being that some mailing list archivers will break threads
> with a subject line change, which will detach the "acked" from the
> original messages.

Ahhh, you're right.  I completely forgot about the archives.  Shame on
me.

Oh well, back to writing better scripts...

thx,

Jason.

acked

[Gregory CLEMENT]

Hi Jason,

On 30/10/2013 18:15, Jason Cooper wrote:
> Gregory,
> 
> I like the idea, and if you perhaps do '[PATCH X/Y] Acked' it should
> make it through the filters.  (they currently whitelist 'GIT PULL' and
> 'PATCH' subjects).
> 

Well actually it was a mistake! I ended to use a plugin to automatically
writing some pattern instead of writing it myself each time, but I
mis-configured it!

I am not sure that everybody like the idea to hijack the subject of a thread,
but if there a agreement on it, now I know hot to do it! ;)

Gregory

> Sure would make things easier when going through the threads...
> 
> thx,
> 
> Jason.
> 
> On Wed, Oct 30, 2013 at 06:00:00PM +0100, Gregory CLEMENT wrote:
>> On 30/10/2013 17:55, Thomas Petazzoni wrote:
>>> The OpenBlocks A7 board is designed and sold by PlatHome, and based on
>>> a Kirkwood 6283 Marvell SoC. It is quite similar to the OpenBlocks A6
>>> already supported in the kernel, with the following main differences:
>>>
>>>  - The A6 uses a RTC on I2C, while the A7 uses the internal SoC RTC.
>>>
>>>  - The A6 has one Ethernet port, while the A7 has two Ethernet ports
>>>
>>>  - The A6 has only one USB port, while the A7 integrates a USB hub,
>>>    which provides two front-side USB port, and an internal USB port as
>>>    well.
>>>
>>>  - The A6 has 512 MB of RAM, while the A7 has 1 GB of RAM.
>>>
>>>  - Slightly different GPIOs for some functions.
>>>
>>> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>>
>>
>> Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
>>
>>
>>> ---
>>>  arch/arm/boot/dts/Makefile                   |   3 +-
>>>  arch/arm/boot/dts/kirkwood-openblocks_a7.dts | 223 +++++++++++++++++++++++++++
>>>  2 files changed, 225 insertions(+), 1 deletion(-)
>>>  create mode 100644 arch/arm/boot/dts/kirkwood-openblocks_a7.dts
>>>
>>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>>> index 802720e..64783bb 100644
>>> --- a/arch/arm/boot/dts/Makefile
>>> +++ b/arch/arm/boot/dts/Makefile
>>> @@ -101,7 +101,8 @@ dtb-$(CONFIG_ARCH_KIRKWOOD) += kirkwood-cloudbox.dtb \
>>>  	kirkwood-topkick.dtb \
>>>  	kirkwood-ts219-6281.dtb \
>>>  	kirkwood-ts219-6282.dtb \
>>> -	kirkwood-openblocks_a6.dtb
>>> +	kirkwood-openblocks_a6.dtb \
>>> +	kirkwood-openblocks_a7.dtb
>>>  dtb-$(CONFIG_ARCH_MARCO) += marco-evb.dtb
>>>  dtb-$(CONFIG_ARCH_MSM) += msm8660-surf.dtb \
>>>  	msm8960-cdp.dtb
>>> diff --git a/arch/arm/boot/dts/kirkwood-openblocks_a7.dts b/arch/arm/boot/dts/kirkwood-openblocks_a7.dts
>>> new file mode 100644
>>> index 0000000..1864972
>>> --- /dev/null
>>> +++ b/arch/arm/boot/dts/kirkwood-openblocks_a7.dts
>>> @@ -0,0 +1,223 @@
>>> +/*
>>> + * Device Tree file for OpenBlocks A7 board
>>> + *
>>> + * Copyright (C) 2013 Free Electrons
>>> + *
>>> + * Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>>> + *
>>> + * This file is licensed under the terms of the GNU General Public
>>> + * License version 2.  This program is licensed "as is" without any
>>> + * warranty of any kind, whether express or implied.
>>> + */
>>> +
>>> +/dts-v1/;
>>> +
>>> +#include "kirkwood.dtsi"
>>> +#include "kirkwood-6282.dtsi"
>>> +
>>> +/ {
>>> +	model = "Plat'Home OpenBlocksA7";
>>> +	compatible = "plathome,openblocks-a7", "marvell,kirkwood-88f6283", "marvell,kirkwood";
>>> +
>>> +	memory {
>>> +		device_type = "memory";
>>> +		reg = <0x00000000 0x40000000>; /* 1 GB */
>>> +	};
>>> +
>>> +	chosen {
>>> +		bootargs = "console=ttyS0,115200n8 earlyprintk";
>>> +	};
>>> +
>>> +	ocp at f1000000 {
>>> +		serial at 12000 {
>>> +			status = "ok";
>>> +			pinctrl-0 = <&pmx_uart0>;
>>> +			pinctrl-names = "default";
>>> +		};
>>> +
>>> +		serial at 12100 {
>>> +			status = "ok";
>>> +			pinctrl-0 = <&pmx_uart1>;
>>> +			pinctrl-names = "default";
>>> +		};
>>> +
>>> +		nand at 3000000 {
>>> +			chip-delay = <25>;
>>> +			status = "okay";
>>> +			pinctrl-0 = <&pmx_nand>;
>>> +			pinctrl-names = "default";
>>> +
>>> +			partition at 0 {
>>> +				label = "uboot";
>>> +				reg = <0x0 0x1c0000>;
>>> +			};
>>> +
>>> +			partition at 90000 {
>>> +				label = "env";
>>> +				reg = <0x1c0000 0x2c0000>;
>>> +			};
>>> +
>>> +			partition at d4000 {
>>> +				label = "test";
>>> +				reg = <0x480000 0x160000>;
>>> +			};
>>> +
>>> +			partition at f4000 {
>>> +				label = "conf";
>>> +				reg = <0x5e0000 0x540000>;
>>> +			};
>>> +
>>> +			partition at 4f4000 {
>>> +				label = "linux";
>>> +				reg = <0xb20000 0x3d40000>;
>>> +			};
>>> +
>>> +			partition at 2214000 {
>>> +				label = "user";
>>> +				reg = <0x4860000 0xb7a0000>;
>>> +			};
>>> +		};
>>> +
>>> +		sata at 80000 {
>>> +			nr-ports = <1>;
>>> +			status = "okay";
>>> +		};
>>> +
>>> +		i2c at 11100 {
>>> +			status = "okay";
>>> +			pinctrl-0 = <&pmx_twsi1>;
>>> +			pinctrl-names = "default";
>>> +
>>> +			s24c02: s24c02 at 50 {
>>> +				compatible = "24c02";
>>> +				reg = <0x50>;
>>> +			};
>>> +		};
>>> +
>>> +		pinctrl: pinctrl at 10000 {
>>> +			pinctrl-0 = <&pmx_dip_switches &pmx_gpio_header>;
>>> +			pinctrl-names = "default";
>>> +
>>> +			pmx_uart0: pmx-uart0 {
>>> +				marvell,pins = "mpp10", "mpp11", "mpp15",
>>> +					"mpp16";
>>> +				marvell,function = "uart0";
>>> +			};
>>> +
>>> +			pmx_uart1: pmx-uart1 {
>>> +				marvell,pins = "mpp13", "mpp14", "mpp8",
>>> +					"mpp9";
>>> +				marvell,function = "uart1";
>>> +			};
>>> +
>>> +			pmx_sysrst: pmx-sysrst {
>>> +				marvell,pins = "mpp6";
>>> +				marvell,function = "sysrst";
>>> +			};
>>> +
>>> +			pmx_dip_switches: pmx-dip-switches {
>>> +				marvell,pins = "mpp44", "mpp45", "mpp46", "mpp47";
>>> +				marvell,function = "gpio";
>>> +			};
>>> +
>>> +			/*
>>> +			 * Accessible on connector J202. The MPP
>>> +			 * listed below are pin 1-7, pin 8 is unused,
>>> +			 * pin 9 is external reset input and pin 10 is
>>> +			 * ground.
>>> +			 */
>>> +			pmx_gpio_header: pmx-gpio-header {
>>> +				marvell,pins = "mpp17", "mpp7", "mpp29", "mpp28",
>>> +					       "mpp35", "mpp34", "mpp40";
>>> +				marvell,function = "gpio";
>>> +			};
>>> +
>>> +			pmx_gpio_init: pmx-init {
>>> +				marvell,pins = "mpp38";
>>> +				marvell,function = "gpio";
>>> +			};
>>> +
>>> +			pmx_usb_oc: pmx-usb-oc {
>>> +				marvell,pins = "mpp39";
>>> +				marvell,function = "gpio";
>>> +			};
>>> +
>>> +			pmx_leds: pmx-leds {
>>> +				marvell,pins = "mpp41", "mpp42", "mpp43";
>>> +				marvell,function = "gpio";
>>> +			};
>>> +
>>> +			pmx_ge1: pmx-ge1 {
>>> +				marvell,pins = "mpp20", "mpp21", "mpp22", "mpp23",
>>> +					       "mpp24", "mpp25", "mpp26", "mpp27",
>>> +					       "mpp30", "mpp31", "mpp32", "mpp33";
>>> +				marvell,function = "ge1";
>>> +			};
>>> +		};
>>> +	};
>>> +
>>> +	gpio-leds {
>>> +		compatible = "gpio-leds";
>>> +		pinctrl-0 = <&pmx_leds>;
>>> +		pinctrl-names = "default";
>>> +
>>> +		led-red {
>>> +			label = "obsa7:red:stat";
>>> +			gpios = <&gpio1 9 1>;
>>> +		};
>>> +
>>> +		led-green {
>>> +			label = "obsa7:green:stat";
>>> +			gpios = <&gpio1 10 1>;
>>> +		};
>>> +
>>> +		led-yellow {
>>> +			label = "obsa7:yellow:stat";
>>> +			gpios = <&gpio1 11 1>;
>>> +		};
>>> +        };
>>> +
>>> +	gpio_keys {
>>> +		compatible = "gpio-keys";
>>> +		pinctrl-0 = <&pmx_gpio_init>;
>>> +		pinctrl-names = "default";
>>> +		#address-cells = <1>;
>>> +		#size-cells = <0>;
>>> +
>>> +		button at 1 {
>>> +			label = "Init Button";
>>> +			linux,code = <116>;
>>> +			gpios = <&gpio1 6 0>;
>>> +		};
>>> +	};
>>> +};
>>> +
>>> +&mdio {
>>> +	status = "okay";
>>> +
>>> +	ethphy0: ethernet-phy at 0 {
>>> +		device_type = "ethernet-phy";
>>> +		reg = <0>;
>>> +	};
>>> +
>>> +	ethphy1: ethernet-phy at 1 {
>>> +		device_type = "ethernet-phy";
>>> +		reg = <1>;
>>> +	};
>>> +};
>>> +
>>> +&eth0 {
>>> +	status = "okay";
>>> +	ethernet0-port at 0 {
>>> +		phy-handle = <&ethphy0>;
>>> +	};
>>> +};
>>> +
>>> +&eth1 {
>>> +	status = "okay";
>>> +	pinctrl-0 = <&pmx_ge1>;
>>> +	pinctrl-names = "default";
>>> +	ethernet1-port at 0 {
>>> +		phy-handle = <&ethphy1>;
>>> +	};
>>> +};
>>>
>>
>>
>> -- 
>> Gregory Clement, Free Electrons
>> Kernel, drivers, real-time and embedded Linux
>> development, consulting, training and support.
>> http://free-electrons.com


-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

acked

[Jason Cooper]

On Wed, Oct 30, 2013 at 06:22:08PM +0100, Gregory CLEMENT wrote:
> Hi Jason,
> 
> On 30/10/2013 18:15, Jason Cooper wrote:
> > Gregory,
> > 
> > I like the idea, and if you perhaps do '[PATCH X/Y] Acked' it should
> > make it through the filters.  (they currently whitelist 'GIT PULL' and
> > 'PATCH' subjects).
> > 
> 
> Well actually it was a mistake! I ended to use a plugin to automatically
> writing some pattern instead of writing it myself each time, but I
> mis-configured it!

yeah, saw that on irc after I hit send.

> I am not sure that everybody like the idea to hijack the subject of a thread,
> but if there a agreement on it, now I know hot to do it! ;)

No, rmk has a very valid point.  It would break most ml archiving.  We
don't want to do that.

thx,

Jason.

[PATCH 1/2] ARM: kirkwood: add support for OpenBlocks A7 platform

[Jason Cooper]

On Wed, Oct 30, 2013 at 05:55:09PM +0100, Thomas Petazzoni wrote:
> The OpenBlocks A7 board is designed and sold by PlatHome, and based on
> a Kirkwood 6283 Marvell SoC. It is quite similar to the OpenBlocks A6
> already supported in the kernel, with the following main differences:
> 
>  - The A6 uses a RTC on I2C, while the A7 uses the internal SoC RTC.
> 
>  - The A6 has one Ethernet port, while the A7 has two Ethernet ports
> 
>  - The A6 has only one USB port, while the A7 integrates a USB hub,
>    which provides two front-side USB port, and an internal USB port as
>    well.
> 
>  - The A6 has 512 MB of RAM, while the A7 has 1 GB of RAM.
> 
>  - Slightly different GPIOs for some functions.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
>  arch/arm/boot/dts/Makefile                   |   3 +-
>  arch/arm/boot/dts/kirkwood-openblocks_a7.dts | 223 +++++++++++++++++++++++++++
>  2 files changed, 225 insertions(+), 1 deletion(-)
>  create mode 100644 arch/arm/boot/dts/kirkwood-openblocks_a7.dts
> 
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 802720e..64783bb 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -101,7 +101,8 @@ dtb-$(CONFIG_ARCH_KIRKWOOD) += kirkwood-cloudbox.dtb \
>  	kirkwood-topkick.dtb \
>  	kirkwood-ts219-6281.dtb \
>  	kirkwood-ts219-6282.dtb \
> -	kirkwood-openblocks_a6.dtb
> +	kirkwood-openblocks_a6.dtb \
> +	kirkwood-openblocks_a7.dtb
>  dtb-$(CONFIG_ARCH_MARCO) += marco-evb.dtb
>  dtb-$(CONFIG_ARCH_MSM) += msm8660-surf.dtb \
>  	msm8960-cdp.dtb
> diff --git a/arch/arm/boot/dts/kirkwood-openblocks_a7.dts b/arch/arm/boot/dts/kirkwood-openblocks_a7.dts
> new file mode 100644
> index 0000000..1864972
> --- /dev/null
> +++ b/arch/arm/boot/dts/kirkwood-openblocks_a7.dts
> @@ -0,0 +1,223 @@
> +/*
> + * Device Tree file for OpenBlocks A7 board
> + *
> + * Copyright (C) 2013 Free Electrons
> + *
> + * Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> + *
> + * This file is licensed under the terms of the GNU General Public
> + * License version 2.  This program is licensed "as is" without any
> + * warranty of any kind, whether express or implied.
> + */
> +
> +/dts-v1/;
> +
> +#include "kirkwood.dtsi"
> +#include "kirkwood-6282.dtsi"
> +
> +/ {
> +	model = "Plat'Home OpenBlocksA7";
> +	compatible = "plathome,openblocks-a7", "marvell,kirkwood-88f6283", "marvell,kirkwood";
> +
> +	memory {
> +		device_type = "memory";
> +		reg = <0x00000000 0x40000000>; /* 1 GB */
> +	};
> +
> +	chosen {
> +		bootargs = "console=ttyS0,115200n8 earlyprintk";
> +	};
> +
> +	ocp at f1000000 {
> +		serial at 12000 {
> +			status = "ok";
> +			pinctrl-0 = <&pmx_uart0>;
> +			pinctrl-names = "default";
> +		};
> +
> +		serial at 12100 {
> +			status = "ok";
> +			pinctrl-0 = <&pmx_uart1>;
> +			pinctrl-names = "default";
> +		};
> +
> +		nand at 3000000 {
> +			chip-delay = <25>;
> +			status = "okay";
> +			pinctrl-0 = <&pmx_nand>;
> +			pinctrl-names = "default";
> +
> +			partition at 0 {
> +				label = "uboot";
> +				reg = <0x0 0x1c0000>;
> +			};
> +
> +			partition at 90000 {
> +				label = "env";
> +				reg = <0x1c0000 0x2c0000>;
> +			};

Hmm, something doesn't look right here.  Cut-n-paste problem?  Did you
run 'make dtbs' against this?  I get address size errors when I do.

At any rate, I've fixed it up (new version, incorporating my fix and
Andrew's requested change, below) and added it to mvebu/dt, and
for-next.

let me know if it's ok with you and I'll push it tomorrow.

thx,

Jason.

----->8------------------------------------
commit 8b96b90abbf6645e0a5e4ac68515f68d405a069b
Author: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Date:   Wed Oct 30 17:55:09 2013 +0100

    ARM: kirkwood: add support for OpenBlocks A7 platform
    
    The OpenBlocks A7 board is designed and sold by PlatHome, and based on
    a Kirkwood 6283 Marvell SoC. It is quite similar to the OpenBlocks A6
    already supported in the kernel, with the following main differences:
    
     - The A6 uses a RTC on I2C, while the A7 uses the internal SoC RTC.
    
     - The A6 has one Ethernet port, while the A7 has two Ethernet ports
    
     - The A6 has only one USB port, while the A7 integrates a USB hub,
       which provides two front-side USB port, and an internal USB port as
       well.
    
     - The A6 has 512 MB of RAM, while the A7 has 1 GB of RAM.
    
     - Slightly different GPIOs for some functions.
    
    Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
    Acked-by: Andrew Lunn <andrew@lunn.ch>
    Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
    Signed-off-by: Jason Cooper <jason@lakedaemon.net>

diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 5b832744a0bb..f2b1c33efbfc 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -95,12 +95,13 @@ dtb-$(CONFIG_ARCH_KIRKWOOD) += kirkwood-cloudbox.dtb \
 	kirkwood-ns2mini.dtb \
 	kirkwood-nsa310.dtb \
 	kirkwood-nsa310a.dtb \
+	kirkwood-openblocks_a6.dtb \
+	kirkwood-openblocks_a7.dtb \
 	kirkwood-sheevaplug.dtb \
 	kirkwood-sheevaplug-esata.dtb \
 	kirkwood-topkick.dtb \
 	kirkwood-ts219-6281.dtb \
-	kirkwood-ts219-6282.dtb \
-	kirkwood-openblocks_a6.dtb
+	kirkwood-ts219-6282.dtb
 dtb-$(CONFIG_ARCH_MARCO) += marco-evb.dtb
 dtb-$(CONFIG_ARCH_MSM) += msm8660-surf.dtb \
 	msm8960-cdp.dtb
diff --git a/arch/arm/boot/dts/kirkwood-openblocks_a7.dts b/arch/arm/boot/dts/kirkwood-openblocks_a7.dts
new file mode 100644
index 000000000000..851fb2a60f20
--- /dev/null
+++ b/arch/arm/boot/dts/kirkwood-openblocks_a7.dts
@@ -0,0 +1,223 @@
+/*
+ * Device Tree file for OpenBlocks A7 board
+ *
+ * Copyright (C) 2013 Free Electrons
+ *
+ * Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
+ *
+ * This file is licensed under the terms of the GNU General Public
+ * License version 2.  This program is licensed "as is" without any
+ * warranty of any kind, whether express or implied.
+ */
+
+/dts-v1/;
+
+#include "kirkwood.dtsi"
+#include "kirkwood-6282.dtsi"
+
+/ {
+	model = "Plat'Home OpenBlocksA7";
+	compatible = "plathome,openblocks-a7", "marvell,kirkwood-88f6283", "marvell,kirkwood";
+
+	memory {
+		device_type = "memory";
+		reg = <0x00000000 0x40000000>; /* 1 GB */
+	};
+
+	chosen {
+		bootargs = "console=ttyS0,115200n8 earlyprintk";
+	};
+
+	ocp at f1000000 {
+		serial at 12000 {
+			status = "ok";
+			pinctrl-0 = <&pmx_uart0>;
+			pinctrl-names = "default";
+		};
+
+		serial at 12100 {
+			status = "ok";
+			pinctrl-0 = <&pmx_uart1>;
+			pinctrl-names = "default";
+		};
+
+		sata at 80000 {
+			nr-ports = <1>;
+			status = "okay";
+		};
+
+		i2c at 11100 {
+			status = "okay";
+			pinctrl-0 = <&pmx_twsi1>;
+			pinctrl-names = "default";
+
+			s24c02: s24c02 at 50 {
+				compatible = "24c02";
+				reg = <0x50>;
+			};
+		};
+
+		pinctrl: pinctrl at 10000 {
+			pinctrl-0 = <&pmx_dip_switches &pmx_gpio_header>;
+			pinctrl-names = "default";
+
+			pmx_uart0: pmx-uart0 {
+				marvell,pins = "mpp10", "mpp11", "mpp15",
+					"mpp16";
+				marvell,function = "uart0";
+			};
+
+			pmx_uart1: pmx-uart1 {
+				marvell,pins = "mpp13", "mpp14", "mpp8",
+					"mpp9";
+				marvell,function = "uart1";
+			};
+
+			pmx_sysrst: pmx-sysrst {
+				marvell,pins = "mpp6";
+				marvell,function = "sysrst";
+			};
+
+			pmx_dip_switches: pmx-dip-switches {
+				marvell,pins = "mpp44", "mpp45", "mpp46", "mpp47";
+				marvell,function = "gpio";
+			};
+
+			/*
+			 * Accessible on connector J202. The MPP
+			 * listed below are pin 1-7, pin 8 is unused,
+			 * pin 9 is external reset input and pin 10 is
+			 * ground.
+			 */
+			pmx_gpio_header: pmx-gpio-header {
+				marvell,pins = "mpp17", "mpp7", "mpp29", "mpp28",
+					       "mpp35", "mpp34", "mpp40";
+				marvell,function = "gpio";
+			};
+
+			pmx_gpio_init: pmx-init {
+				marvell,pins = "mpp38";
+				marvell,function = "gpio";
+			};
+
+			pmx_usb_oc: pmx-usb-oc {
+				marvell,pins = "mpp39";
+				marvell,function = "gpio";
+			};
+
+			pmx_leds: pmx-leds {
+				marvell,pins = "mpp41", "mpp42", "mpp43";
+				marvell,function = "gpio";
+			};
+
+			pmx_ge1: pmx-ge1 {
+				marvell,pins = "mpp20", "mpp21", "mpp22", "mpp23",
+					       "mpp24", "mpp25", "mpp26", "mpp27",
+					       "mpp30", "mpp31", "mpp32", "mpp33";
+				marvell,function = "ge1";
+			};
+		};
+	};
+
+	gpio-leds {
+		compatible = "gpio-leds";
+		pinctrl-0 = <&pmx_leds>;
+		pinctrl-names = "default";
+
+		led-red {
+			label = "obsa7:red:stat";
+			gpios = <&gpio1 9 1>;
+		};
+
+		led-green {
+			label = "obsa7:green:stat";
+			gpios = <&gpio1 10 1>;
+		};
+
+		led-yellow {
+			label = "obsa7:yellow:stat";
+			gpios = <&gpio1 11 1>;
+		};
+        };
+
+	gpio_keys {
+		compatible = "gpio-keys";
+		pinctrl-0 = <&pmx_gpio_init>;
+		pinctrl-names = "default";
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		button at 1 {
+			label = "Init Button";
+			linux,code = <116>;
+			gpios = <&gpio1 6 0>;
+		};
+	};
+};
+
+&nand {
+	chip-delay = <25>;
+	status = "okay";
+	pinctrl-0 = <&pmx_nand>;
+	pinctrl-names = "default";
+
+	partition at 0 {
+		label = "uboot";
+		reg = <0x0 0x1c0000>;
+	};
+
+	partition at 1c0000 {
+		label = "env";
+		reg = <0x1c0000 0x2c0000>;
+	};
+
+	partition at 480000 {
+		label = "test";
+		reg = <0x480000 0x160000>;
+	};
+
+	partition at 5e0000 {
+		label = "conf";
+		reg = <0x5e0000 0x540000>;
+	};
+
+	partition at b20000 {
+		label = "linux";
+		reg = <0xb20000 0x3d40000>;
+	};
+
+	partition at 4860000 {
+		label = "user";
+		reg = <0x4860000 0xb7a0000>;
+	};
+};
+
+&mdio {
+	status = "okay";
+
+	ethphy0: ethernet-phy at 0 {
+		device_type = "ethernet-phy";
+		reg = <0>;
+	};
+
+	ethphy1: ethernet-phy at 1 {
+		device_type = "ethernet-phy";
+		reg = <1>;
+	};
+};
+
+&eth0 {
+	status = "okay";
+	ethernet0-port at 0 {
+		phy-handle = <&ethphy0>;
+	};
+};
+
+&eth1 {
+	status = "okay";
+	pinctrl-0 = <&pmx_ge1>;
+	pinctrl-names = "default";
+	ethernet1-port at 0 {
+		phy-handle = <&ethphy1>;
+	};
+};

[PATCH 1/2] ARM: kirkwood: add support for OpenBlocks A7 platform

[Thomas Petazzoni]

Dear Jason Cooper,

On Wed, 30 Oct 2013 15:57:25 -0400, Jason Cooper wrote:

> > +			partition at 0 {
> > +				label = "uboot";
> > +				reg = <0x0 0x1c0000>;
> > +			};
> > +
> > +			partition at 90000 {
> > +				label = "env";
> > +				reg = <0x1c0000 0x2c0000>;
> > +			};
> 
> Hmm, something doesn't look right here.  Cut-n-paste problem?  Did you
> run 'make dtbs' against this?  I get address size errors when I do.

Strange. 'make dtbs' was working here. What was wrong exactly? Just
that the unit address (@90000) didn't match the starting address
0x1c0000 ?

> let me know if it's ok with you and I'll push it tomorrow.

This all looks good to me!

Thanks a lot,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[PATCH 1/2] ARM: kirkwood: add support for OpenBlocks A7 platform

[Gregory CLEMENT]

On 31/10/2013 09:37, Thomas Petazzoni wrote:
> Dear Jason Cooper,
> 
> On Wed, 30 Oct 2013 15:57:25 -0400, Jason Cooper wrote:
> 
>>> +			partition at 0 {
>>> +				label = "uboot";
>>> +				reg = <0x0 0x1c0000>;
>>> +			};
>>> +
>>> +			partition at 90000 {
>>> +				label = "env";
>>> +				reg = <0x1c0000 0x2c0000>;
>>> +			};
>>
>> Hmm, something doesn't look right here.  Cut-n-paste problem?  Did you
>> run 'make dtbs' against this?  I get address size errors when I do.
> 
> Strange. 'make dtbs' was working here. What was wrong exactly? Just
> that the unit address (@90000) didn't match the starting address
> 0x1c0000 ?

The unit address has no special meaning for the device tree it's just a
way to give a unique name to a node right?

So in this case it is not really a problem, but it's just nicer for the
coherency of the information in the dt to have the unit address which match
the starting address.

I also do a make dtbs ans I didn't get any errors:
$ make dtbs
 [...]
  DTC     arch/arm/boot/dts/kirkwood-openblocks_a6.dtb
  DTC     arch/arm/boot/dts/kirkwood-openblocks_a7.dtb

Regards,
> 
>> let me know if it's ok with you and I'll push it tomorrow.
> 
> This all looks good to me!
> 
> Thanks a lot,
> 
> Thomas
> 


-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[PATCH 1/2] ARM: kirkwood: add support for OpenBlocks A7 platform

[Thomas Petazzoni]

Dear Gregory CLEMENT,

On Thu, 31 Oct 2013 10:17:43 +0100, Gregory CLEMENT wrote:

> > Strange. 'make dtbs' was working here. What was wrong exactly? Just
> > that the unit address (@90000) didn't match the starting address
> > 0x1c0000 ?
> 
> The unit address has no special meaning for the device tree it's just a
> way to give a unique name to a node right?

Yes, that's also my understanding.

> So in this case it is not really a problem, but it's just nicer for the
> coherency of the information in the dt to have the unit address which match
> the starting address.

Indeed, it's much better if they match (shame on me for the silly
copy/paste), but having then *not* matching should not cause any DTC
error, I believe.

> I also do a make dtbs ans I didn't get any errors:
> $ make dtbs
>  [...]
>   DTC     arch/arm/boot/dts/kirkwood-openblocks_a6.dtb
>   DTC     arch/arm/boot/dts/kirkwood-openblocks_a7.dtb

Same here.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[PATCH 1/2] ARM: kirkwood: add support for OpenBlocks A7 platform

[Jason Cooper]

On Thu, Oct 31, 2013 at 10:21:23AM +0100, Thomas Petazzoni wrote:
> Dear Gregory CLEMENT,
> 
> On Thu, 31 Oct 2013 10:17:43 +0100, Gregory CLEMENT wrote:
> 
> > > Strange. 'make dtbs' was working here. What was wrong exactly? Just
> > > that the unit address (@90000) didn't match the starting address
> > > 0x1c0000 ?
> > 
> > The unit address has no special meaning for the device tree it's just a
> > way to give a unique name to a node right?
> 
> Yes, that's also my understanding.

Correct, that's not what caused the error.

> > So in this case it is not really a problem, but it's just nicer for the
> > coherency of the information in the dt to have the unit address which match
> > the starting address.
> 
> Indeed, it's much better if they match (shame on me for the silly
> copy/paste), but having then *not* matching should not cause any DTC
> error, I believe.
> 
> > I also do a make dtbs ans I didn't get any errors:
> > $ make dtbs
> >  [...]
> >   DTC     arch/arm/boot/dts/kirkwood-openblocks_a6.dtb
> >   DTC     arch/arm/boot/dts/kirkwood-openblocks_a7.dtb
> 
> Same here.

With Thomas' original patch (on top of mvebu/dt, based on v3.12-rc1):

$ make kirkwood_defconfig
$ make dtbs
...
  DTC     arch/arm/boot/dts/kirkwood-openblocks_a6.dtb
  DTC     arch/arm/boot/dts/kirkwood-openblocks_a7.dtb
Warning (reg_format): "reg" property in /ocp at f1000000/nand at 3000000/partition at 0 has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1)
Warning (reg_format): "reg" property in /ocp at f1000000/nand at 3000000/partition at 90000 has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1)
Warning (reg_format): "reg" property in /ocp at f1000000/nand at 3000000/partition at d4000 has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1)
Warning (reg_format): "reg" property in /ocp at f1000000/nand at 3000000/partition at f4000 has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1)
Warning (reg_format): "reg" property in /ocp at f1000000/nand at 3000000/partition at 4f4000 has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1)
Warning (reg_format): "reg" property in /ocp at f1000000/nand at 3000000/partition at 2214000 has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1)
Warning (avoid_default_addr_size): Relying on default #address-cells value for /ocp at f1000000/nand at 3000000/partition at 0
Warning (avoid_default_addr_size): Relying on default #size-cells value for /ocp at f1000000/nand at 3000000/partition at 0
Warning (avoid_default_addr_size): Relying on default #address-cells value for /ocp at f1000000/nand at 3000000/partition at 90000
Warning (avoid_default_addr_size): Relying on default #size-cells value for /ocp at f1000000/nand at 3000000/partition at 90000
Warning (avoid_default_addr_size): Relying on default #address-cells value for /ocp at f1000000/nand at 3000000/partition at d4000
Warning (avoid_default_addr_size): Relying on default #size-cells value for /ocp at f1000000/nand at 3000000/partition at d4000
Warning (avoid_default_addr_size): Relying on default #address-cells value for /ocp at f1000000/nand at 3000000/partition at f4000
Warning (avoid_default_addr_size): Relying on default #size-cells value for /ocp at f1000000/nand at 3000000/partition at f4000
Warning (avoid_default_addr_size): Relying on default #address-cells value for /ocp at f1000000/nand at 3000000/partition at 4f4000
Warning (avoid_default_addr_size): Relying on default #size-cells value for /ocp at f1000000/nand at 3000000/partition at 4f4000
Warning (avoid_default_addr_size): Relying on default #address-cells value for /ocp at f1000000/nand at 3000000/partition at 2214000
Warning (avoid_default_addr_size): Relying on default #size-cells value for /ocp at f1000000/nand at 3000000/partition at 2214000

thx,

Jason.

[PATCH 1/2] ARM: kirkwood: add support for OpenBlocks A7 platform

[Gregory CLEMENT]

On 31/10/2013 13:50, Jason Cooper wrote:
> On Thu, Oct 31, 2013 at 10:21:23AM +0100, Thomas Petazzoni wrote:
>> Dear Gregory CLEMENT,
>>
>> On Thu, 31 Oct 2013 10:17:43 +0100, Gregory CLEMENT wrote:
>>
>>>> Strange. 'make dtbs' was working here. What was wrong exactly? Just
>>>> that the unit address (@90000) didn't match the starting address
>>>> 0x1c0000 ?
>>>
>>> The unit address has no special meaning for the device tree it's just a
>>> way to give a unique name to a node right?
>>
>> Yes, that's also my understanding.
> 
> Correct, that's not what caused the error.
> 
>>> So in this case it is not really a problem, but it's just nicer for the
>>> coherency of the information in the dt to have the unit address which match
>>> the starting address.
>>
>> Indeed, it's much better if they match (shame on me for the silly
>> copy/paste), but having then *not* matching should not cause any DTC
>> error, I believe.
>>
>>> I also do a make dtbs ans I didn't get any errors:
>>> $ make dtbs
>>>  [...]
>>>   DTC     arch/arm/boot/dts/kirkwood-openblocks_a6.dtb
>>>   DTC     arch/arm/boot/dts/kirkwood-openblocks_a7.dtb
>>
>> Same here.
> 
> With Thomas' original patch (on top of mvebu/dt, based on v3.12-rc1):

On my side I tested the patch on top on v3.12-rc7. So the difference should
be there.

> 
> $ make kirkwood_defconfig
> $ make dtbs
> ...
>   DTC     arch/arm/boot/dts/kirkwood-openblocks_a6.dtb
>   DTC     arch/arm/boot/dts/kirkwood-openblocks_a7.dtb
> Warning (reg_format): "reg" property in /ocp at f1000000/nand at 3000000/partition at 0 has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1)
> Warning (reg_format): "reg" property in /ocp at f1000000/nand at 3000000/partition at 90000 has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1)
> Warning (reg_format): "reg" property in /ocp at f1000000/nand at 3000000/partition at d4000 has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1)
> Warning (reg_format): "reg" property in /ocp at f1000000/nand at 3000000/partition at f4000 has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1)
> Warning (reg_format): "reg" property in /ocp at f1000000/nand at 3000000/partition at 4f4000 has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1)
> Warning (reg_format): "reg" property in /ocp at f1000000/nand at 3000000/partition at 2214000 has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1)
> Warning (avoid_default_addr_size): Relying on default #address-cells value for /ocp at f1000000/nand at 3000000/partition at 0
> Warning (avoid_default_addr_size): Relying on default #size-cells value for /ocp at f1000000/nand at 3000000/partition at 0
> Warning (avoid_default_addr_size): Relying on default #address-cells value for /ocp at f1000000/nand at 3000000/partition at 90000
> Warning (avoid_default_addr_size): Relying on default #size-cells value for /ocp at f1000000/nand at 3000000/partition at 90000
> Warning (avoid_default_addr_size): Relying on default #address-cells value for /ocp at f1000000/nand at 3000000/partition at d4000
> Warning (avoid_default_addr_size): Relying on default #size-cells value for /ocp at f1000000/nand at 3000000/partition at d4000
> Warning (avoid_default_addr_size): Relying on default #address-cells value for /ocp at f1000000/nand at 3000000/partition at f4000
> Warning (avoid_default_addr_size): Relying on default #size-cells value for /ocp at f1000000/nand at 3000000/partition at f4000
> Warning (avoid_default_addr_size): Relying on default #address-cells value for /ocp at f1000000/nand at 3000000/partition at 4f4000
> Warning (avoid_default_addr_size): Relying on default #size-cells value for /ocp at f1000000/nand at 3000000/partition at 4f4000
> Warning (avoid_default_addr_size): Relying on default #address-cells value for /ocp at f1000000/nand at 3000000/partition at 2214000
> Warning (avoid_default_addr_size): Relying on default #size-cells value for /ocp at f1000000/nand at 3000000/partition at 2214000
> 
> thx,
> 
> Jason.
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 


-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[PATCH 1/2] ARM: kirkwood: add support for OpenBlocks A7 platform

[Jason Cooper]

On Thu, Oct 31, 2013 at 01:54:42PM +0100, Gregory CLEMENT wrote:
> On 31/10/2013 13:50, Jason Cooper wrote:
> > On Thu, Oct 31, 2013 at 10:21:23AM +0100, Thomas Petazzoni wrote:
> >> Dear Gregory CLEMENT,
> >>
> >> On Thu, 31 Oct 2013 10:17:43 +0100, Gregory CLEMENT wrote:
> >>
> >>>> Strange. 'make dtbs' was working here. What was wrong exactly? Just
> >>>> that the unit address (@90000) didn't match the starting address
> >>>> 0x1c0000 ?
> >>>
> >>> The unit address has no special meaning for the device tree it's just a
> >>> way to give a unique name to a node right?
> >>
> >> Yes, that's also my understanding.
> > 
> > Correct, that's not what caused the error.
> > 
> >>> So in this case it is not really a problem, but it's just nicer for the
> >>> coherency of the information in the dt to have the unit address which match
> >>> the starting address.
> >>
> >> Indeed, it's much better if they match (shame on me for the silly
> >> copy/paste), but having then *not* matching should not cause any DTC
> >> error, I believe.
> >>
> >>> I also do a make dtbs ans I didn't get any errors:
> >>> $ make dtbs
> >>>  [...]
> >>>   DTC     arch/arm/boot/dts/kirkwood-openblocks_a6.dtb
> >>>   DTC     arch/arm/boot/dts/kirkwood-openblocks_a7.dtb
> >>
> >> Same here.
> > 
> > With Thomas' original patch (on top of mvebu/dt, based on v3.12-rc1):
> 
> On my side I tested the patch on top on v3.12-rc7. So the difference should
> be there.

Ok, I get no warnings when I rebase the original patch onto v3.12-rc7.

Since Thomas is ok with my version, I'm going to send it up since it
doesn't generate warnings.  There's no point merging in v3.12-rc7 just
to silence a few warnings.

thx,

Jason.

> > $ make kirkwood_defconfig
> > $ make dtbs
> > ...
> >   DTC     arch/arm/boot/dts/kirkwood-openblocks_a6.dtb
> >   DTC     arch/arm/boot/dts/kirkwood-openblocks_a7.dtb
> > Warning (reg_format): "reg" property in /ocp at f1000000/nand at 3000000/partition at 0 has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1)
> > Warning (reg_format): "reg" property in /ocp at f1000000/nand at 3000000/partition at 90000 has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1)
> > Warning (reg_format): "reg" property in /ocp at f1000000/nand at 3000000/partition at d4000 has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1)
> > Warning (reg_format): "reg" property in /ocp at f1000000/nand at 3000000/partition at f4000 has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1)
> > Warning (reg_format): "reg" property in /ocp at f1000000/nand at 3000000/partition at 4f4000 has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1)
> > Warning (reg_format): "reg" property in /ocp at f1000000/nand at 3000000/partition at 2214000 has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1)
> > Warning (avoid_default_addr_size): Relying on default #address-cells value for /ocp at f1000000/nand at 3000000/partition at 0
> > Warning (avoid_default_addr_size): Relying on default #size-cells value for /ocp at f1000000/nand at 3000000/partition at 0
> > Warning (avoid_default_addr_size): Relying on default #address-cells value for /ocp at f1000000/nand at 3000000/partition at 90000
> > Warning (avoid_default_addr_size): Relying on default #size-cells value for /ocp at f1000000/nand at 3000000/partition at 90000
> > Warning (avoid_default_addr_size): Relying on default #address-cells value for /ocp at f1000000/nand at 3000000/partition at d4000
> > Warning (avoid_default_addr_size): Relying on default #size-cells value for /ocp at f1000000/nand at 3000000/partition at d4000
> > Warning (avoid_default_addr_size): Relying on default #address-cells value for /ocp at f1000000/nand at 3000000/partition at f4000
> > Warning (avoid_default_addr_size): Relying on default #size-cells value for /ocp at f1000000/nand at 3000000/partition at f4000
> > Warning (avoid_default_addr_size): Relying on default #address-cells value for /ocp at f1000000/nand at 3000000/partition at 4f4000
> > Warning (avoid_default_addr_size): Relying on default #size-cells value for /ocp at f1000000/nand at 3000000/partition at 4f4000
> > Warning (avoid_default_addr_size): Relying on default #address-cells value for /ocp at f1000000/nand at 3000000/partition at 2214000
> > Warning (avoid_default_addr_size): Relying on default #size-cells value for /ocp at f1000000/nand at 3000000/partition at 2214000

[PATCH 2/2] ARM: kirkwood: enable HIGHMEM in defconfig

[Thomas Petazzoni]

The Kirkwood-based OpenBlocks A7 platform has 1 GB of memory. To make
use of this memory completely, enabling HIGHMEM is needed, so we
enable it by default in the kirkwood_defconfig.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 arch/arm/configs/kirkwood_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/configs/kirkwood_defconfig b/arch/arm/configs/kirkwood_defconfig
index 0ae0eaeb..2e762d9 100644
--- a/arch/arm/configs/kirkwood_defconfig
+++ b/arch/arm/configs/kirkwood_defconfig
@@ -27,6 +27,7 @@ CONFIG_PCI_MVEBU=y
 CONFIG_PREEMPT=y
 CONFIG_AEABI=y
 # CONFIG_OABI_COMPAT is not set
+CONFIG_HIGHMEM=y
 CONFIG_ZBOOT_ROM_TEXT=0x0
 CONFIG_ZBOOT_ROM_BSS=0x0
 CONFIG_CPU_FREQ=y
-- 
1.8.1.2

[PATCH 2/2] ARM: kirkwood: enable HIGHMEM in defconfig

[Andrew Lunn]

On Wed, Oct 30, 2013 at 05:55:10PM +0100, Thomas Petazzoni wrote:
> The Kirkwood-based OpenBlocks A7 platform has 1 GB of memory. To make
> use of this memory completely, enabling HIGHMEM is needed, so we
> enable it by default in the kirkwood_defconfig.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Acked-by: Andrew Lunn <andrew@lunn.ch>

	  Andrew

> ---
>  arch/arm/configs/kirkwood_defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/configs/kirkwood_defconfig b/arch/arm/configs/kirkwood_defconfig
> index 0ae0eaeb..2e762d9 100644
> --- a/arch/arm/configs/kirkwood_defconfig
> +++ b/arch/arm/configs/kirkwood_defconfig
> @@ -27,6 +27,7 @@ CONFIG_PCI_MVEBU=y
>  CONFIG_PREEMPT=y
>  CONFIG_AEABI=y
>  # CONFIG_OABI_COMPAT is not set
> +CONFIG_HIGHMEM=y
>  CONFIG_ZBOOT_ROM_TEXT=0x0
>  CONFIG_ZBOOT_ROM_BSS=0x0
>  CONFIG_CPU_FREQ=y
> -- 
> 1.8.1.2
> 

[PATCH 2/2] ARM: kirkwood: enable HIGHMEM in defconfig

[Gregory CLEMENT]

On 30/10/2013 17:55, Thomas Petazzoni wrote:
> The Kirkwood-based OpenBlocks A7 platform has 1 GB of memory. To make
> use of this memory completely, enabling HIGHMEM is needed, so we
> enable it by default in the kirkwood_defconfig.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>

> ---
>  arch/arm/configs/kirkwood_defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/configs/kirkwood_defconfig b/arch/arm/configs/kirkwood_defconfig
> index 0ae0eaeb..2e762d9 100644
> --- a/arch/arm/configs/kirkwood_defconfig
> +++ b/arch/arm/configs/kirkwood_defconfig
> @@ -27,6 +27,7 @@ CONFIG_PCI_MVEBU=y
>  CONFIG_PREEMPT=y
>  CONFIG_AEABI=y
>  # CONFIG_OABI_COMPAT is not set
> +CONFIG_HIGHMEM=y
>  CONFIG_ZBOOT_ROM_TEXT=0x0
>  CONFIG_ZBOOT_ROM_BSS=0x0
>  CONFIG_CPU_FREQ=y
> 


-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[PATCH 2/2] ARM: kirkwood: enable HIGHMEM in defconfig

[Jason Cooper]

On Wed, Oct 30, 2013 at 05:55:10PM +0100, Thomas Petazzoni wrote:
> The Kirkwood-based OpenBlocks A7 platform has 1 GB of memory. To make
> use of this memory completely, enabling HIGHMEM is needed, so we
> enable it by default in the kirkwood_defconfig.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
>  arch/arm/configs/kirkwood_defconfig | 1 +
>  1 file changed, 1 insertion(+)

Applied to mvebu-next/defconfig

thx,

Jason.