From: LW@KARO-electronics.de (Lothar Waßmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: imx6q: add missing sentinel to divider table
Date: Thu, 31 Oct 2013 13:04:51 +0100 [thread overview]
Message-ID: <20131031130451.15e90077@ipc1.ka-ro> (raw)
In-Reply-To: <1383220548-8622-1-git-send-email-LW@KARO-electronics.de>
Hi,
Lothar Wa?mann wrote:
> The clk_enet_ref_table[] is missing a final empty entry as end of list
> marker. Also make the existing markers more obvious.
> Signed-off-by: Lothar Wa?mann <LW@KARO-electronics.de>
> ---
> arch/arm/mach-imx/clk-imx6q.c | 5 +++--
>
There is something else that looks suspicious in this file:
The video_div_table[] has four entries:
| { .val = 0, .div = 1, },
| { .val = 1, .div = 2, },
| { .val = 2, .div = 1, },
| { .val = 3, .div = 4, },
But the code that sets the dividers to '1' as a workaround for the TO1.0
chip revision only two dividers are modified, one of which is already
'1':
|if (cpu_is_imx6q() && imx_get_soc_revision() == IMX_CHIP_REVISION_1_0) {
| post_div_table[1].div = 1;
| post_div_table[2].div = 1;
| video_div_table[1].div = 1;
| video_div_table[2].div = 1;
^
This probably should be '3' instead?
Lothar Wa?mann
--
___________________________________________________________
Ka-Ro electronics GmbH | Pascalstra?e 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Gesch?ftsf?hrer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996
www.karo-electronics.de | info at karo-electronics.de
___________________________________________________________
next prev parent reply other threads:[~2013-10-31 12:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-31 11:55 [PATCH] ARM: imx6q: add missing sentinel to divider table Lothar Waßmann
2013-10-31 12:04 ` Lothar Waßmann [this message]
2013-11-01 9:14 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131031130451.15e90077@ipc1.ka-ro \
--to=lw@karo-electronics.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).