* [PATCH 1/3] ARM: shmobile: r8a7790: Add early debugging support
2013-10-29 15:23 [PATCH 0/3] ARM: shmobile: Lager reference serial port support Laurent Pinchart
@ 2013-10-29 15:23 ` Laurent Pinchart
2013-10-29 15:23 ` [PATCH 2/3] ARM: shmobile: r8a7790: Add serial ports to the device tree Laurent Pinchart
` (2 subsequent siblings)
3 siblings, 0 replies; 10+ messages in thread
From: Laurent Pinchart @ 2013-10-29 15:23 UTC (permalink / raw)
To: linux-arm-kernel
Add serial port debug macros for the SCIF0 serial port on R8A7790.
Support for other serial ports can easily be added if needed.
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
arch/arm/Kconfig.debug | 8 ++++++++
arch/arm/include/debug/r8a7790.S | 43 ++++++++++++++++++++++++++++++++++++++++
2 files changed, 51 insertions(+)
create mode 100644 arch/arm/include/debug/r8a7790.S
diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
index 9762c84..f1b765a 100644
--- a/arch/arm/Kconfig.debug
+++ b/arch/arm/Kconfig.debug
@@ -493,6 +493,13 @@ choice
Say Y here if you want kernel low-level debugging support
on PXA UART1.
+ config DEBUG_R8A7790
+ bool "Kernel low-level debugging messages via SCIF0 on R8A7790 SoCs"
+ depends on ARCH_R8A7790
+ help
+ Say Y here if you want kernel low-level debugging support
+ on Renesas R8A7790 based platforms.
+
config DEBUG_REALVIEW_STD_PORT
bool "RealView Default UART"
depends on ARCH_REALVIEW
@@ -901,6 +908,7 @@ config DEBUG_LL_INCLUDE
DEBUG_MSM8660_UART || \
DEBUG_MSM8960_UART
default "debug/omap2plus.S" if DEBUG_OMAP2PLUS_UART
+ default "debug/r8a7790.S" if DEBUG_R8A7790
default "debug/sirf.S" if DEBUG_SIRFPRIMA2_UART1 || DEBUG_SIRFMARCO_UART1
default "debug/sti.S" if DEBUG_STI_UART
default "debug/tegra.S" if DEBUG_TEGRA_UART
diff --git a/arch/arm/include/debug/r8a7790.S b/arch/arm/include/debug/r8a7790.S
new file mode 100644
index 0000000..4f1feb8
--- /dev/null
+++ b/arch/arm/include/debug/r8a7790.S
@@ -0,0 +1,43 @@
+/*
+ * Renesas R8A7790 debugging macro include header
+ *
+ * Copyright (C) 2012-2013 Renesas Electronics Corporation
+ * Copyright (C) 1994-1999 Russell King
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#define FTDR 0x0c
+#define FSR 0x10
+
+#define TDFE (1 << 5)
+#define TEND (1 << 6)
+
+#define SCIF_PHYS 0xe6e60000
+#define SCIF_VIRT 0xffe60000
+
+ .macro addruart, rp, rv, tmp
+ ldr \rp, =SCIF_PHYS
+ ldr \rv, =SCIF_VIRT
+ .endm
+
+ .macro waituart, rd, rx
+1001: ldrh \rd, [\rx, #FSR]
+ tst \rd, #TDFE
+ beq 1001b
+ .endm
+
+ .macro senduart, rd, rx
+ strb \rd, [\rx, #FTDR]
+ ldrh \rd, [\rx, #FSR]
+ bic \rd, \rd, #TEND
+ strh \rd, [\rx, #FSR]
+ .endm
+
+ .macro busyuart, rd, rx
+1001: ldrh \rd, [\rx, #FSR]
+ tst \rd, #TEND
+ beq 1001b
+ .endm
--
1.8.1.5
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 2/3] ARM: shmobile: r8a7790: Add serial ports to the device tree
2013-10-29 15:23 [PATCH 0/3] ARM: shmobile: Lager reference serial port support Laurent Pinchart
2013-10-29 15:23 ` [PATCH 1/3] ARM: shmobile: r8a7790: Add early debugging support Laurent Pinchart
@ 2013-10-29 15:23 ` Laurent Pinchart
2013-10-29 15:23 ` [PATCH 3/3] ARM: shmobile: lager: Enable SCIF0 and SCIF1 serial ports in DT Laurent Pinchart
2013-10-31 5:31 ` [PATCH 0/3] ARM: shmobile: Lager reference serial port support Simon Horman
3 siblings, 0 replies; 10+ messages in thread
From: Laurent Pinchart @ 2013-10-29 15:23 UTC (permalink / raw)
To: linux-arm-kernel
The platform code serial port instantiation mechanism is kept for the
non-DT platforms only.
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
arch/arm/boot/dts/r8a7790.dtsi | 100 +++++++++++++++++++++++++++++++++
arch/arm/mach-shmobile/setup-r8a7790.c | 12 ++--
2 files changed, 106 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
index 94c8373..04a4992 100644
--- a/arch/arm/boot/dts/r8a7790.dtsi
+++ b/arch/arm/boot/dts/r8a7790.dtsi
@@ -287,6 +287,106 @@
status = "disabled";
};
+ scifa0: serial at e6c40000 {
+ compatible = "renesas,scifa-r8a7790", "renesas,scifa-generic";
+ reg = <0 0xe6c40000 0 64>;
+ interrupt-parent = <&gic>;
+ interrupts = <0 144 4>;
+ clocks = <&mstp2_clks R8A7790_CLK_SCIFA0>;
+ clock-names = "sci_ick";
+ status = "disabled";
+ };
+
+ scifa1: serial at e6c50000 {
+ compatible = "renesas,scifa-r8a7790", "renesas,scifa-generic";
+ interrupt-parent = <&gic>;
+ reg = <0 0xe6c50000 0 64>;
+ interrupts = <0 145 4>;
+ clocks = <&mstp2_clks R8A7790_CLK_SCIFA1>;
+ clock-names = "sci_ick";
+ status = "disabled";
+ };
+
+ scifa2: serial at e6c60000 {
+ compatible = "renesas,scifa-r8a7790", "renesas,scifa-generic";
+ interrupt-parent = <&gic>;
+ reg = <0 0xe6c60000 0 64>;
+ interrupts = <0 151 4>;
+ clocks = <&mstp2_clks R8A7790_CLK_SCIFA2>;
+ clock-names = "sci_ick";
+ status = "disabled";
+ };
+
+ scifb0: serial at e6c20000 {
+ compatible = "renesas,scifb-r8a7790", "renesas,scifb-generic";
+ interrupt-parent = <&gic>;
+ reg = <0 0xe6c20000 0 64>;
+ interrupts = <0 148 4>;
+ clocks = <&mstp2_clks R8A7790_CLK_SCIFB0>;
+ clock-names = "sci_ick";
+ status = "disabled";
+ };
+
+ scifb1: serial at e6c30000 {
+ compatible = "renesas,scifb-r8a7790", "renesas,scifb-generic";
+ interrupt-parent = <&gic>;
+ reg = <0 0xe6c30000 0 64>;
+ interrupts = <0 149 4>;
+ clocks = <&mstp2_clks R8A7790_CLK_SCIFB1>;
+ clock-names = "sci_ick";
+ status = "disabled";
+ };
+
+ scifb2: serial at e6ce0000 {
+ compatible = "renesas,scifb-r8a7790", "renesas,scifb-generic";
+ interrupt-parent = <&gic>;
+ reg = <0 0xe6ce0000 0 64>;
+ interrupts = <0 150 4>;
+ clocks = <&mstp2_clks R8A7790_CLK_SCIFB2>;
+ clock-names = "sci_ick";
+ status = "disabled";
+ };
+
+ scif0: serial at e6e60000 {
+ compatible = "renesas,scif-r8a7790", "renesas,scif-generic";
+ interrupt-parent = <&gic>;
+ reg = <0 0xe6e60000 0 64>;
+ interrupts = <0 152 4>;
+ clocks = <&mstp7_clks R8A7790_CLK_SCIF0>;
+ clock-names = "sci_ick";
+ status = "disabled";
+ };
+
+ scif1: serial at e6e68000 {
+ compatible = "renesas,scif-r8a7790", "renesas,scif-generic";
+ interrupt-parent = <&gic>;
+ reg = <0 0xe6e68000 0 64>;
+ interrupts = <0 153 4>;
+ clocks = <&mstp7_clks R8A7790_CLK_SCIF1>;
+ clock-names = "sci_ick";
+ status = "disabled";
+ };
+
+ hscif0: serial at e62c0000 {
+ compatible = "renesas,hscif-r8a7790", "renesas,hscif-generic";
+ interrupt-parent = <&gic>;
+ reg = <0 0xe62c0000 0 96>;
+ interrupts = <0 154 4>;
+ clocks = <&mstp7_clks R8A7790_CLK_HSCIF0>;
+ clock-names = "sci_ick";
+ status = "disabled";
+ };
+
+ hscif1: serial at e62c8000 {
+ compatible = "renesas,hscif-r8a7790", "renesas,hscif-generic";
+ interrupt-parent = <&gic>;
+ reg = <0 0xe62c8000 0 96>;
+ interrupts = <0 155 4>;
+ clocks = <&mstp7_clks R8A7790_CLK_HSCIF1>;
+ clock-names = "sci_ick";
+ status = "disabled";
+ };
+
clocks {
#address-cells = <2>;
#size-cells = <2>;
diff --git a/arch/arm/mach-shmobile/setup-r8a7790.c b/arch/arm/mach-shmobile/setup-r8a7790.c
index c47bceb..8172a82 100644
--- a/arch/arm/mach-shmobile/setup-r8a7790.c
+++ b/arch/arm/mach-shmobile/setup-r8a7790.c
@@ -182,6 +182,12 @@ static const struct resource cmt00_resources[] __initconst = {
void __init r8a7790_add_dt_devices(void)
{
+ r8a7790_register_cmt(00);
+}
+
+void __init r8a7790_add_standard_devices(void)
+{
+ r8a7790_add_dt_devices();
r8a7790_register_scif(SCIFA0);
r8a7790_register_scif(SCIFA1);
r8a7790_register_scif(SCIFB0);
@@ -192,12 +198,6 @@ void __init r8a7790_add_dt_devices(void)
r8a7790_register_scif(SCIF1);
r8a7790_register_scif(HSCIF0);
r8a7790_register_scif(HSCIF1);
- r8a7790_register_cmt(00);
-}
-
-void __init r8a7790_add_standard_devices(void)
-{
- r8a7790_add_dt_devices();
r8a7790_register_irqc(0);
r8a7790_register_thermal();
}
--
1.8.1.5
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 3/3] ARM: shmobile: lager: Enable SCIF0 and SCIF1 serial ports in DT
2013-10-29 15:23 [PATCH 0/3] ARM: shmobile: Lager reference serial port support Laurent Pinchart
2013-10-29 15:23 ` [PATCH 1/3] ARM: shmobile: r8a7790: Add early debugging support Laurent Pinchart
2013-10-29 15:23 ` [PATCH 2/3] ARM: shmobile: r8a7790: Add serial ports to the device tree Laurent Pinchart
@ 2013-10-29 15:23 ` Laurent Pinchart
2013-10-29 18:09 ` Sergei Shtylyov
2013-10-31 5:31 ` [PATCH 0/3] ARM: shmobile: Lager reference serial port support Simon Horman
3 siblings, 1 reply; 10+ messages in thread
From: Laurent Pinchart @ 2013-10-29 15:23 UTC (permalink / raw)
To: linux-arm-kernel
SCIF0 and SCIF1 are used as debug serial ports. Enable them and
configure pinmuxing appropriately. We can now remove the clkdev
registration hack for SCIF devices from the Lager reference board file.
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
arch/arm/boot/dts/r8a7790-lager.dts | 24 ++++++++++++++++++++----
arch/arm/mach-shmobile/board-lager-reference.c | 18 ++----------------
2 files changed, 22 insertions(+), 20 deletions(-)
diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
index a923ab6..9830c87 100644
--- a/arch/arm/boot/dts/r8a7790-lager.dts
+++ b/arch/arm/boot/dts/r8a7790-lager.dts
@@ -16,8 +16,13 @@
model = "Lager";
compatible = "renesas,lager", "renesas,r8a7790";
+ aliases {
+ serial0 = &scif0;
+ serial1 = &scif1;
+ };
+
chosen {
- bootargs = "console=ttySC6,115200 ignore_loglevel rw root=/dev/nfs ip=dhcp";
+ bootargs = "console=ttySC0,115200 ignore_loglevel rw root=/dev/nfs ip=dhcp";
};
memory at 40000000 {
@@ -58,9 +63,6 @@
};
&pfc {
- pinctrl-0 = <&scif0_pins &scif1_pins>;
- pinctrl-names = "default";
-
scif0_pins: scif0 {
renesas,groups = "scif0_data";
renesas,function = "scif0";
@@ -86,3 +88,17 @@
non-removable;
status = "okay";
};
+
+&scif0 {
+ pinctrl-0 = <&scif0_pins>;
+ pinctrl-names = "default";
+
+ status = "okay";
+};
+
+&scif1 {
+ pinctrl-0 = <&scif1_pins>;
+ pinctrl-names = "default";
+
+ status = "okay";
+};
diff --git a/arch/arm/mach-shmobile/board-lager-reference.c b/arch/arm/mach-shmobile/board-lager-reference.c
index bc3d0d2..1f5d6e2 100644
--- a/arch/arm/mach-shmobile/board-lager-reference.c
+++ b/arch/arm/mach-shmobile/board-lager-reference.c
@@ -36,24 +36,10 @@ static void __init lager_init_time(void)
static void __init lager_add_standard_devices(void)
{
/*
- * This is a really crude hack to provide clkdev support to the SCIF
- * and CMT devices until they get moved to DT.
+ * This is a really crude hack to provide clkdev support to the CMT
+ * CMT device until it gets moved to DT.
*/
- static const char * const scif_names[] = {
- "scifa0", "scifa1", "scifb0", "scifb1",
- "scifb2", "scifa2", "scif0", "scif1",
- "hscif0", "hscif1",
- };
struct clk *clk;
- unsigned int i;
-
- for (i = 0; i < ARRAY_SIZE(scif_names); ++i) {
- clk = clk_get(NULL, scif_names[i]);
- if (clk) {
- clk_register_clkdev(clk, NULL, "sh-sci.%u", i);
- clk_put(clk);
- }
- }
clk = clk_get(NULL, "cmt0");
if (clk) {
--
1.8.1.5
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 3/3] ARM: shmobile: lager: Enable SCIF0 and SCIF1 serial ports in DT
2013-10-29 15:23 ` [PATCH 3/3] ARM: shmobile: lager: Enable SCIF0 and SCIF1 serial ports in DT Laurent Pinchart
@ 2013-10-29 18:09 ` Sergei Shtylyov
2013-10-29 18:30 ` Laurent Pinchart
0 siblings, 1 reply; 10+ messages in thread
From: Sergei Shtylyov @ 2013-10-29 18:09 UTC (permalink / raw)
To: linux-arm-kernel
On 29-10-2013 19:23, Laurent Pinchart wrote:
> SCIF0 and SCIF1 are used as debug serial ports. Enable them and
> configure pinmuxing appropriately. We can now remove the clkdev
> registration hack for SCIF devices from the Lager reference board file.
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> arch/arm/boot/dts/r8a7790-lager.dts | 24 ++++++++++++++++++++----
> arch/arm/mach-shmobile/board-lager-reference.c | 18 ++----------------
> 2 files changed, 22 insertions(+), 20 deletions(-)
> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
> index a923ab6..9830c87 100644
> --- a/arch/arm/boot/dts/r8a7790-lager.dts
> +++ b/arch/arm/boot/dts/r8a7790-lager.dts
> @@ -16,8 +16,13 @@
> model = "Lager";
> compatible = "renesas,lager", "renesas,r8a7790";
>
> + aliases {
> + serial0 = &scif0;
> + serial1 = &scif1;
> + };
> +
> chosen {
> - bootargs = "console=ttySC6,115200 ignore_loglevel rw root=/dev/nfs ip=dhcp";
> + bootargs = "console=ttySC0,115200 ignore_loglevel rw root=/dev/nfs ip=dhcp";
Hm... is the rename a by-product of the SCIF device tree enablement?
[...]
> diff --git a/arch/arm/mach-shmobile/board-lager-reference.c b/arch/arm/mach-shmobile/board-lager-reference.c
> index bc3d0d2..1f5d6e2 100644
> --- a/arch/arm/mach-shmobile/board-lager-reference.c
> +++ b/arch/arm/mach-shmobile/board-lager-reference.c
> @@ -36,24 +36,10 @@ static void __init lager_init_time(void)
> static void __init lager_add_standard_devices(void)
> {
> /*
> - * This is a really crude hack to provide clkdev support to the SCIF
> - * and CMT devices until they get moved to DT.
> + * This is a really crude hack to provide clkdev support to the CMT
> + * CMT device until it gets moved to DT.
Minor nit: "CMT" repeated twice.
WBR, Sergei
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH 3/3] ARM: shmobile: lager: Enable SCIF0 and SCIF1 serial ports in DT
2013-10-29 18:09 ` Sergei Shtylyov
@ 2013-10-29 18:30 ` Laurent Pinchart
2013-10-30 0:24 ` Simon Horman
0 siblings, 1 reply; 10+ messages in thread
From: Laurent Pinchart @ 2013-10-29 18:30 UTC (permalink / raw)
To: linux-arm-kernel
Hi Sergei,
On Tuesday 29 October 2013 22:09:34 Sergei Shtylyov wrote:
> On 29-10-2013 19:23, Laurent Pinchart wrote:
> > SCIF0 and SCIF1 are used as debug serial ports. Enable them and
> > configure pinmuxing appropriately. We can now remove the clkdev
> > registration hack for SCIF devices from the Lager reference board file.
> >
> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com>
> > ---
> >
> > arch/arm/boot/dts/r8a7790-lager.dts | 24 ++++++++++++++++----
> > arch/arm/mach-shmobile/board-lager-reference.c | 18 ++----------------
> > 2 files changed, 22 insertions(+), 20 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/r8a7790-lager.dts
> > b/arch/arm/boot/dts/r8a7790-lager.dts index a923ab6..9830c87 100644
> > --- a/arch/arm/boot/dts/r8a7790-lager.dts
> > +++ b/arch/arm/boot/dts/r8a7790-lager.dts
> > @@ -16,8 +16,13 @@
> > model = "Lager";
> > compatible = "renesas,lager", "renesas,r8a7790";
> >
> > + aliases {
> > + serial0 = &scif0;
> > + serial1 = &scif1;
> > + };
> > +
> > chosen {
> > - bootargs = "console=ttySC6,115200 ignore_loglevel rw
> > root=/dev/nfs ip=dhcp";
> > + bootargs = "console=ttySC0,115200 ignore_loglevel rw
> > root=/dev/nfs ip=dhcp";
>
> Hm... is the rename a by-product of the SCIF device tree enablement?
I suppose we could keep the same serial port name using serial6 and serial7 in
the aliases. However, moving to DT will get rid of all other serial ports, so
we would be left with ttySC6 and ttySC7, without ttySC0 to ttySC5. I'm not
sure if I like that.
(CC'ing Simon and Magnus to get their opinion on the subject)
> [...]
>
> > diff --git a/arch/arm/mach-shmobile/board-lager-reference.c
> > b/arch/arm/mach-shmobile/board-lager-reference.c index bc3d0d2..1f5d6e2
> > 100644
> > --- a/arch/arm/mach-shmobile/board-lager-reference.c
> > +++ b/arch/arm/mach-shmobile/board-lager-reference.c
> > @@ -36,24 +36,10 @@ static void __init lager_init_time(void)
> >
> > static void __init lager_add_standard_devices(void)
> > {
> > /*
> > - * This is a really crude hack to provide clkdev support to the SCIF
> > - * and CMT devices until they get moved to DT.
> > + * This is a really crude hack to provide clkdev support to the CMT
> > + * CMT device until it gets moved to DT.
>
> Minor nit: "CMT" repeated twice.
I'll fix that. If no other change is required I won't repost the patch before
sending the pull request.
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH 3/3] ARM: shmobile: lager: Enable SCIF0 and SCIF1 serial ports in DT
2013-10-29 18:30 ` Laurent Pinchart
@ 2013-10-30 0:24 ` Simon Horman
0 siblings, 0 replies; 10+ messages in thread
From: Simon Horman @ 2013-10-30 0:24 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Oct 29, 2013 at 07:30:05PM +0100, Laurent Pinchart wrote:
> Hi Sergei,
>
> On Tuesday 29 October 2013 22:09:34 Sergei Shtylyov wrote:
> > On 29-10-2013 19:23, Laurent Pinchart wrote:
> > > SCIF0 and SCIF1 are used as debug serial ports. Enable them and
> > > configure pinmuxing appropriately. We can now remove the clkdev
> > > registration hack for SCIF devices from the Lager reference board file.
> > >
> > > Signed-off-by: Laurent Pinchart
> > > <laurent.pinchart+renesas@ideasonboard.com>
> > > ---
> > >
> > > arch/arm/boot/dts/r8a7790-lager.dts | 24 ++++++++++++++++----
> > > arch/arm/mach-shmobile/board-lager-reference.c | 18 ++----------------
> > > 2 files changed, 22 insertions(+), 20 deletions(-)
> > >
> > > diff --git a/arch/arm/boot/dts/r8a7790-lager.dts
> > > b/arch/arm/boot/dts/r8a7790-lager.dts index a923ab6..9830c87 100644
> > > --- a/arch/arm/boot/dts/r8a7790-lager.dts
> > > +++ b/arch/arm/boot/dts/r8a7790-lager.dts
> > > @@ -16,8 +16,13 @@
> > > model = "Lager";
> > > compatible = "renesas,lager", "renesas,r8a7790";
> > >
> > > + aliases {
> > > + serial0 = &scif0;
> > > + serial1 = &scif1;
> > > + };
> > > +
> > > chosen {
> > > - bootargs = "console=ttySC6,115200 ignore_loglevel rw
> > > root=/dev/nfs ip=dhcp";
> > > + bootargs = "console=ttySC0,115200 ignore_loglevel rw
> > > root=/dev/nfs ip=dhcp";
> >
> > Hm... is the rename a by-product of the SCIF device tree enablement?
>
> I suppose we could keep the same serial port name using serial6 and serial7 in
> the aliases. However, moving to DT will get rid of all other serial ports, so
> we would be left with ttySC6 and ttySC7, without ttySC0 to ttySC5. I'm not
> sure if I like that.
>
> (CC'ing Simon and Magnus to get their opinion on the subject)
It seems logical to me that if we only have two serial ports initialised
that they should be ttySC0 and ttySC1. Even if that leaves us with the pain
of switching over to use ttySC0 instead of ttySC6 as the console.
>
> > [...]
> >
> > > diff --git a/arch/arm/mach-shmobile/board-lager-reference.c
> > > b/arch/arm/mach-shmobile/board-lager-reference.c index bc3d0d2..1f5d6e2
> > > 100644
> > > --- a/arch/arm/mach-shmobile/board-lager-reference.c
> > > +++ b/arch/arm/mach-shmobile/board-lager-reference.c
> > > @@ -36,24 +36,10 @@ static void __init lager_init_time(void)
> > >
> > > static void __init lager_add_standard_devices(void)
> > > {
> > > /*
> > > - * This is a really crude hack to provide clkdev support to the SCIF
> > > - * and CMT devices until they get moved to DT.
> > > + * This is a really crude hack to provide clkdev support to the CMT
> > > + * CMT device until it gets moved to DT.
> >
> > Minor nit: "CMT" repeated twice.
>
> I'll fix that. If no other change is required I won't repost the patch before
> sending the pull request.
>
> --
> Regards,
>
> Laurent Pinchart
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 0/3] ARM: shmobile: Lager reference serial port support
2013-10-29 15:23 [PATCH 0/3] ARM: shmobile: Lager reference serial port support Laurent Pinchart
` (2 preceding siblings ...)
2013-10-29 15:23 ` [PATCH 3/3] ARM: shmobile: lager: Enable SCIF0 and SCIF1 serial ports in DT Laurent Pinchart
@ 2013-10-31 5:31 ` Simon Horman
2013-10-31 12:21 ` Laurent Pinchart
3 siblings, 1 reply; 10+ messages in thread
From: Simon Horman @ 2013-10-31 5:31 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Oct 29, 2013 at 04:23:10PM +0100, Laurent Pinchart wrote:
> Hello,
>
> This patch set implements serial port support for the Lager reference board,
> and adds early debugging support for the r8a7790 SoC.
>
> The code is available in my git tree at
>
> git://linuxtv.org/pinchartl/fbdev.git clocks/ccf/serial-lager
>
> The branch is based on a merge of renesas-devel-20131016, v3.12-rc7 and
> multiarch drivers, clk-prepare, r8a7790 CCF and sh-sci OF patches I've posted
> earlier today.
>
> Laurent Pinchart (3):
> ARM: shmobile: r8a7790: Add early debugging support
The patch above could be applied now, right?
If so, Magnus, could you review it?
> ARM: shmobile: r8a7790: Add serial ports to the device tree
> ARM: shmobile: lager: Enable SCIF0 and SCIF1 serial ports in DT
I would like to ask you to repost these patches once their
pre-requisites have been merged.
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH 0/3] ARM: shmobile: Lager reference serial port support
2013-10-31 5:31 ` [PATCH 0/3] ARM: shmobile: Lager reference serial port support Simon Horman
@ 2013-10-31 12:21 ` Laurent Pinchart
2013-11-01 0:16 ` Simon Horman
0 siblings, 1 reply; 10+ messages in thread
From: Laurent Pinchart @ 2013-10-31 12:21 UTC (permalink / raw)
To: linux-arm-kernel
Hi Simon,
On Thursday 31 October 2013 14:31:44 Simon Horman wrote:
> On Tue, Oct 29, 2013 at 04:23:10PM +0100, Laurent Pinchart wrote:
> > Hello,
> >
> > This patch set implements serial port support for the Lager reference
> > board, and adds early debugging support for the r8a7790 SoC.
> >
> > The code is available in my git tree at
> >
> > git://linuxtv.org/pinchartl/fbdev.git clocks/ccf/serial-lager
> >
> > The branch is based on a merge of renesas-devel-20131016, v3.12-rc7 and
> > multiarch drivers, clk-prepare, r8a7790 CCF and sh-sci OF patches I've
> > posted earlier today.
> >
> > Laurent Pinchart (3):
> > ARM: shmobile: r8a7790: Add early debugging support
>
> The patch above could be applied now, right?
That's correct. It will be useless though, as DEBUG_LL can only be used on
multiarch.
Given that the SCIF/SCIFA/SCIFB port operate similarly, I wonder whether it
wouldn't make more sense to add a generic DEBUG_SHMOBILE_SCIF implementation
instead. We could then have sub-options to select the exact SoC type and port
number, and compute the base address from that.
> If so, Magnus, could you review it?
>
> > ARM: shmobile: r8a7790: Add serial ports to the device tree
> > ARM: shmobile: lager: Enable SCIF0 and SCIF1 serial ports in DT
>
> I would like to ask you to repost these patches once their
> pre-requisites have been merged.
Sure, no problem.
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 0/3] ARM: shmobile: Lager reference serial port support
2013-10-31 12:21 ` Laurent Pinchart
@ 2013-11-01 0:16 ` Simon Horman
0 siblings, 0 replies; 10+ messages in thread
From: Simon Horman @ 2013-11-01 0:16 UTC (permalink / raw)
To: linux-arm-kernel
[ CC Magnus ]
On Thu, Oct 31, 2013 at 01:21:23PM +0100, Laurent Pinchart wrote:
> Hi Simon,
>
> On Thursday 31 October 2013 14:31:44 Simon Horman wrote:
> > On Tue, Oct 29, 2013 at 04:23:10PM +0100, Laurent Pinchart wrote:
> > > Hello,
> > >
> > > This patch set implements serial port support for the Lager reference
> > > board, and adds early debugging support for the r8a7790 SoC.
> > >
> > > The code is available in my git tree at
> > >
> > > git://linuxtv.org/pinchartl/fbdev.git clocks/ccf/serial-lager
> > >
> > > The branch is based on a merge of renesas-devel-20131016, v3.12-rc7 and
> > > multiarch drivers, clk-prepare, r8a7790 CCF and sh-sci OF patches I've
> > > posted earlier today.
> > >
> > > Laurent Pinchart (3):
> > > ARM: shmobile: r8a7790: Add early debugging support
> >
> > The patch above could be applied now, right?
>
> That's correct. It will be useless though, as DEBUG_LL can only be used on
> multiarch.
I will wait, especially in the light of the point you raise below.
> Given that the SCIF/SCIFA/SCIFB port operate similarly, I wonder whether it
> wouldn't make more sense to add a generic DEBUG_SHMOBILE_SCIF implementation
> instead. We could then have sub-options to select the exact SoC type and port
> number, and compute the base address from that.
That makes a lot of sense to me.
Perhaps Magnus has an opinion?
> > If so, Magnus, could you review it?
> >
> > > ARM: shmobile: r8a7790: Add serial ports to the device tree
> > > ARM: shmobile: lager: Enable SCIF0 and SCIF1 serial ports in DT
> >
> > I would like to ask you to repost these patches once their
> > pre-requisites have been merged.
>
> Sure, no problem.
>
> --
> Regards,
>
> Laurent Pinchart
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 10+ messages in thread