From: oleg@redhat.com (Oleg Nesterov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 05/13] uprobes: add arch write opcode hook
Date: Sat, 2 Nov 2013 15:03:39 +0100 [thread overview]
Message-ID: <20131102140339.GA17575@redhat.com> (raw)
In-Reply-To: <52747280.7040708@linaro.org>
On 11/01, David Long wrote:
>
> On 10/29/13 15:59, Oleg Nesterov wrote:
>>
>> Or. arm can actually reimplement set_swbp(). This doesn't mean the
>> duplication of write_opcode() code, we can simply export this helper.
>>
>
> That actually looks to me like the cleanest approach. I have changed
> the static write_opcode() to a global uprobe_write_opcode(), and now
> call it from an arm set_swbp().
OK, great.
> Please do *not* make set_swbp() (and set_orig_insn()) static's. It
> looks like we now have a use for at least one of them.
I am not sure... it still seems to me it makes sense to cleanup this
interface...
But. I am not going to do this until we merge your changes. We will
see then.
Oleg.
next prev parent reply other threads:[~2013-11-02 14:03 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-15 21:04 [PATCH v2 00/13] uprobes: Add uprobes support for ARM David Long
2013-10-15 21:04 ` [PATCH v2 01/13] uprobes: move function declarations out of arch David Long
2013-11-05 16:01 ` Oleg Nesterov
2013-11-05 18:16 ` Oleg Nesterov
2013-11-05 19:01 ` [PATCH] uprobes: Export write_opcode() as uprobe_write_opcode() Oleg Nesterov
2013-11-05 19:55 ` David Long
2013-11-05 19:13 ` [PATCH v2 01/13] uprobes: move function declarations out of arch David Long
2013-10-15 21:04 ` [PATCH v2 02/13] uprobes: allow ignoring of probe hits David Long
2013-10-19 17:02 ` Oleg Nesterov
2013-10-22 3:45 ` David Long
2013-10-22 11:25 ` Oleg Nesterov
2013-10-22 23:56 ` David Long
2013-10-28 18:54 ` Oleg Nesterov
2013-10-30 21:11 ` David Long
2013-10-15 21:04 ` [PATCH v2 03/13] uprobes: allow arch access to xol slot David Long
2013-10-19 16:36 ` Oleg Nesterov
2013-10-23 0:03 ` David Long
2013-10-29 15:40 ` Oleg Nesterov
2013-11-04 19:49 ` [PATCH] uprobes: introduce arch_uprobe->ixol Oleg Nesterov
2013-11-04 21:25 ` David Long
2013-11-05 16:04 ` David Long
2013-11-05 18:01 ` Oleg Nesterov
2013-11-05 18:45 ` David Long
2013-10-15 21:04 ` [PATCH v2 04/13] uprobes: allow arch-specific initialization David Long
2013-10-19 16:42 ` Oleg Nesterov
2013-10-23 1:21 ` David Long
2013-10-28 18:58 ` Oleg Nesterov
2013-10-31 18:41 ` David Long
2013-11-01 13:52 ` Oleg Nesterov
2013-11-04 3:24 ` David Long
2013-10-15 21:04 ` [PATCH v2 05/13] uprobes: add arch write opcode hook David Long
2013-10-19 16:50 ` Oleg Nesterov
2013-10-23 18:20 ` David Long
2013-10-28 19:49 ` Oleg Nesterov
2013-10-29 19:59 ` Oleg Nesterov
2013-11-02 3:33 ` David Long
2013-11-02 14:03 ` Oleg Nesterov [this message]
2013-10-15 21:04 ` [PATCH v2 06/13] ARM: move shared uprobe/kprobe definitions into new include file David Long
2013-10-15 21:04 ` [PATCH v2 09/13] ARM: Disable jprobe selftests in thumb kernels David Long
2013-11-07 17:26 ` Jon Medhurst (Tixy)
2013-11-10 22:57 ` David Long
2013-10-15 21:04 ` [PATCH v2 10/13] kprobes: Remove uneeded kernel dependency on struct arch_specific_insn David Long
2013-11-13 17:13 ` Jon Medhurst (Tixy)
2013-11-14 2:02 ` Masami Hiramatsu
2013-11-14 14:15 ` Jon Medhurst (Tixy)
2013-11-14 20:33 ` David Long
2013-11-15 10:23 ` Masami Hiramatsu
2013-11-15 15:16 ` David Long
2013-11-15 10:11 ` Masami Hiramatsu
2013-11-14 1:20 ` Masami Hiramatsu
2013-10-15 21:04 ` [PATCH v2 11/13] ARM: Finish renaming ARM kprobes APIs for sharing with uprobes David Long
2013-11-13 17:16 ` Jon Medhurst (Tixy)
2013-11-15 15:45 ` David Long
2013-10-15 21:04 ` [PATCH v2 12/13] ARM: add uprobes support David Long
2013-10-15 21:04 ` [PATCH v2 13/13] ARM: Remove uprobes dependency on kprobes David Long
[not found] ` <1381871068-27660-8-git-send-email-dave.long@linaro.org>
2013-11-13 17:09 ` [PATCH v2 07/13] ARM: move generic thumb instruction parsing code to new files for use by other features Jon Medhurst (Tixy)
2013-11-14 14:13 ` David Long
[not found] ` <1381871068-27660-9-git-send-email-dave.long@linaro.org>
2013-11-13 17:11 ` [PATCH v2 08/13] ARM: use a function table for determining instruction interpreter actions Jon Medhurst (Tixy)
2013-11-14 15:17 ` David Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131102140339.GA17575@redhat.com \
--to=oleg@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).