From mboxrd@z Thu Jan 1 00:00:00 1970 From: shijie8@gmail.com (Huang Shijie) Date: Sun, 3 Nov 2013 16:32:40 -0500 Subject: [PATCH v2 08/27] mtd: nand: pxa3xx: Use chip->cmdfunc instead of the internal In-Reply-To: <1382137374-21251-9-git-send-email-ezequiel.garcia@free-electrons.com> References: <1382137374-21251-1-git-send-email-ezequiel.garcia@free-electrons.com> <1382137374-21251-9-git-send-email-ezequiel.garcia@free-electrons.com> Message-ID: <20131103213237.GB5896@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Oct 18, 2013 at 08:02:35PM -0300, Ezequiel Garcia wrote: > @@ -1011,14 +1011,16 @@ static void pxa3xx_nand_free_buff(struct pxa3xx_nand_info *info) > static int pxa3xx_nand_sensing(struct pxa3xx_nand_info *info) > { > struct mtd_info *mtd; > + struct nand_chip *chip; > int ret; Please add a empty line here. > mtd = info->host[info->cs]->mtd; > + chip = mtd->priv; > /* use the common timing to make a try */ > ret = pxa3xx_nand_config_flash(info, &builtin_flash_types[0]); > if (ret) > return ret; > > - pxa3xx_nand_cmdfunc(mtd, NAND_CMD_RESET, 0, 0); > + chip->cmdfunc(mtd, NAND_CMD_RESET, 0, 0); > if (info->is_ready) > return 0; Reviewed-by: Huang Shijie