Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: imx: removed unused MACH_MXLADS Kconfig parameter
Date: Mon, 4 Nov 2013 09:51:46 +0100	[thread overview]
Message-ID: <20131104085146.GT24559@pengutronix.de> (raw)
In-Reply-To: <1383542366-6270-1-git-send-email-michael.opdenacker@free-electrons.com>

On Mon, Nov 04, 2013 at 06:19:26AM +0100, Michael Opdenacker wrote:
> This removes the MACH_MXLADS Kconfig parameter,
> which was no longer used anywhere in the source code
> and Makefiles.

Hehe, this one is a bit tricky. Indeed MACH_MXLADS isn't used directly
anywhere. Nevertheless having CONFIG_MACH_MXLADS defined makes
machine_is_mxlads() become true when the kernel is started with a
machine id of 1851.

machine_is_mxlads() is unused in the kernel, so this patch indeed
doesn't hurt. Anyway, the code is correct currently, so I suggest
keeping it until the mx[1l]ads is either removed or converted to
devicetree.

Sascha


> 
> Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>
> ---
>  arch/arm/mach-imx/Kconfig | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
> index 29a8af6922a8..d84a772bbc68 100644
> --- a/arch/arm/mach-imx/Kconfig
> +++ b/arch/arm/mach-imx/Kconfig
> @@ -158,14 +158,11 @@ config	SOC_IMX51
>  if ARCH_MULTI_V4T
>  
>  comment "MX1 platforms:"
> -config MACH_MXLADS
> -	bool
>  
>  config ARCH_MX1ADS
>  	bool "MX1ADS platform"
>  	select IMX_HAVE_PLATFORM_IMX_I2C
>  	select IMX_HAVE_PLATFORM_IMX_UART
> -	select MACH_MXLADS
>  	select SOC_IMX1
>  	help
>  	  Say Y here if you are using Motorola MX1ADS/MXLADS boards
> -- 
> 1.8.1.2
> 
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  reply	other threads:[~2013-11-04  8:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-04  5:19 [PATCH] ARM: imx: removed unused MACH_MXLADS Kconfig parameter Michael Opdenacker
2013-11-04  8:51 ` Sascha Hauer [this message]
2013-11-04  9:00   ` Michael Opdenacker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131104085146.GT24559@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox