* [PATCH] ARM: footbridge: fix build warning
@ 2013-11-04 8:04 Linus Walleij
2013-11-04 11:42 ` Russell King - ARM Linux
0 siblings, 1 reply; 2+ messages in thread
From: Linus Walleij @ 2013-11-04 8:04 UTC (permalink / raw)
To: linux-arm-kernel
The raw spinlock in the netwinder GPIO implementation was using
non-raw accessors, fix this warning from the autobuilder:
arch/arm/mach-footbridge/netwinder-hw.c:695:2:
warning: passing argument 1 of 'spinlock_check' from
incompatible pointer type [enabled by default]
arch/arm/mach-footbridge/netwinder-hw.c:702:2:
warning: passing argument 1 of 'spin_unlock_irqrestore' from
incompatible pointer type [enabled by default]
arch/arm/mach-footbridge/netwinder-hw.c:712:2:
warning: passing argument 1 of 'spinlock_check' from
incompatible pointer type [enabled by default]
arch/arm/mach-footbridge/netwinder-hw.c:714:2:
warning: passing argument 1 of 'spin_unlock_irqrestore' from
incompatible pointer type [enabled by default]
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
ARM SoC folks: please apply this directly to fixes.
---
| 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
--git a/arch/arm/mach-footbridge/netwinder-hw.c b/arch/arm/mach-footbridge/netwinder-hw.c
index 1fd2cf097e30..eb1fa5c84723 100644
--- a/arch/arm/mach-footbridge/netwinder-hw.c
+++ b/arch/arm/mach-footbridge/netwinder-hw.c
@@ -692,14 +692,14 @@ static void netwinder_led_set(struct led_classdev *cdev,
unsigned long flags;
u32 reg;
- spin_lock_irqsave(&nw_gpio_lock, flags);
+ raw_spin_lock_irqsave(&nw_gpio_lock, flags);
reg = nw_gpio_read();
if (b != LED_OFF)
reg &= ~led->mask;
else
reg |= led->mask;
nw_gpio_modify_op(led->mask, reg);
- spin_unlock_irqrestore(&nw_gpio_lock, flags);
+ raw_spin_unlock_irqrestore(&nw_gpio_lock, flags);
}
static enum led_brightness netwinder_led_get(struct led_classdev *cdev)
@@ -709,9 +709,9 @@ static enum led_brightness netwinder_led_get(struct led_classdev *cdev)
unsigned long flags;
u32 reg;
- spin_lock_irqsave(&nw_gpio_lock, flags);
+ raw_spin_lock_irqsave(&nw_gpio_lock, flags);
reg = nw_gpio_read();
- spin_unlock_irqrestore(&nw_gpio_lock, flags);
+ raw_spin_unlock_irqrestore(&nw_gpio_lock, flags);
return (reg & led->mask) ? LED_OFF : LED_FULL;
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] ARM: footbridge: fix build warning
2013-11-04 8:04 [PATCH] ARM: footbridge: fix build warning Linus Walleij
@ 2013-11-04 11:42 ` Russell King - ARM Linux
0 siblings, 0 replies; 2+ messages in thread
From: Russell King - ARM Linux @ 2013-11-04 11:42 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Nov 04, 2013 at 09:04:56AM +0100, Linus Walleij wrote:
> The raw spinlock in the netwinder GPIO implementation was using
> non-raw accessors, fix this warning from the autobuilder:
I've already got this in my tree. Thanks anyway.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-11-04 11:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-04 8:04 [PATCH] ARM: footbridge: fix build warning Linus Walleij
2013-11-04 11:42 ` Russell King - ARM Linux
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).