From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: mm: get_user_pages_fast()
Date: Wed, 6 Nov 2013 10:54:00 +0000 [thread overview]
Message-ID: <20131106105400.GV16735@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <52797483.2000105@cs.bris.ac.uk>
On Tue, Nov 05, 2013 at 10:43:15PM +0000, Michael McTernan wrote:
> I think there's a problem on ARM with futex calls to FUTEX_WAIT and
> similar for addresses that have been mapped to userspace from /dev/mem
> or a device which sets VM_IO or VM_PFNMAP. This can break
> pthread_mutex_lock() if placed on such mapped memory and attributed as
> process-shared.
Firstly, please stop this madness. Placing futexes in IO memory is not
supported, period. You can't map random bits of /dev/mem and expect
this stuff to work.
(a) you're generally not allowed to map kernel memory via /dev/mem, so
that rules out all kernel managed memory.
(b) you are allowed to map memory outside of that, but you get it as
strongly ordered memory.
(b) means that the load/store exclusives, which userspace mutexes will
use on ARMv6+, will not work correctly. (they're not supported to
strongly ordered memory by the architecture.)
In other words, don't put mutexes in memory you've remapped from /dev/mem.
In fact, as an application, you should not be mapping /dev/mem at all.
next prev parent reply other threads:[~2013-11-06 10:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-05 22:43 mm: get_user_pages_fast() Michael McTernan
2013-11-06 10:19 ` Will Deacon
2013-11-06 10:54 ` Russell King - ARM Linux [this message]
2013-11-06 11:07 ` Will Deacon
2013-11-06 19:38 ` Michael McTernan
2013-11-06 19:57 ` Russell King - ARM Linux
2013-11-06 22:31 ` Michael McTernan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131106105400.GV16735@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox