From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: enable EDAC on arm64
Date: Wed, 6 Nov 2013 15:26:09 +0000 [thread overview]
Message-ID: <20131106152608.GD979@arm.com> (raw)
In-Reply-To: <1383742944-28059-1-git-send-email-robherring2@gmail.com>
On Wed, Nov 06, 2013 at 01:02:24PM +0000, Rob Herring wrote:
> +static inline void atomic_scrub(void *va, u32 size)
> +{
> + unsigned int *virt_addr = va;
> + unsigned int temp, temp2;
> + unsigned int i;
> +
> + for (i = 0; i < size / sizeof(*virt_addr); i++, virt_addr++) {
> + /*
> + * No need to check for store failure, another write means
> + * the scrubbing has effectively already been done for us.
> + */
> + asm volatile("\n"
> + " ldxr %0, %2\n"
> + " stxr %w1, %0, %2\n"
> + : "=&r" (temp), "=&r" (temp2), "+Q" (virt_addr)
> + : : "cc");
But failure of stxr does not necessarily mean another write. It can be
an interrupt, cache line migration etc. The exclusive monitor can be
emulated in many ways.
BTW, can you not use 64-bit loads/stores?
--
Catalin
next prev parent reply other threads:[~2013-11-06 15:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-06 13:02 [PATCH] arm64: enable EDAC on arm64 Rob Herring
2013-11-06 15:26 ` Catalin Marinas [this message]
2013-11-06 18:39 ` Rob Herring
2013-11-07 9:47 ` Catalin Marinas
2013-11-07 9:51 ` Will Deacon
2013-11-07 14:22 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131106152608.GD979@arm.com \
--to=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).