linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: mvebu: second PCIe unit of Armada XP mv78230 is only x1 capable
Date: Wed, 6 Nov 2013 15:43:26 +0100	[thread overview]
Message-ID: <20131106154326.27a4cc27@skate> (raw)
In-Reply-To: <b5f36f547bb12ed4e5398401685523625ca50312.1383681717.git.arno@natisbad.org>

Dear Arnaud Ebalard,

On Tue, 05 Nov 2013 21:45:48 +0100, Arnaud Ebalard wrote:
> Various Marvell datasheets advertise second PCIe unit of mv78230
> flavour of Armada XP as x4/quad x1 capable. This second unit is in
> fact only x1 capable. This patch fixes current mv78230 .dtsi to
> reflect that, i.e. makes 1.0 the second interface (instead of 2.0
> at the moment). This was successfully tested on a mv78230-based
> ReadyNAS 2120 platform with a x1 device (FL1009 XHCI controller)
> connected to this second interface.
> 
> Signed-off-by: Arnaud Ebalard <arno@natisbad.org>
> ---
>  arch/arm/boot/dts/armada-xp-mv78230.dtsi | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)

Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

This is actually a bug fix, and the problem exists since commit
9d8f44f02d4a5f6e7b8d138ea8f8c6e30ae6e1a3, and therefore in 3.10, 3.11
and 3.12.

However, while the PCIe DT stuff was merged in 3.10, the actual driver
itself was only merged in 3.11, so in 3.10, there is no chance to hit
the bug.

Therefore, having this fix pushed to the stable 3.11.x and 3.12.x trees
would be good.

Thanks Arnaud for following up on this!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2013-11-06 14:43 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-05 20:45 [PATCH 0/2] ARM: mvebu: fix DT def. of PCIe units for mv78230 and mv78260 Arnaud Ebalard
2013-11-05 20:45 ` [PATCH 1/2] ARM: mvebu: second PCIe unit of Armada XP mv78230 is only x1 capable Arnaud Ebalard
2013-11-06 14:43   ` Thomas Petazzoni [this message]
2013-11-06 18:08     ` Arnaud Ebalard
2013-11-06 18:12       ` Jason Cooper
2013-11-06 18:20         ` Thomas Petazzoni
2013-11-21 23:28         ` Arnaud Ebalard
2013-11-22 13:44           ` Jason Cooper
2013-11-22 14:28             ` Thomas Petazzoni
2013-11-05 20:46 ` [PATCH 2/2] ARM: mvebu: fix second and third PCIe unit of Armada XP mv78260 Arnaud Ebalard
2013-11-06 14:54   ` Thomas Petazzoni
2013-11-06 18:14 ` [PATCH 0/2] ARM: mvebu: fix DT def. of PCIe units for mv78230 and mv78260 Arnaud Ebalard
2013-11-06 18:22   ` Thomas Petazzoni
2013-11-06 18:37     ` Jason Gunthorpe
2013-11-06 20:08       ` Arnaud Ebalard
2013-11-06 20:55       ` Jason Cooper
2013-11-06 21:32         ` Arnaud Ebalard
2013-11-22 15:04 ` Jason Cooper
2013-11-22 15:29   ` Arnaud Ebalard
2013-11-23 15:36 ` Jason Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131106154326.27a4cc27@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).