From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: mfd: ab8500-debug: Add wake-up info
Date: Fri, 8 Nov 2013 09:20:25 +0000 [thread overview]
Message-ID: <20131108092025.GS30901@lee--X1> (raw)
In-Reply-To: <20131107134326.GO20521@mwanda>
> What ever happened to this? Can "desc" be NULL or not?
You'll be lucky to get a response. ST-Ericsson are quite dead.
However, from my investigation it appears desc 'can' be NULL.
> On Mon, Aug 26, 2013 at 06:09:08PM +0300, Dan Carpenter wrote:
> > Hello Jonas Aaberg,
> >
> > This is a semi-automatic email about new static checker warnings.
> >
> > The patch 2cf64e264828: "mfd: ab8500-debug: Add wake-up info" from
> > May 31, 2012, leads to the following Smatch complaint:
> >
> > drivers/mfd/ab8500-debugfs.c:1609 ab8500_interrupts_print()
> > warn: variable dereferenced before check 'desc' (see line 1603)
> >
> > drivers/mfd/ab8500-debugfs.c
> > 1602 struct irq_desc *desc = irq_to_desc(line + irq_first);
> > 1603 struct irqaction *action = desc->action;
> > ^^^^^^^^^^^^
> > Patch adds dereference.
> >
> > 1604
> > 1605 seq_printf(s, "%3i: %6i %4i", line,
> > 1606 num_interrupts[line],
> > 1607 num_wake_interrupts[line]);
> > 1608
> > 1609 if (desc && desc->name)
> > ^^^^
> > Patch adds check.
> >
> > 1610 seq_printf(s, "-%-8s", desc->name);
> > 1611 if (action) {
> >
> > regards,
> > dan carpenter
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2013-11-08 9:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20130826150908.GB12428@elgon.mountain>
2013-11-07 13:43 ` mfd: ab8500-debug: Add wake-up info Dan Carpenter
2013-11-08 9:20 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131108092025.GS30901@lee--X1 \
--to=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).