linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/2] genirq: arm64: perf: support for percpu pmu interrupt
Date: Mon, 11 Nov 2013 10:44:32 +0000	[thread overview]
Message-ID: <20131111104432.GA28302@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <527D8A17.9020208@codeaurora.org>

On Sat, Nov 09, 2013 at 01:04:23AM +0000, Stephen Boyd wrote:
> On 11/06/13 04:07, Vinayak Kale wrote:
> > This patch series adds support to handle interrupt registration/deregistration
> > in arm64 pmu driver when pmu interrupt type is percpu.
> >
> > Patches in this patch series were previously sent out as separate patches [1].
> > This patch series incorporates comments/fixes suggested for original patches.
> >
> > [1] 
> > http://lists.infradead.org/pipermail/linux-arm-kernel/2013-October/205888.html
> > http://lists.infradead.org/pipermail/linux-arm-kernel/2013-October/204414.html 
> >
> > Vinayak Kale (2):
> >   genirq: error reporting in request_percpu_irq() and
> >     request_threaded_irq()
> >   arm64: perf: add support for percpu pmu interrupt
> >
> >  arch/arm64/kernel/perf_event.c |  109 +++++++++++++++++++++++++++++-----------
> >  kernel/irq/manage.c            |   12 +++--
> >  2 files changed, 89 insertions(+), 32 deletions(-)
> >
> 
> What ever happened to the approach here[1]? It doesn't look very nice to
> have to request the irq first as a per-cpu interrupt and then try as a
> non-percpu interrupt when genirq already knows if its per-cpu or not.
> 
> [1] http://lkml.indiana.edu/hypermail/linux/kernel/1207.3/02955.html

Hmm, I'd completely forgotten about that approach. Whilst it certainly looks
cleaner from a user perspective, I always get scared when I see
'desc->status_use_accessors' since it tends to incur the wrath of tglx :)

That said, I guess that should be fine in irqdesc.h (basically adding a new
accessor). Chris went missing after sending those initial patches, so
perhaps Vinayak could look at resurrecting those?

Will

  parent reply	other threads:[~2013-11-11 10:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-06 12:07 [PATCH 0/2] genirq: arm64: perf: support for percpu pmu interrupt Vinayak Kale
2013-11-06 12:07 ` [PATCH 1/2] genirq: error reporting in request_percpu_irq() and request_threaded_irq() Vinayak Kale
2013-11-06 12:07 ` [PATCH 2/2] arm64: perf: add support for percpu pmu interrupt Vinayak Kale
2013-11-08 15:57   ` Will Deacon
2013-11-11  9:30     ` Vinayak Kale
2013-11-09  1:04   ` Stephen Boyd
2013-11-09  1:04 ` [PATCH 0/2] genirq: arm64: perf: " Stephen Boyd
2013-11-11  9:25   ` Vinayak Kale
2013-11-11 10:44   ` Will Deacon [this message]
2013-11-11 12:33     ` Ganapat Rao P Kulkarni
2013-11-12  6:00     ` Vinayak Kale
2013-11-12  8:31       ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131111104432.GA28302@mudshark.cambridge.arm.com \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).