linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: signal: fix armv7-m build issue in sigreturn_codes.S
@ 2013-11-11  8:10 Victor Kamensky
  2013-11-11  8:10 ` Victor Kamensky
  2013-11-11  9:33 ` Uwe Kleine-König
  0 siblings, 2 replies; 8+ messages in thread
From: Victor Kamensky @ 2013-11-11  8:10 UTC (permalink / raw)
  To: linux-arm-kernel

Hi,

Here is proposal for armv7-m build failure in sigreturn_codes.S. The 
armv7-m build issue was discussed in [1].

Proposed solution is based on conditional compilation. If 
CONFIG_CPU_THUMBONLY is set instead of arm opcodes nops in thumb mode
are used. I've tried to wrap conditional compilation as nice as I 
found possible. Other suggestions/approaches are welcome.

Fix was tested:
   linux-next with efm32_defconfig build (along with few other fixes)
   rmk-next BE/LE arndale build/boot and LTP rt_sigaction0? tests run

Uwe, is it possible for you to test that the fix runs on efm32. Also
if the platform can run LTP, you give a spin to LTP rt_sigaction0? 
tests that would be great. It is known that this tests covers code 
under change.

If folks don't like this fix, I have another variant as I mention
in [1] that backs out 574e2b5111e13827da501771b27d92e6e3f2e3d7 
(ARM: signal: sigreturn_codes should be endian neutral to work in BE8)
and use asm/opcodes to byteswap manually crafted instructions.

Thanks,
Victor

[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2013-November/209334.html

Victor Kamensky (1):
  ARM: signal: fix armv7-m build issue in sigreturn_codes.S

 arch/arm/kernel/sigreturn_codes.S | 25 ++++++++++++++++++-------
 1 file changed, 18 insertions(+), 7 deletions(-)

-- 
1.8.1.4

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2013-11-19  6:55 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-11  8:10 [PATCH] ARM: signal: fix armv7-m build issue in sigreturn_codes.S Victor Kamensky
2013-11-11  8:10 ` Victor Kamensky
2013-11-11 10:51   ` Will Deacon
2013-11-12  6:51     ` Victor Kamensky
2013-11-18 13:39   ` Dave Martin
2013-11-19  6:55     ` Victor Kamensky
2013-11-11  9:33 ` Uwe Kleine-König
2013-11-11 16:55   ` Uwe Kleine-König

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).