From: eric@eukrea.com (Eric Bénard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv3 3/8] staging: imx-drm: ipuv3-crtc: don't harcode some mode flags.
Date: Wed, 13 Nov 2013 08:50:32 +0100 [thread overview]
Message-ID: <20131113085032.5be4bc4b@e6520eb> (raw)
In-Reply-To: <CAOMZO5ASDO22eHVLn18dQ31TJEjemtGp+SQqHk9XtYj6Hx3aLg@mail.gmail.com>
Hi Fabio,
Le Wed, 13 Nov 2013 01:52:25 -0200,
Fabio Estevam <festevam@gmail.com> a ?crit :
> On Tue, Nov 12, 2013 at 2:49 PM, Denis Carikli <denis@eukrea.com> wrote:
> > + if (mode->flags & DRM_MODE_FLAG_DE_HIGH)
> > + sig_cfg.enable_pol = 1;
> > + if (mode->flags & DRM_MODE_FLAG_PIXDATA_POSEDGE)
> > + sig_cfg.clk_pol = 1;
> >
> > - sig_cfg.enable_pol = 1;
> > - sig_cfg.clk_pol = 1;
>
>
> What are the sig_cfg.enable_pol and sig_cfg.clk_pol values you need
> for your display to operate correctly?
in ipuv3-crtc, line 159 :
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/staging/imx-drm/ipuv3-crtc.c#n159
polarity of the enable signal and the pixel clock are hard coded to 1.
These settings are then used in ipu-di.c to configurer the IPU display
interface :
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/staging/imx-drm/ipu-v3/ipu-di.c#n631
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/staging/imx-drm/ipu-v3/ipu-di.c#n642
This is a problem as the polarity of these signals can vary from one
TFT panel to an other. In our case, we need and active low enable and a
negative edge clock but currently there is no way to configure these
settings in ipuv3-crtc as they are hardcoded to 1 : that's what Denis
is trying to fix.
Eric
next prev parent reply other threads:[~2013-11-13 7:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-12 16:49 [PATCHv3 1/8] drm: Add the lacking DRM_MODE_FLAG_* for matching the DISPLAY_FLAGS_* Denis Carikli
2013-11-12 16:49 ` [PATCHv3 2/8] [media] v4l2: add new V4L2_PIX_FMT_RGB666 pixel format Denis Carikli
2013-11-13 2:47 ` Laurent Pinchart
2013-11-12 16:49 ` [PATCHv3 3/8] staging: imx-drm: ipuv3-crtc: don't harcode some mode flags Denis Carikli
2013-11-13 3:52 ` Fabio Estevam
2013-11-13 7:50 ` Eric Bénard [this message]
2013-11-12 16:49 ` [PATCHv3 4/8] staging: imx-drm: Add RGB666 support for parallel display Denis Carikli
2013-11-12 17:04 ` [PATCHv3 1/8] drm: Add the lacking DRM_MODE_FLAG_* for matching the DISPLAY_FLAGS_* Russell King - ARM Linux
2013-11-13 7:53 ` Eric Bénard
2013-11-13 9:05 ` Philipp Zabel
2013-11-13 9:41 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131113085032.5be4bc4b@e6520eb \
--to=eric@eukrea.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).