[alsa-devel] [PATCH] ASoC: fsl-ssi: fix SDMA starvation

[mpa@pengutronix.de (Markus Pargmann)]

On Wed, Nov 13, 2013 at 07:10:49AM -0600, Timur Tabi wrote:
> Markus Pargmann wrote:
> >>>Can you change the code so that the interrupts are enabled only on
> >>>i.MX?  On PowerPC, the interrupts are used only for debugging.
> 
> >Why is this necessary? The interrupts were enabled for all
> >architectures before.
> 
> My concern is with these lines:
> 
> 	write_ssi_mask(&ssi->sier, 0, CCSR_SSI_SIER_TDMAE);
> ...
> 	write_ssi_mask(&ssi->sier, CCSR_SSI_SIER_TDMAE, 0);
> 
> This toggles the TDMAE interrupt on PowerPC, which I believe is
> VITAL to making it work.  The SSI and the DMA controller talk to
> each other automatically, and if I'm reading the documentation
> correctly, that communication depends on TDMAE and RDMAE.

Is it necessary to keep TDMAE enabled the whole time? In the patch we
enable it when playback starts and disable when it stops, so the
communication between DMA and SSI shouldn't be disturbed.

Regards,

Markus

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |