From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [patch] pinctrl: rockchip: missing unlock on error in rockchip_set_pull()
Date: Thu, 14 Nov 2013 16:51:45 +0100 [thread overview]
Message-ID: <201311141651.45966.heiko@sntech.de> (raw)
In-Reply-To: <20131114082254.GE8150@elgon.mountain>
Am Donnerstag, 14. November 2013, 09:22:54 schrieb Dan Carpenter:
> We need to unlock here before returning -EINVAL.
I seem to say this a lot recently: thanks for the catch :-)
> Fixes: 6ca5274d1d12 ('pinctrl: rockchip: add rk3188 specifics')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Heiko Stuebner <heiko@sntech.de>
> diff --git a/drivers/pinctrl/pinctrl-rockchip.c
> b/drivers/pinctrl/pinctrl-rockchip.c index e939c28..bfd1824 100644
> --- a/drivers/pinctrl/pinctrl-rockchip.c
> +++ b/drivers/pinctrl/pinctrl-rockchip.c
> @@ -504,6 +504,7 @@ static int rockchip_set_pull(struct rockchip_pin_bank
> *bank, data |= (3 << bit);
> break;
> default:
> + spin_unlock_irqrestore(&bank->slock, flags);
> dev_err(info->dev, "unsupported pull setting %d\n",
> pull);
> return -EINVAL;
next prev parent reply other threads:[~2013-11-14 15:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-14 8:22 [patch] pinctrl: rockchip: missing unlock on error in rockchip_set_pull() Dan Carpenter
2013-11-14 15:51 ` Heiko Stübner [this message]
2013-11-19 8:39 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201311141651.45966.heiko@sntech.de \
--to=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox