* [PATCH -next] tree-wide: add missing clk_disable_unprepare() on error in wmt_i2c_reset_hardware()
@ 2013-11-11 14:23 Wei Yongjun
2013-11-14 17:40 ` Wolfram Sang
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2013-11-11 14:23 UTC (permalink / raw)
To: linux-arm-kernel
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Add the missing clk_disable_unprepare() before return
from wmt_i2c_reset_hardware() in the error handling case.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/i2c/busses/i2c-wmt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/i2c/busses/i2c-wmt.c b/drivers/i2c/busses/i2c-wmt.c
index 31395fa..2c8a3e4 100644
--- a/drivers/i2c/busses/i2c-wmt.c
+++ b/drivers/i2c/busses/i2c-wmt.c
@@ -349,6 +349,7 @@ static int wmt_i2c_reset_hardware(struct wmt_i2c_dev *i2c_dev)
err = clk_set_rate(i2c_dev->clk, 20000000);
if (err) {
dev_err(i2c_dev->dev, "failed to set clock = 20Mhz\n");
+ clk_disable_unprepare(i2c_dev->clk);
return err;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH -next] tree-wide: add missing clk_disable_unprepare() on error in wmt_i2c_reset_hardware()
2013-11-11 14:23 [PATCH -next] tree-wide: add missing clk_disable_unprepare() on error in wmt_i2c_reset_hardware() Wei Yongjun
@ 2013-11-14 17:40 ` Wolfram Sang
0 siblings, 0 replies; 2+ messages in thread
From: Wolfram Sang @ 2013-11-14 17:40 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Nov 11, 2013 at 10:23:50PM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Add the missing clk_disable_unprepare() before return
> from wmt_i2c_reset_hardware() in the error handling case.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Applied to for-next, thanks! Yet, the subject line is really
non-standard (i.e. broken). Should be "i2c: wmt: ..."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131114/379287fe/attachment.sig>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-11-14 17:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-11 14:23 [PATCH -next] tree-wide: add missing clk_disable_unprepare() on error in wmt_i2c_reset_hardware() Wei Yongjun
2013-11-14 17:40 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).