* [PATCH] ARM: nommu: Include asm/procinfo.h to fix build warning
@ 2013-11-15 3:38 Axel Lin
2013-11-15 7:14 ` Olof Johansson
2013-11-15 9:01 ` Thierry Reding
0 siblings, 2 replies; 4+ messages in thread
From: Axel Lin @ 2013-11-15 3:38 UTC (permalink / raw)
To: linux-arm-kernel
Include asm/procinfo.h to fix below build warning:
CC arch/arm/mm/nommu.o
arch/arm/mm/nommu.c:303:17: warning: 'struct proc_info_list' declared inside parameter list [enabled by default]
arch/arm/mm/nommu.c:303:17: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
arch/arm/mm/nommu.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mm/nommu.c b/arch/arm/mm/nommu.c
index 5c668b7..55764a7 100644
--- a/arch/arm/mm/nommu.c
+++ b/arch/arm/mm/nommu.c
@@ -18,6 +18,7 @@
#include <asm/mach/arch.h>
#include <asm/cputype.h>
#include <asm/mpu.h>
+#include <asm/procinfo.h>
#include "mm.h"
--
1.8.1.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ARM: nommu: Include asm/procinfo.h to fix build warning
2013-11-15 3:38 [PATCH] ARM: nommu: Include asm/procinfo.h to fix build warning Axel Lin
@ 2013-11-15 7:14 ` Olof Johansson
2013-11-15 11:36 ` Russell King - ARM Linux
2013-11-15 9:01 ` Thierry Reding
1 sibling, 1 reply; 4+ messages in thread
From: Olof Johansson @ 2013-11-15 7:14 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Nov 14, 2013 at 7:38 PM, Axel Lin <axel.lin@ingics.com> wrote:
> Include asm/procinfo.h to fix below build warning:
> CC arch/arm/mm/nommu.o
> arch/arm/mm/nommu.c:303:17: warning: 'struct proc_info_list' declared inside parameter list [enabled by default]
> arch/arm/mm/nommu.c:303:17: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
This is identical to the patch I posted a day earlier, that I just
sent to Russell's patch tracker. :)
-Olof
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: nommu: Include asm/procinfo.h to fix build warning
2013-11-15 7:14 ` Olof Johansson
@ 2013-11-15 11:36 ` Russell King - ARM Linux
0 siblings, 0 replies; 4+ messages in thread
From: Russell King - ARM Linux @ 2013-11-15 11:36 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Nov 14, 2013 at 11:14:11PM -0800, Olof Johansson wrote:
> On Thu, Nov 14, 2013 at 7:38 PM, Axel Lin <axel.lin@ingics.com> wrote:
> > Include asm/procinfo.h to fix below build warning:
> > CC arch/arm/mm/nommu.o
> > arch/arm/mm/nommu.c:303:17: warning: 'struct proc_info_list' declared inside parameter list [enabled by default]
> > arch/arm/mm/nommu.c:303:17: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
> >
> > Signed-off-by: Axel Lin <axel.lin@ingics.com>
>
> This is identical to the patch I posted a day earlier, that I just
> sent to Russell's patch tracker. :)
And I probably have a near identical patch which I committed yesterday
morning.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: nommu: Include asm/procinfo.h to fix build warning
2013-11-15 3:38 [PATCH] ARM: nommu: Include asm/procinfo.h to fix build warning Axel Lin
2013-11-15 7:14 ` Olof Johansson
@ 2013-11-15 9:01 ` Thierry Reding
1 sibling, 0 replies; 4+ messages in thread
From: Thierry Reding @ 2013-11-15 9:01 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Nov 15, 2013 at 11:38:00AM +0800, Axel Lin wrote:
> Include asm/procinfo.h to fix below build warning:
> CC arch/arm/mm/nommu.o
> arch/arm/mm/nommu.c:303:17: warning: 'struct proc_info_list' declared inside parameter list [enabled by default]
> arch/arm/mm/nommu.c:303:17: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> arch/arm/mm/nommu.c | 1 +
> 1 file changed, 1 insertion(+)
Interesting, I didn't see those at the time when writing the patch.
Perhaps some reordering of includes subsequently caused this to happen?
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131115/cf0b6c13/attachment-0001.sig>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-11-15 11:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-15 3:38 [PATCH] ARM: nommu: Include asm/procinfo.h to fix build warning Axel Lin
2013-11-15 7:14 ` Olof Johansson
2013-11-15 11:36 ` Russell King - ARM Linux
2013-11-15 9:01 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).