[PATCH] ARM: nommu: Include asm/procinfo.h to fix build warning

[PATCH] ARM: nommu: Include asm/procinfo.h to fix build warning

[Axel Lin]

Include asm/procinfo.h to fix below build warning:
  CC      arch/arm/mm/nommu.o
arch/arm/mm/nommu.c:303:17: warning: 'struct proc_info_list' declared inside parameter list [enabled by default]
arch/arm/mm/nommu.c:303:17: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 arch/arm/mm/nommu.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mm/nommu.c b/arch/arm/mm/nommu.c
index 5c668b7..55764a7 100644
--- a/arch/arm/mm/nommu.c
+++ b/arch/arm/mm/nommu.c
@@ -18,6 +18,7 @@
 #include <asm/mach/arch.h>
 #include <asm/cputype.h>
 #include <asm/mpu.h>
+#include <asm/procinfo.h>
 
 #include "mm.h"
 
-- 
1.8.1.2

[PATCH] ARM: nommu: Include asm/procinfo.h to fix build warning

[Olof Johansson]

On Thu, Nov 14, 2013 at 7:38 PM, Axel Lin <axel.lin@ingics.com> wrote:
> Include asm/procinfo.h to fix below build warning:
>   CC      arch/arm/mm/nommu.o
> arch/arm/mm/nommu.c:303:17: warning: 'struct proc_info_list' declared inside parameter list [enabled by default]
> arch/arm/mm/nommu.c:303:17: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>

This is identical to the patch I posted a day earlier, that I just
sent to Russell's patch tracker. :)


-Olof

[PATCH] ARM: nommu: Include asm/procinfo.h to fix build warning

[Thierry Reding]

On Fri, Nov 15, 2013 at 11:38:00AM +0800, Axel Lin wrote:
> Include asm/procinfo.h to fix below build warning:
>   CC      arch/arm/mm/nommu.o
> arch/arm/mm/nommu.c:303:17: warning: 'struct proc_info_list' declared inside parameter list [enabled by default]
> arch/arm/mm/nommu.c:303:17: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
> 
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
>  arch/arm/mm/nommu.c | 1 +
>  1 file changed, 1 insertion(+)

Interesting, I didn't see those at the time when writing the patch.
Perhaps some reordering of includes subsequently caused this to happen?

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131115/cf0b6c13/attachment-0001.sig>

[PATCH] ARM: nommu: Include asm/procinfo.h to fix build warning

[Russell King - ARM Linux]

On Thu, Nov 14, 2013 at 11:14:11PM -0800, Olof Johansson wrote:
> On Thu, Nov 14, 2013 at 7:38 PM, Axel Lin <axel.lin@ingics.com> wrote:
> > Include asm/procinfo.h to fix below build warning:
> >   CC      arch/arm/mm/nommu.o
> > arch/arm/mm/nommu.c:303:17: warning: 'struct proc_info_list' declared inside parameter list [enabled by default]
> > arch/arm/mm/nommu.c:303:17: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
> >
> > Signed-off-by: Axel Lin <axel.lin@ingics.com>
> 
> This is identical to the patch I posted a day earlier, that I just
> sent to Russell's patch tracker. :)

And I probably have a near identical patch which I committed yesterday
morning.