linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] iommu/arm-smmu: fix error return code in arm_smmu_device_dt_probe()
@ 2013-11-15  9:42 Wei Yongjun
  2013-11-15 12:48 ` Will Deacon
  0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2013-11-15  9:42 UTC (permalink / raw)
  To: linux-arm-kernel

From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

Fix to return -ENODEV instead of 0 when context interrupt number
does no match in arm_smmu_device_dt_probe().

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
 drivers/iommu/arm-smmu.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
index 2349d62..2bc977b 100644
--- a/drivers/iommu/arm-smmu.c
+++ b/drivers/iommu/arm-smmu.c
@@ -1858,6 +1858,7 @@ static int arm_smmu_device_dt_probe(struct platform_device *pdev)
 		dev_err(dev,
 			"found only %d context interrupt(s) but %d required\n",
 			smmu->num_context_irqs, smmu->num_context_banks);
+		err = -ENODEV;
 		goto out_put_parent;
 	}
 

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH -next] iommu/arm-smmu: fix error return code in arm_smmu_device_dt_probe()
  2013-11-15  9:42 [PATCH -next] iommu/arm-smmu: fix error return code in arm_smmu_device_dt_probe() Wei Yongjun
@ 2013-11-15 12:48 ` Will Deacon
  0 siblings, 0 replies; 2+ messages in thread
From: Will Deacon @ 2013-11-15 12:48 UTC (permalink / raw)
  To: linux-arm-kernel

On Fri, Nov 15, 2013 at 09:42:30AM +0000, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> 
> Fix to return -ENODEV instead of 0 when context interrupt number
> does no match in arm_smmu_device_dt_probe().
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
>  drivers/iommu/arm-smmu.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
> index 2349d62..2bc977b 100644
> --- a/drivers/iommu/arm-smmu.c
> +++ b/drivers/iommu/arm-smmu.c
> @@ -1858,6 +1858,7 @@ static int arm_smmu_device_dt_probe(struct platform_device *pdev)
>  		dev_err(dev,
>  			"found only %d context interrupt(s) but %d required\n",
>  			smmu->num_context_irqs, smmu->num_context_banks);
> +		err = -ENODEV;
>  		goto out_put_parent;
>  	}

Applied to my devel branch. Thanks!

Will

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-11-15 12:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-15  9:42 [PATCH -next] iommu/arm-smmu: fix error return code in arm_smmu_device_dt_probe() Wei Yongjun
2013-11-15 12:48 ` Will Deacon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).