linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: sunxi: dt: add EMAC aliases
Date: Sat, 16 Nov 2013 07:32:35 +0100	[thread overview]
Message-ID: <20131116063235.GH3538@lukather> (raw)
In-Reply-To: <1384546600-14384-1-git-send-email-emilio@elopez.com.ar>

Hi Emilio,

On Fri, Nov 15, 2013 at 05:16:40PM -0300, Emilio L?pez wrote:
> U-Boot uses the ethernet0 alias to locate the right node to fill in
> the MAC address of the first ethernet interface. This patch adds the
> alias on all the sunxi boards with EMAC and an ethernet port. In this
> way, people using ethernet in U-Boot (eg, for tftp) can keep a consistent
> address on both U-Boot and Linux with no additional effort.
> 
> Signed-off-by: Emilio L?pez <emilio@elopez.com.ar>
> ---
> 
> Hi everyone,
> 
> I have tested this on a cubieboard2 and found it to work as intended, 
> and I don't see why it wouldn't work on the other boards, given that 
> the U-Boot codebase is shared. It may be worth submitting this for 
> 3.13-rc0, but I'm not the one that has to make that call :)
> 
> Cheers,
> 
> Emilio
> 
>  arch/arm/boot/dts/sun4i-a10-a1000.dts            | 1 +
>  arch/arm/boot/dts/sun4i-a10-cubieboard.dts       | 1 +
>  arch/arm/boot/dts/sun4i-a10-hackberry.dts        | 4 ++++
>  arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts | 4 ++++
>  arch/arm/boot/dts/sun7i-a20-cubieboard2.dts      | 4 ++++
>  arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts  | 4 ++++
>  6 files changed, 18 insertions(+)

I think it would make more sense to add it to the dtsi.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131116/aeaed47a/attachment.sig>

  reply	other threads:[~2013-11-16  6:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-15 20:16 [PATCH] ARM: sunxi: dt: add EMAC aliases Emilio López
2013-11-16  6:32 ` Maxime Ripard [this message]
2013-11-16 18:17 ` [PATCH v2] " Emilio López
2013-11-16 23:37   ` Michal Suchanek
2013-11-16 23:48     ` Emilio López
2013-11-17  8:38       ` Maxime Ripard
2013-11-18 13:07         ` Michal Suchanek
2013-11-18 13:14           ` Maxime Ripard
2013-11-17  8:52   ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131116063235.GH3538@lukather \
    --to=maxime.ripard@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).