From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv7] dmaengine: Add support for BCM2835
Date: Mon, 18 Nov 2013 14:54:00 +0000 [thread overview]
Message-ID: <20131118145400.GE16735@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1384785017.14845.214.camel@smile>
On Mon, Nov 18, 2013 at 04:30:17PM +0200, Andy Shevchenko wrote:
> On Mon, 2013-11-18 at 13:16 +0100, Florian Meier wrote:
> > >> + uint32_t chans_available;
> > >
> > > Why uint32_t?
> >
> > Because it is a bit mask of fixed length that directly comes from the
> > firmware.
>
> Like one already told you in your i2s patch, please, change that to
> corresponding u* value, namely u32.
There's no problem with uint32_t vs u32 - either will do. u32 is the
pre-stdint.h Linux definition of a 32-bit unsigned integer. There's
no reason why uint32_t isn't perfectly acceptable. It's a matter of
author taste which gets used. (Except where modifications are to an
existing chunk of code using one or the other - where consistency then
matters more.)
next prev parent reply other threads:[~2013-11-18 14:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-17 15:39 [PATCHv7] dmaengine: Add support for BCM2835 Florian Meier
2013-11-17 16:02 ` Joe Perches
2013-11-17 16:37 ` Florian Meier
2013-11-17 20:12 ` [PATCH] mmp_pdma: Style neatening Joe Perches
2013-11-28 9:34 ` Vinod Koul
2013-11-18 10:00 ` [PATCHv7] dmaengine: Add support for BCM2835 Shevchenko, Andriy
2013-11-18 12:16 ` Florian Meier
2013-11-18 14:30 ` Andy Shevchenko
2013-11-18 14:37 ` Florian Meier
2013-11-18 14:54 ` Russell King - ARM Linux [this message]
2013-11-18 15:04 ` Mark Rutland
2013-11-18 22:18 ` Joe Perches
2013-11-18 14:41 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131118145400.GE16735@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).