From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv3] ASoC: Add support for BCM2835
Date: Mon, 18 Nov 2013 15:06:19 +0000 [thread overview]
Message-ID: <20131118150619.GL30853@e106331-lin.cambridge.arm.com> (raw)
In-Reply-To: <528A232B.9070402@metafoo.de>
On Mon, Nov 18, 2013 at 02:24:43PM +0000, Lars-Peter Clausen wrote:
> On 11/18/2013 03:16 PM, Mark Rutland wrote:
> >
> >> +static void bcm2835_i2s_stop_clock(struct bcm2835_i2s_dev *dev)
> >> +{
> >> + uint32_t clkreg;
> >
> > s/uint32_t/u32/ (and elsewhere...)
>
> Please don't do that.
>
I was under the impression that there was a preference for uXX types
over uintXX_t types, but the replies and Documentation/CodingStyle have
taught me otherwise.
Apologies for the confusion here.
Thanks,
Mark.
next prev parent reply other threads:[~2013-11-18 15:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-18 11:28 [PATCHv3] ASoC: Add support for BCM2835 Florian Meier
2013-11-18 12:08 ` Shevchenko, Andriy
2013-11-18 15:56 ` Florian Meier
2013-11-18 14:16 ` Mark Rutland
2013-11-18 14:24 ` Lars-Peter Clausen
2013-11-18 15:06 ` Mark Rutland [this message]
2013-11-18 14:25 ` Florian Meier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131118150619.GL30853@e106331-lin.cambridge.arm.com \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).