linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: s.trumtrar@pengutronix.de (Steffen Trumtrar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/4] Socfpga: clk: trivial fixes and cleanup
Date: Tue, 19 Nov 2013 09:14:55 +0100	[thread overview]
Message-ID: <20131119081455.GD7443@pengutronix.de> (raw)
In-Reply-To: <CADhT+wffgF1veA8ec4zF7J3_4tsKUZXcq5-X9cLCgN5D3A7Nrw@mail.gmail.com>

Hi Dinh!

On Mon, Nov 18, 2013 at 11:11:52AM -0600, Dinh Nguyen wrote:
> Hi Steffen,
> 
> 
> On Tue, Nov 12, 2013 at 1:40 AM, Steffen Trumtrar <s.trumtrar@pengutronix.de
> > wrote:
> > I actually also wanted to change the l3_sp_clk, as it seems to be neglect
> > the "1 or 2" divider from l3_mp_clk IIRC, but I couldn't come up with a
> > good
> > way without changing the binding or something. What do you thing about
> > that?
> > Is that wrong at the moment or do I miss something?
> >
> 
> Ah yes, the l3_sp_clk's parent should be l3_mp_clk and not mainclk.
> 
> Thanks for spotting that...
> 
> Dinh
> 

Hm, that doesn't sound right. Don't we currently have Gate+Divider combo in
the l3_mp_clk? If you turn off the clock gate from the l3_mp_clk, then l3_sp_clk
would also be turned off.
But according to Figure 2-3 in cv_5v4.pdf

	DIV1 --------> GATE -----> L3_MP_CLK
                 |
		 |---- DIV2 -----> L3_SP_CLK

So, l3_sp_clk's parent is the divider of l3_mp_clk but NOT the gate.

Regards,
Steffen

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  parent reply	other threads:[~2013-11-19  8:14 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-07 15:07 [PATCH 0/4] Socfpga: clk: trivial fixes and cleanup Steffen Trumtrar
2013-11-07 15:07 ` [PATCH 1/4] ARM: socfpga: clk: remove unused field Steffen Trumtrar
2013-11-07 15:07 ` [PATCH 2/4] ARM: socfpga: clk: fix define typo Steffen Trumtrar
2013-11-07 15:07 ` [PATCH 3/4] ARM: socfpga: clk: split clk code Steffen Trumtrar
2013-11-07 15:07 ` [PATCH 4/4] ARM: socfpga: clk: add clk_divider to periph Steffen Trumtrar
2013-11-12  0:12 ` [PATCH 0/4] Socfpga: clk: trivial fixes and cleanup Dinh Nguyen
2013-11-12  3:40   ` Dinh Nguyen
2013-11-12  7:40     ` Steffen Trumtrar
     [not found]       ` <CADhT+wffgF1veA8ec4zF7J3_4tsKUZXcq5-X9cLCgN5D3A7Nrw@mail.gmail.com>
2013-11-19  8:14         ` Steffen Trumtrar [this message]
2013-11-19 16:21           ` Dinh Nguyen
2013-11-19 21:34           ` Dinh Nguyen
2013-11-19 22:07             ` Steffen Trumtrar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131119081455.GD7443@pengutronix.de \
    --to=s.trumtrar@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).