linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] Documentation: dt: Add kona-pwm binding
Date: Tue, 19 Nov 2013 13:56:54 +0000	[thread overview]
Message-ID: <20131119135654.GL5914@e106331-lin.cambridge.arm.com> (raw)
In-Reply-To: <1384800901-21711-2-git-send-email-tim.kryger@linaro.org>

On Mon, Nov 18, 2013 at 06:54:57PM +0000, Tim Kryger wrote:
> Add the binding description for the kona-pwm block found on Broadcom's
> mobile SoCs.
> 
> Signed-off-by: Tim Kryger <tim.kryger@linaro.org>
> Reviewed-by: Alex Elder <elder@linaro.org>
> Reviewed-by: Markus Mayer <markus.mayer@linaro.org>
> ---
>  .../devicetree/bindings/pwm/bcm-kona-pwm.txt       | 24 ++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/pwm/bcm-kona-pwm.txt
> 
> diff --git a/Documentation/devicetree/bindings/pwm/bcm-kona-pwm.txt b/Documentation/devicetree/bindings/pwm/bcm-kona-pwm.txt
> new file mode 100644
> index 0000000..5c3ea1b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pwm/bcm-kona-pwm.txt
> @@ -0,0 +1,24 @@
> +Broadcom's PWM Controller Device Tree bindings
> +
> +Broadcom's Kona PWM Controller has 6 channels
> +
> +Required Properties :
> +- compatible: should be "brcm,kona-pwm"
> +- reg: physical base address and length of the controller's registers
> +- clocks: clock specifier for the kona pwm external clock

Minor nit: phandle + clock-specifier pair

> +- #pwm-cells: should be 2.  The first cell specifies the per-chip index
> +  of the PWM to use and the second cell is the period in nanoseconds.
> +
> +Refer to pwm/pwm.txt for generic pwm controller node properties.
> +
> +Refer to clocks/clock-bindings.txt for generic clock consumer
> +properties
> +
> +Example:
> +
> +pwm: pwm at 3e01a000 {
> +	compatible = "brcm,bcm11351-pwm", "brcm,kona-pwm";
> +	reg = <0x3e01a000 0xc4>;
> +	clocks = <&pwm_clk>;
> +	#pwm-cells = <2>;
> +};

Otherwise this looks fine.

Mark.

  reply	other threads:[~2013-11-19 13:56 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-18 18:54 [PATCH 0/5] Add Broadcom Kona PWM Support Tim Kryger
2013-11-18 18:54 ` [PATCH 1/5] Documentation: dt: Add kona-pwm binding Tim Kryger
2013-11-19 13:56   ` Mark Rutland [this message]
2013-11-26  1:41     ` Tim Kryger
2013-11-25 11:17   ` Thierry Reding
2013-11-26  1:50     ` Tim Kryger
2013-11-18 18:54 ` [PATCH 2/5] pwm: kona: Introduce Kona PWM controller support Tim Kryger
2013-11-25 11:08   ` Thierry Reding
2013-11-26  1:38     ` Tim Kryger
2013-11-26  9:45       ` Thierry Reding
2013-11-26 21:32         ` Tim Kryger
2013-11-18 18:54 ` [PATCH 3/5] ARM: dts: Declare the PWM for bcm11351 (bcm281xx) Tim Kryger
2013-11-18 18:55 ` [PATCH 4/5] ARM: dts: Enable the PWM for bcm28155 AP board Tim Kryger
2013-11-18 18:55 ` [PATCH 5/5] ARM: bcm_defconfig: Enable PWM and Backlight Tim Kryger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131119135654.GL5914@e106331-lin.cambridge.arm.com \
    --to=mark.rutland@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).