From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH 1/6] ahci: imx: Explicitly clear IMX6Q_GPR13_SATA_MPLL_CLK_EN
Date: Wed, 20 Nov 2013 16:11:43 +0100 [thread overview]
Message-ID: <201311201611.44120.marex@denx.de> (raw)
In-Reply-To: <20131120145907.GA28946@htj.dyndns.org>
Hello Tejun,
> On Wed, Nov 20, 2013 at 11:27:22AM +0100, Marek Vasut wrote:
> > We must clear this IMX6Q_GPR13_SATA_MPLL_CLK_EN bit on i.MX6Q, otherwise
> > Linux will fail to find the attached drive on some boards.
> >
> > This entire fix was:
> > Reported-by: Eric Nelson <eric.nelson@boundarydevices.com>
> >
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Shawn Guo <shawn.guo@linaro.org>
> > Cc: Richard Zhu <r65037@freescale.com>
> > Cc: Tejun Heo <tj@kernel.org>
> > Cc: Linux-IDE <linux-ide@vger.kernel.org>
> > ---
> >
> > drivers/ata/ahci_imx.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > RESEND: Fix the Cc here.
> >
> > diff --git a/drivers/ata/ahci_imx.c b/drivers/ata/ahci_imx.c
> > index ae2d73f..478921b 100644
> > --- a/drivers/ata/ahci_imx.c
> > +++ b/drivers/ata/ahci_imx.c
> > @@ -125,6 +125,7 @@ static int imx6q_sata_init(struct device *dev, void
> > __iomem *mmio)
> >
> > | IMX6Q_GPR13_SATA_TX_BOOST_MASK
> > | IMX6Q_GPR13_SATA_TX_LVL_MASK
> > | IMX6Q_GPR13_SATA_TX_EDGE_RATE
> >
> > + | IMX6Q_GPR13_SATA_MPLL_CLK_EN
> >
> > , IMX6Q_GPR13_SATA_RX_EQ_VAL_3_0_DB
> >
> > | IMX6Q_GPR13_SATA_RX_LOS_LVL_SATA2M
> > | IMX6Q_GPR13_SATA_RX_DPLL_MODE_2P_4F
>
> Not your fault but when things stretch over multiples lines, the
> convention is to put the operators and commas at the end of each line
> not the other way around. I'd appreciate if you add a trivial patch
> to update that too.
It's already done in 2/6 of the series, I hope that is OK. Otherwise I can
separate this formating change from the 2/6 patch and shove it in front of this
one even. Which one do you prefer please?
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-11-20 15:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-20 10:17 [PATCH 1/6] ahci: imx: Explicitly clear IMX6Q_GPR13_SATA_MPLL_CLK_EN Marek Vasut
2013-11-20 10:17 ` [PATCH V4 2/6] ahci: imx: Pull out the clock enable/disable calls Marek Vasut
2013-11-20 12:55 ` Shawn Guo
2013-11-20 10:17 ` [PATCH V4 3/6] ahci: imx: Add i.MX53 support Marek Vasut
2013-11-20 10:17 ` [PATCH V2 4/6] ARM: imx: imx53: Add SATA PHY clock Marek Vasut
2013-11-20 10:17 ` [PATCH V2 5/6] ARM: dts: imx53: Add AHCI SATA DT node Marek Vasut
2013-11-20 10:17 ` [PATCH 6/6] ARM: dts: imx53: Enable AHCI SATA for M53EVK Marek Vasut
2013-11-20 10:27 ` [RESEND PATCH 1/6] ahci: imx: Explicitly clear IMX6Q_GPR13_SATA_MPLL_CLK_EN Marek Vasut
2013-11-20 12:51 ` Shawn Guo
2013-11-20 14:59 ` Tejun Heo
2013-11-20 15:11 ` Marek Vasut [this message]
2013-11-20 15:13 ` Tejun Heo
2013-11-22 10:47 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201311201611.44120.marex@denx.de \
--to=marex@denx.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).