* [PATCH] ARM: shmobile: Fix r8a7791 GPIO resources in DTS
@ 2013-11-21 0:42 Magnus Damm
2013-11-21 0:48 ` Kuninori Morimoto
0 siblings, 1 reply; 3+ messages in thread
From: Magnus Damm @ 2013-11-21 0:42 UTC (permalink / raw)
To: linux-arm-kernel
From: Magnus Damm <damm@opensource.se>
The r8a7791 GPIO resources are currently incorrect. Fix that
by making them match the information in the data sheet.
Tested with GPIO LED using Koelsch DT reference.
Signed-off-by: Magnus Damm <damm@opensource.se>
---
arch/arm/boot/dts/r8a7791.dtsi | 32 ++++++++++++++++----------------
1 file changed, 16 insertions(+), 16 deletions(-)
--- 0021/arch/arm/boot/dts/r8a7791.dtsi
+++ work/arch/arm/boot/dts/r8a7791.dtsi 2013-11-20 17:28:26.000000000 +0900
@@ -49,9 +49,9 @@
interrupts = <1 9 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>;
};
- gpio0: gpio at ffc40000 {
+ gpio0: gpio at e6050000 {
compatible = "renesas,gpio-r8a7791", "renesas,gpio-rcar";
- reg = <0 0xffc40000 0 0x50>;
+ reg = <0 0xe6050000 0 0x50>;
interrupt-parent = <&gic>;
interrupts = <0 4 IRQ_TYPE_LEVEL_HIGH>;
#gpio-cells = <2>;
@@ -61,9 +61,9 @@
interrupt-controller;
};
- gpio1: gpio at ffc41000 {
+ gpio1: gpio at e6051000 {
compatible = "renesas,gpio-r8a7791", "renesas,gpio-rcar";
- reg = <0 0xffc41000 0 0x50>;
+ reg = <0 0xe6051000 0 0x50>;
interrupt-parent = <&gic>;
interrupts = <0 5 IRQ_TYPE_LEVEL_HIGH>;
#gpio-cells = <2>;
@@ -73,9 +73,9 @@
interrupt-controller;
};
- gpio2: gpio at ffc42000 {
+ gpio2: gpio at e6052000 {
compatible = "renesas,gpio-r8a7791", "renesas,gpio-rcar";
- reg = <0 0xffc42000 0 0x50>;
+ reg = <0 0xe6052000 0 0x50>;
interrupt-parent = <&gic>;
interrupts = <0 6 IRQ_TYPE_LEVEL_HIGH>;
#gpio-cells = <2>;
@@ -85,9 +85,9 @@
interrupt-controller;
};
- gpio3: gpio at ffc43000 {
+ gpio3: gpio at e6053000 {
compatible = "renesas,gpio-r8a7791", "renesas,gpio-rcar";
- reg = <0 0xffc43000 0 0x50>;
+ reg = <0 0xe6053000 0 0x50>;
interrupt-parent = <&gic>;
interrupts = <0 7 IRQ_TYPE_LEVEL_HIGH>;
#gpio-cells = <2>;
@@ -97,9 +97,9 @@
interrupt-controller;
};
- gpio4: gpio at ffc44000 {
+ gpio4: gpio at e6054000 {
compatible = "renesas,gpio-r8a7791", "renesas,gpio-rcar";
- reg = <0 0xffc44000 0 0x50>;
+ reg = <0 0xe6054000 0 0x50>;
interrupt-parent = <&gic>;
interrupts = <0 8 IRQ_TYPE_LEVEL_HIGH>;
#gpio-cells = <2>;
@@ -109,9 +109,9 @@
interrupt-controller;
};
- gpio5: gpio at ffc45000 {
+ gpio5: gpio at e6055000 {
compatible = "renesas,gpio-r8a7791", "renesas,gpio-rcar";
- reg = <0 0xffc45000 0 0x50>;
+ reg = <0 0xe6055000 0 0x50>;
interrupt-parent = <&gic>;
interrupts = <0 9 IRQ_TYPE_LEVEL_HIGH>;
#gpio-cells = <2>;
@@ -121,9 +121,9 @@
interrupt-controller;
};
- gpio6: gpio at ffc45400 {
+ gpio6: gpio at e6055400 {
compatible = "renesas,gpio-r8a7791", "renesas,gpio-rcar";
- reg = <0 0xffc45400 0 0x50>;
+ reg = <0 0xe6055400 0 0x50>;
interrupt-parent = <&gic>;
interrupts = <0 10 IRQ_TYPE_LEVEL_HIGH>;
#gpio-cells = <2>;
@@ -133,9 +133,9 @@
interrupt-controller;
};
- gpio7: gpio at ffc45800 {
+ gpio7: gpio at e6055800 {
compatible = "renesas,gpio-r8a7791", "renesas,gpio-rcar";
- reg = <0 0xffc45800 0 0x50>;
+ reg = <0 0xe6055800 0 0x50>;
interrupt-parent = <&gic>;
interrupts = <0 11 IRQ_TYPE_LEVEL_HIGH>;
#gpio-cells = <2>;
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] ARM: shmobile: Fix r8a7791 GPIO resources in DTS
2013-11-21 0:42 [PATCH] ARM: shmobile: Fix r8a7791 GPIO resources in DTS Magnus Damm
@ 2013-11-21 0:48 ` Kuninori Morimoto
2013-11-21 4:40 ` Magnus Damm
0 siblings, 1 reply; 3+ messages in thread
From: Kuninori Morimoto @ 2013-11-21 0:48 UTC (permalink / raw)
To: linux-arm-kernel
Hi Magnus
> The r8a7791 GPIO resources are currently incorrect. Fix that
> by making them match the information in the data sheet.
Can you add your using datasheet version here ?
like "this patch is based on vX.X datasheet"
Same comment to r8a7790 patch
>
> Tested with GPIO LED using Koelsch DT reference.
>
> Signed-off-by: Magnus Damm <damm@opensource.se>
> ---
>
> arch/arm/boot/dts/r8a7791.dtsi | 32 ++++++++++++++++----------------
> 1 file changed, 16 insertions(+), 16 deletions(-)
>
> --- 0021/arch/arm/boot/dts/r8a7791.dtsi
> +++ work/arch/arm/boot/dts/r8a7791.dtsi 2013-11-20 17:28:26.000000000 +0900
> @@ -49,9 +49,9 @@
> interrupts = <1 9 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>;
> };
>
> - gpio0: gpio at ffc40000 {
> + gpio0: gpio at e6050000 {
> compatible = "renesas,gpio-r8a7791", "renesas,gpio-rcar";
> - reg = <0 0xffc40000 0 0x50>;
> + reg = <0 0xe6050000 0 0x50>;
> interrupt-parent = <&gic>;
> interrupts = <0 4 IRQ_TYPE_LEVEL_HIGH>;
> #gpio-cells = <2>;
> @@ -61,9 +61,9 @@
> interrupt-controller;
> };
>
> - gpio1: gpio at ffc41000 {
> + gpio1: gpio at e6051000 {
> compatible = "renesas,gpio-r8a7791", "renesas,gpio-rcar";
> - reg = <0 0xffc41000 0 0x50>;
> + reg = <0 0xe6051000 0 0x50>;
> interrupt-parent = <&gic>;
> interrupts = <0 5 IRQ_TYPE_LEVEL_HIGH>;
> #gpio-cells = <2>;
> @@ -73,9 +73,9 @@
> interrupt-controller;
> };
>
> - gpio2: gpio at ffc42000 {
> + gpio2: gpio at e6052000 {
> compatible = "renesas,gpio-r8a7791", "renesas,gpio-rcar";
> - reg = <0 0xffc42000 0 0x50>;
> + reg = <0 0xe6052000 0 0x50>;
> interrupt-parent = <&gic>;
> interrupts = <0 6 IRQ_TYPE_LEVEL_HIGH>;
> #gpio-cells = <2>;
> @@ -85,9 +85,9 @@
> interrupt-controller;
> };
>
> - gpio3: gpio at ffc43000 {
> + gpio3: gpio at e6053000 {
> compatible = "renesas,gpio-r8a7791", "renesas,gpio-rcar";
> - reg = <0 0xffc43000 0 0x50>;
> + reg = <0 0xe6053000 0 0x50>;
> interrupt-parent = <&gic>;
> interrupts = <0 7 IRQ_TYPE_LEVEL_HIGH>;
> #gpio-cells = <2>;
> @@ -97,9 +97,9 @@
> interrupt-controller;
> };
>
> - gpio4: gpio at ffc44000 {
> + gpio4: gpio at e6054000 {
> compatible = "renesas,gpio-r8a7791", "renesas,gpio-rcar";
> - reg = <0 0xffc44000 0 0x50>;
> + reg = <0 0xe6054000 0 0x50>;
> interrupt-parent = <&gic>;
> interrupts = <0 8 IRQ_TYPE_LEVEL_HIGH>;
> #gpio-cells = <2>;
> @@ -109,9 +109,9 @@
> interrupt-controller;
> };
>
> - gpio5: gpio at ffc45000 {
> + gpio5: gpio at e6055000 {
> compatible = "renesas,gpio-r8a7791", "renesas,gpio-rcar";
> - reg = <0 0xffc45000 0 0x50>;
> + reg = <0 0xe6055000 0 0x50>;
> interrupt-parent = <&gic>;
> interrupts = <0 9 IRQ_TYPE_LEVEL_HIGH>;
> #gpio-cells = <2>;
> @@ -121,9 +121,9 @@
> interrupt-controller;
> };
>
> - gpio6: gpio at ffc45400 {
> + gpio6: gpio at e6055400 {
> compatible = "renesas,gpio-r8a7791", "renesas,gpio-rcar";
> - reg = <0 0xffc45400 0 0x50>;
> + reg = <0 0xe6055400 0 0x50>;
> interrupt-parent = <&gic>;
> interrupts = <0 10 IRQ_TYPE_LEVEL_HIGH>;
> #gpio-cells = <2>;
> @@ -133,9 +133,9 @@
> interrupt-controller;
> };
>
> - gpio7: gpio at ffc45800 {
> + gpio7: gpio at e6055800 {
> compatible = "renesas,gpio-r8a7791", "renesas,gpio-rcar";
> - reg = <0 0xffc45800 0 0x50>;
> + reg = <0 0xe6055800 0 0x50>;
> interrupt-parent = <&gic>;
> interrupts = <0 11 IRQ_TYPE_LEVEL_HIGH>;
> #gpio-cells = <2>;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Best regards
---
Kuninori Morimoto
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] ARM: shmobile: Fix r8a7791 GPIO resources in DTS
2013-11-21 0:48 ` Kuninori Morimoto
@ 2013-11-21 4:40 ` Magnus Damm
0 siblings, 0 replies; 3+ messages in thread
From: Magnus Damm @ 2013-11-21 4:40 UTC (permalink / raw)
To: linux-arm-kernel
Hi Morimoto-san,
On Thu, Nov 21, 2013 at 9:48 AM, Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
>
> Hi Magnus
>
>> The r8a7791 GPIO resources are currently incorrect. Fix that
>> by making them match the information in the data sheet.
>
> Can you add your using datasheet version here ?
> like "this patch is based on vX.X datasheet"
> Same comment to r8a7790 patch
Sure, good idea. I will provide updated patches early next week,
Regarding access to the latest data sheet, let's discuss that off line.
Cheers,
/ magnus
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-11-21 4:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-21 0:42 [PATCH] ARM: shmobile: Fix r8a7791 GPIO resources in DTS Magnus Damm
2013-11-21 0:48 ` Kuninori Morimoto
2013-11-21 4:40 ` Magnus Damm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox