[PATCH v3 4/5] regulator: max14577: Add regulator driver for Maxim 14577

Bartlomiej Zolnierkiewicz
2013-11-22T13:00:44Z

Hi,

On Friday, November 22, 2013 09:46:11 AM Krzysztof Kozlowski wrote:

[...]

> +static int max14577_regulator_probe(struct platform_device *pdev)
> +{
> + struct max14577 *max14577 = dev_get_drvdata(pdev->dev.parent);
> + struct max14577_platform_data *pdata = dev_get_platdata(max14577->dev);
> + int i, size;
> + struct regulator_config config = {};
> + struct regulator_dev **regulators;
> +
> + if (!pdata) {
> + /* Parent must provide pdata */
> + dev_err(&pdev->dev, "No MFD driver platform data found.\n");
> + return -ENODEV;
> + }
> +
> + if (max14577->dev->of_node) {
> + int ret = max14577_regulator_dt_parse_pdata(pdev, pdata);
> + if (ret)
> + return ret;
> + }
> +
> + size = sizeof(struct regulator_dev *) * ARRAY_SIZE(supported_regulators);
> + regulators = devm_kzalloc(&pdev->dev, size, GFP_KERNEL);
> + if (!regulators) {
> + dev_err(&pdev->dev, "Cannot allocate memory for regulators\n");
> + return -ENOMEM;
> + }
> +
> + config.dev = &pdev->dev;
> + config.regmap = max14577->regmap;
> +
> + for (i = 0; i < ARRAY_SIZE(supported_regulators); i++) {
> + /*
> + * Index of supported_regulators[] is also the id and must
> + * match index of pdata->regulators[].
> + */
> + config.init_data = pdata->regulators[i].initdata;
> + config.of_node = pdata->regulators[i].of_node;
> +
> + regulators[i] = devm_regulator_register(&pdev->dev,
> + &supported_regulators[i], &config);
> + if (IS_ERR(regulators[i])) {
> + int ret = PTR_ERR(regulators[i]);

This can be cleaned up further. The code just needs a single "struct
regulator_dev *regulator" (which can be declared inside "for" loop)
instead of an array.

> + dev_err(&pdev->dev,
> + "Regulator init failed for ID %d with error: %d\n",
> + i, ret);
> + return ret;
> + }
> + }
> +
> + return 0;
> +}

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics