crypto dependency in bit sliced AES

crypto dependency in bit sliced AES

[Ard Biesheuvel]

Hello Russell,

To my surprise, Linus has decided to release 3.13-rc1 without honoring
Herbert's crypto pull requests for 3.13

http://marc.info/?l=linux-crypto-vger&m=138381130023859&w=2
http://marc.info/?l=linux-crypto-vger&m=138482768727213&w=2

which contain my patch 'crypto: create generic version of ablk_helper'

https://git.kernel.org/cgit/linux/kernel/git/herbert/crypto-2.6.git/commit/?id=a62b01cd6cc1feb5e80d64d6937c291473ed82cb

I can only guess what the reason is (probably something as simple as
the word PULL missing from the subject line), but it does mean that
the bit sliced AES code still does not build, unfortunately.

Regards,
Ard.

crypto dependency in bit sliced AES

[Russell King - ARM Linux]

On Fri, Nov 22, 2013 at 11:09:00PM +0100, Ard Biesheuvel wrote:
> Hello Russell,
> 
> To my surprise, Linus has decided to release 3.13-rc1 without honoring
> Herbert's crypto pull requests for 3.13
> 
> http://marc.info/?l=linux-crypto-vger&m=138381130023859&w=2
> http://marc.info/?l=linux-crypto-vger&m=138482768727213&w=2
> 
> which contain my patch 'crypto: create generic version of ablk_helper'

That's annoying.  Linus, is there any chance that this missed pull
request could happen?  It's clearly been missed for what ever reason.

If not, the commit which seems to need reverting is:
	e4e7f10bfc4069925e99cc4b428c3434e30b6c3f

crypto dependency in bit sliced AES

[Linus Torvalds]

On Fri, Nov 22, 2013 at 2:52 PM, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
> On Fri, Nov 22, 2013 at 11:09:00PM +0100, Ard Biesheuvel wrote:
>> Hello Russell,
>>
>> To my surprise, Linus has decided to release 3.13-rc1 without honoring
>> Herbert's crypto pull requests for 3.13
>>
>> http://marc.info/?l=linux-crypto-vger&m=138381130023859&w=2
>> http://marc.info/?l=linux-crypto-vger&m=138482768727213&w=2
>>
>> which contain my patch 'crypto: create generic version of ablk_helper'
>
> That's annoying.  Linus, is there any chance that this missed pull
> request could happen?  It's clearly been missed for what ever reason.

So looking through my emails, I don't have it, but since it clearly
made it to lkml, I accept that Herbert sent it to me in time. It
probably got eaten as spam, I think we've had that issue with Herbert
before.

Herbert, any idea why gmail would consider your emails spam? Mind
re-sending it once more, and I'll try to see if I get it..

I actually see an email from Herbert *replying* to Borislav in my
archives, but I do not see the pull request emails themselves.

              Linus

crypto dependency in bit sliced AES

[Herbert Xu]

On Fri, Nov 22, 2013 at 03:48:24PM -0800, Linus Torvalds wrote:
>
> Herbert, any idea why gmail would consider your emails spam? Mind
> re-sending it once more, and I'll try to see if I get it..

Sure I've just done a resend.

> I actually see an email from Herbert *replying* to Borislav in my
> archives, but I do not see the pull request emails themselves.

Based on that perhaps it's because I have too many (4) recipients
in the pull request?

I'll do another resend and move the receipients into the cc field.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

crypto dependency in bit sliced AES

[Linus Torvalds]

Both this email *and* your repeated pull request again got marked as spam.

It has nothing to do with the number of recipients (which wasn't that
big anyway).

At a guess, it's something about your "gondor.apana.org.au" address
that makes gmail just hate you. In particular it is likely related to
this:

  Received-SPF: neutral (google.com: 178.18.16.133 is neither
permitted nor denied by best guess record for domain of
herbert at gondor.apana.org.au) client-ip=178.18.16.133;
  Authentication-Results: mx.google.com;
       spf=neutral (google.com: 178.18.16.133 is neither permitted nor
denied by best guess record for domain of herbert at gondor.apana.org.au)
smtp.mail=herbert at gondor.apana.org.au

with that whole "best guess record for domain" crap. So at the very
least your spf records are questionable.

And when I do "nslookup -q=mx gondor.apana.org.au" I get:

  Server: 192.168.0.1
  Address: 192.168.0.1#53

  Non-authoritative answer:
  gondor.apana.org.au canonical name = gondor.hengli.com.au.
  gondor.hengli.com.au mail exchanger = 10 mx2.hengli.com.au.
  gondor.hengli.com.au mail exchanger = 5 mx1.hengli.com.au.

  Authoritative answers can be found from:"

where it's worth noting that the sources of authoritative answers is
an empty list.

So your email setup looks rather questionable. Which is most likely
why gmail spam filters hate you.

I've marked those messages as not being spam, but quite frankly, this
will likely continue to be a problem unless you try to sort out your
mail sending ways. The fact is, spam is a huge problem, and people who
send messages from hosts that don't actively try to validate the email
are going to be part of the problem.

I do not know if it's your own host, or apana.org.au that ends up
being the problem. Please talk to people who actually know about all
the SPF rules etc.

             Linus

On Fri, Nov 22, 2013 at 5:39 PM, Herbert Xu <herbert@gondor.apana.org.au> wrote:
> On Fri, Nov 22, 2013 at 03:48:24PM -0800, Linus Torvalds wrote:
>>
>> Herbert, any idea why gmail would consider your emails spam? Mind
>> re-sending it once more, and I'll try to see if I get it..
>
> Sure I've just done a resend.
>
>> I actually see an email from Herbert *replying* to Borislav in my
>> archives, but I do not see the pull request emails themselves.
>
> Based on that perhaps it's because I have too many (4) recipients
> in the pull request?
>
> I'll do another resend and move the receipients into the cc field.
>
> Thanks,
> --
> Email: Herbert Xu <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

crypto dependency in bit sliced AES

[Russell King - ARM Linux]

On Sat, Nov 23, 2013 at 04:16:18PM -0800, Linus Torvalds wrote:
>   Received-SPF: neutral (google.com: 178.18.16.133 is neither
> permitted nor denied by best guess record for domain of
> herbert at gondor.apana.org.au) client-ip=178.18.16.133;
>   Authentication-Results: mx.google.com;
>        spf=neutral (google.com: 178.18.16.133 is neither permitted nor
> denied by best guess record for domain of herbert at gondor.apana.org.au)
> smtp.mail=herbert at gondor.apana.org.au
> 
> with that whole "best guess record for domain" crap. So at the very
> least your spf records are questionable.
> 
> And when I do "nslookup -q=mx gondor.apana.org.au" I get:
> 
>   Server: 192.168.0.1
>   Address: 192.168.0.1#53
> 
>   Non-authoritative answer:
>   gondor.apana.org.au canonical name = gondor.hengli.com.au.
>   gondor.hengli.com.au mail exchanger = 10 mx2.hengli.com.au.
>   gondor.hengli.com.au mail exchanger = 5 mx1.hengli.com.au.
> 
>   Authoritative answers can be found from:"

What probably doesn't help is this... from my exim logs:

<= herbert at gondor.apana.org.au H=ringil.hengli.com.au
(fornost.hengli.com.au) [178.18.16.133]:51158 I=[78.32.30.222]:25 P=esmtps
X=TLSv1:AES256-SHA:256 S=2150 id=20131123013924.GA16533 at gondor.apana.org.au
T="Re: crypto dependency in bit sliced AES" for linux@arm.linux.org.uk

So, this was received from IP 178.18.16.133:
133.16.18.178.in-addr.arpa domain name pointer ringil.hengli.com.au.
ringil.hengli.com.au has address 178.18.16.133

Good, it matches - exim's H= line not being in parens also tells us that.

The EHLO string though (fornost.hengli.com.au):

fornost.hengli.com.au has address 209.40.204.226
226.204.40.209.in-addr.arpa domain name pointer helcar.apana.org.au.
helcar.apana.org.au has address 209.40.204.226

So, the SMTP server which claims to be fornost which seems to be running
on 178.18.16.133 has a different IP address in DNS of 209.40.204.226.
That probably doesn't help.

Let me put it another way: this makes it look like you're impersonating
a different server.  Now, while it may be true that EHLO strings aren't
supposed to be used to block email, there's allowable scope for "local
policy" to do things like treating such stuff as a potential spam source.

crypto dependency in bit sliced AES

[Herbert Xu]

On Sun, Nov 24, 2013 at 01:02:07AM +0000, Russell King - ARM Linux wrote:
> On Sat, Nov 23, 2013 at 04:16:18PM -0800, Linus Torvalds wrote:
> >   Received-SPF: neutral (google.com: 178.18.16.133 is neither
> > permitted nor denied by best guess record for domain of
> > herbert at gondor.apana.org.au) client-ip=178.18.16.133;
> >   Authentication-Results: mx.google.com;
> >        spf=neutral (google.com: 178.18.16.133 is neither permitted nor
> > denied by best guess record for domain of herbert at gondor.apana.org.au)
> > smtp.mail=herbert at gondor.apana.org.au
> > 
> > with that whole "best guess record for domain" crap. So at the very
> > least your spf records are questionable.
> > 
> > And when I do "nslookup -q=mx gondor.apana.org.au" I get:
> > 
> >   Server: 192.168.0.1
> >   Address: 192.168.0.1#53
> > 
> >   Non-authoritative answer:
> >   gondor.apana.org.au canonical name = gondor.hengli.com.au.
> >   gondor.hengli.com.au mail exchanger = 10 mx2.hengli.com.au.
> >   gondor.hengli.com.au mail exchanger = 5 mx1.hengli.com.au.
> > 
> >   Authoritative answers can be found from:"
> 
> What probably doesn't help is this... from my exim logs:
> 
> <= herbert@gondor.apana.org.au H=ringil.hengli.com.au
> (fornost.hengli.com.au) [178.18.16.133]:51158 I=[78.32.30.222]:25 P=esmtps
> X=TLSv1:AES256-SHA:256 S=2150 id=20131123013924.GA16533 at gondor.apana.org.au
> T="Re: crypto dependency in bit sliced AES" for linux at arm.linux.org.uk

OK, I've fixed the EHLO header and added an SPF record.  Hopefully
gmail will stop listing my emails as spam now.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

crypto dependency in bit sliced AES

[Linus Torvalds]

On Sat, Nov 23, 2013 at 11:56 PM, Herbert Xu
<herbert@gondor.apana.org.au> wrote:
>
> OK, I've fixed the EHLO header and added an SPF record.  Hopefully
> gmail will stop listing my emails as spam now.

Ok, at least this email came through. And I do see the SPF change:

  Received-SPF: pass (google.com: domain of
herbert at gondor.apana.org.au designates 178.18.16.133 as permitted
sender) client-ip=178.18.16.133;
  Authentication-Results: mx.google.com;
         spf=pass (google.com: domain of herbert at gondor.apana.org.au
designates 178.18.16.133 as permitted sender)
smtp.mail=herbert at gondor.apana.org.au
  Received: from gondolin.me.apana.org.au ([192.168.0.6])

so hopefully the success is indeed permanent.

              Linus