From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: pxa: Move iotable mapping inside vmalloc region
Date: Sun, 24 Nov 2013 12:41:25 +0000 [thread overview]
Message-ID: <20131124124125.GM16735@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1385296571-23599-1-git-send-email-ezequiel.garcia@free-electrons.com>
On Sun, Nov 24, 2013 at 09:36:11AM -0300, Ezequiel Garcia wrote:
> In order to remove the following ugly message:
>
> BUG: mapping for 0x00000000 at 0xff000000 out of vmalloc space
>
> the iotable mappings should be re-located inside the vmalloc
> region. Such move was introduced at commit:
>
> commit 0536bdf33faff4d940ac094c77998cfac368cfff
> Author: Nicolas Pitre <nicolas.pitre@linaro.org>
> Date: Thu Aug 25 00:35:59 2011 -0400
>
> ARM: move iotable mappings within the vmalloc region
>
> While at it, let's add some nicer defines to make the code
> more readable.
>
> Cc: Nicolas Pitre <nicolas.pitre@linaro.org>
> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
NAK. I'm guessing that you haven't properly tested this. Grep for
UNCACHED_PHYS_0, and what you'll find is that your change will break
standby and suspend on all PXA platforms.
next prev parent reply other threads:[~2013-11-24 12:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-24 12:36 [PATCH] ARM: pxa: Move iotable mapping inside vmalloc region Ezequiel Garcia
2013-11-24 12:41 ` Russell King - ARM Linux [this message]
2013-11-24 22:56 ` Ezequiel Garcia
2013-11-24 23:26 ` Nicolas Pitre
2013-11-25 11:11 ` Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131124124125.GM16735@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).