From mboxrd@z Thu Jan  1 00:00:00 1970
From: mpa@pengutronix.de (Markus Pargmann)
Date: Mon, 25 Nov 2013 10:45:50 +0100
Subject: [PATCH 2/8] ASoC: fsl-ssi: Move sysfs stats to debugfs
In-Reply-To: <20131122183356.GQ14725@sirena.org.uk>
References: <1384938262-20554-1-git-send-email-mpa@pengutronix.de>
 <1384938262-20554-3-git-send-email-mpa@pengutronix.de>
 <20131121142208.GU2674@sirena.org.uk>
 <20131122164204.GB5893@pengutronix.de>
 <20131122183356.GQ14725@sirena.org.uk>
Message-ID: <20131125094550.GA29656@pengutronix.de>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

Hi,

On Fri, Nov 22, 2013 at 06:33:56PM +0000, Mark Brown wrote:
> On Fri, Nov 22, 2013 at 05:42:04PM +0100, Markus Pargmann wrote:
> > On Thu, Nov 21, 2013 at 02:22:08PM +0000, Mark Brown wrote:
> > > On Wed, Nov 20, 2013 at 10:04:16AM +0100, Markus Pargmann wrote:
> 
> > > > This patch moves the statistics to debugfs and disables interrupts
> > > > completely if the kernel is build without DEBUG_FS enabled.
> 
> > > We can still see the error counts through /proc/interrupts even without
> > > the debugfs file.
> 
> > The interrupts are visible without the debugfs file when enabled through
> > SIER register. But it does not show the specific reason for the interrupts.
> 
> > I am not sure what you suggest. To remove the stats file completely and
> > always disable interrupts?
> 
> No, I'm suggesting not disabling interrupts completely when debugfs is
> disabled.  Since we can still see the interrupts happening even if
> debugfs is not enabled we're still getting diagnostics.

Okay, I will change it.

Thanks,

Markus


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |