public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: jason@lakedaemon.net (Jason Cooper)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] ARM: mvebu: use the virtual CPU registers to access coherency registers
Date: Mon, 25 Nov 2013 13:23:28 -0500	[thread overview]
Message-ID: <20131125182328.GC2879@titan.lakedaemon.net> (raw)
In-Reply-To: <1385396807-19027-4-git-send-email-thomas.petazzoni@free-electrons.com>

On Mon, Nov 25, 2013 at 05:26:46PM +0100, Thomas Petazzoni wrote:
> From: Gregory CLEMENT <gregory.clement@free-electrons.com>
> 
> The Armada XP provides a mechanism called "virtual CPU registers" or
> "per-CPU register banking", to access the per-CPU registers of the
> current CPU, without having to worry about finding on which CPU we're
> running. CPU0 has its registers at 0x21800, CPU1 at 0x21900, CPU2 at
> 0x21A00 and CPU3 at 0x21B00. The virtual registers accessing the
> current CPU registers are at 0x21000.
> 
> However, in the Device Tree node that provides the register addresses
> for the coherency unit (which is responsible for ensuring coherency
> between processors, and I/O coherency between processors and the
> DMA-capable devices), a mistake was made: the CPU0-specific registers
> were specified instead of the virtual CPU registers. This means that
> the coherency barrier needed for I/O coherency was not behaving
> properly when executed from a CPU different from CPU0. This patch
> fixes that by using the virtual CPU registers.
> 
> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: stable at vger.kernel.org
> ---
> This bug has been introduced in e60304f8cb7bb5 ("arm: mvebu: Add
> hardware I/O Coherency support"), merged in v3.8. Therefore this fix
> should be backported into -stable all the way to 3.8. Due to various
> reorganizations in the DT file, the patch will certainly not apply as
> is, but the fix itself is trivial.
> ---
>  arch/arm/boot/dts/armada-370-xp.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to mvebu/dt-fixes

thx,

Jason.

  reply	other threads:[~2013-11-25 18:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-25 16:26 [PATCH 0/4] ARM: mvebu: misc important fixes Thomas Petazzoni
2013-11-25 16:26 ` [PATCH 1/4] irqchip: armada-370-xp: fix IPI race condition Thomas Petazzoni
2013-11-25 18:17   ` Jason Cooper
2013-12-12 22:23   ` Thomas Petazzoni
2013-12-13 16:38     ` Jason Cooper
2013-12-14 17:35       ` Thomas Petazzoni
2013-11-25 16:26 ` [PATCH 2/4] irqchip: armada-370-xp: fix MSI " Thomas Petazzoni
2013-11-25 18:18   ` Jason Cooper
2013-11-25 16:26 ` [PATCH 3/4] ARM: mvebu: use the virtual CPU registers to access coherency registers Thomas Petazzoni
2013-11-25 18:23   ` Jason Cooper [this message]
2013-11-25 16:26 ` [PATCH 4/4] ARM: mvebu: re-enable PCIe on Armada 370 DB Thomas Petazzoni
2013-11-25 18:25   ` Jason Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131125182328.GC2879@titan.lakedaemon.net \
    --to=jason@lakedaemon.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox